Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Wed, 22 Nov 2023 10:51:46 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Mike Kravetz <mike.kravetz@oracle.com>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        John Hubbard <jhubbard@nvidia.com>,
        Mike Rapoport <rppt@kernel.org>,
        Hugh Dickins <hughd@google.com>,
        David Hildenbrand <david@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        James Houghton <jthoughton@google.com>,
        Yang Shi <shy828301@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RFC 00/12] mm/gup: Unify hugetlb, part 2
Message-ID: <20231122145146.GN6083@nvidia.com>
References: <20231116012908.392077-1-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231116012908.392077-1-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SqHUqgTpfVCfwLKinqDEw0rzGUk+VT6TkklKF/YHSeUasqIJEHTHtI38o6FH?=
 =?us-ascii?Q?qEt1FuNsFS9lNmVdMhFqdJJSvSH1Q6JpgamLc1gVDfFveoyCl92gL0QQh5wL?=
 =?us-ascii?Q?a+RnGKW3cCHTHYOJ3+B4LrpLVepTdIcsQv6T2hdXST82mj7eveffTZiAjrOL?=
 =?us-ascii?Q?uUXvTKS7hRpSTGc6B+5eBJsaRrnVmb6tKktKZSQE8qQw+jBxmoyFkGNon2Xk?=
 =?us-ascii?Q?EuCKEv7QQ7+Lu877NY3H9sywsjJQ9+M76Ih9mBU6RcXhZA8HfxJNY2W2cmJU?=
 =?us-ascii?Q?znTCYmM3iQJroSGI3ju8XO7hFN8lSJ3QD/p7jNr9KgAqGk73cEuDuKYZvibG?=
 =?us-ascii?Q?gEWptzXQKTUq95/RonptYhLJCMjmso0f0exkxdmzEEN0b1hr+Fpj3L02fi3i?=
 =?us-ascii?Q?e8Z3YR++ojHXh5YYwa4QQ+9/jYXHfkVawM59U8jp/R/ayPG9wvh0GfKtswe5?=
 =?us-ascii?Q?u24EMTxPRlG59gJzuCwwJCJN91weoaIFhklpyT5BVSnwguetnroGm6Qq2Mey?=
 =?us-ascii?Q?s+J4fSdajytzxvFG/tAXBMVNcP+W3+3iyaWg5NIZKuHR2aias1oWHH2+9gMe?=
 =?us-ascii?Q?scfI60R7vGHssQbYAX/sgFUa8l/NQqsS16JUTn7z+yH+K4gnhRTiwLT40XLx?=
 =?us-ascii?Q?wJIAEsNWJk6hYLdKeEIw2y4ETPfjh9PKS0mzWZKEM+1litY8yF2T9mu9cndl?=
 =?us-ascii?Q?UWbGjA7OnN8ajw5HqZ0+f7MyqzUamzl/+lZSijKW2GNgNjdoBQPq5tcN8Mti?=
 =?us-ascii?Q?NZZ8d9ob+hhPmOH5EFsLV0uxR/nnGpK996O3bFmt8gLT3b6+H7hRsnJTSbdn?=
 =?us-ascii?Q?FQDfd6EXK5VMq32lB9ExXMXL8GrH4d808CEl04TA1o9fD6EYa5UTomyjcmoZ?=
 =?us-ascii?Q?HZqkH1JfxVGdKLNlwXFwlfBGzVvG83MK/uDcepF7sA5CzfXSS05653ffsNIy?=
 =?us-ascii?Q?LY5hRScurxD4nyjImc7RvZ0YpcSxQ8s/DboSdXMgN3GLO/hjms6AZLMVIXYh?=
 =?us-ascii?Q?uVGMI4scIMDlLLNKA/hn6JJJw8pY1INDvpxCkZY3LpOH5l1RNT4sPo/th7wF?=
 =?us-ascii?Q?jwA5JvcH1MrIKQ/5g/SsaQf/YXPql20ohcV+1OXUY2VO4mSM+JP+pvclWf85?=
 =?us-ascii?Q?jFzUxxkXogGSt1Uc/P8OW37hX4J5zgj3L2fsiqvrt0KqfBEGQtNk81hCnvxI?=
 =?us-ascii?Q?4Uctw+vtqedgDuv4d2Ua9JLI4frLvPVMcyouMNxiByw/MgGIgfMQcxtPBmC1?=
 =?us-ascii?Q?/LLXDYdocYh7NUIkupHWSvT7ACmcmr3mo07kqH3rUzMobP7dBSZj9WMh+/gA?=
 =?us-ascii?Q?+mWHu0TF1yMQi+g4WGtUQnPvpl8pCJBQiv/K0vLMw03E4AGUSoJ0wVThu+lf?=
 =?us-ascii?Q?rA+u/DyNWdeGVCknODRO6yHt2dztD1qZ1H59Fq/Kpv9i5jr/XMLSSBp1c55c?=
 =?us-ascii?Q?FL7js25ylaVYUXL1gC8t1FbfPasRSXEv+ysa6IJNNqVOOgqoiMsVXqqbEc0Z?=
 =?us-ascii?Q?vSGkeDYWdUhmEVd/AfOXSPkrarHV9rWINzZmOjKorJ7Adg3WSeQEGISqTobx?=
 =?us-ascii?Q?q21y33x3x5n3NiM0pKzpVmVgMT9azDzfgoU4Qrkv?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8738efca-cc10-4878-6f63-08dbeb6a8d88
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 14:51:47.8098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dPbNH4co4CDqJojZtrmuOeuprJQNv9KR6Mir3f/VCfmVJ6t/IqhH9UchhPNhnGnc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6174
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 06:52:23 -0800 (PST)

On Wed, Nov 15, 2023 at 08:28:56PM -0500, Peter Xu wrote:
> This patchset is in RFC stage. It's mostly because it is only yet tested on
> x86_64 in a VM.  Not even compile tested on PPC or any other archs, it
> means at least the hugepd patch (patch 11) is mostly untested, or even not
> compile tested.  Before doing that, I'd like to collect any information
> from high level.
> 
> If anyone would like to provide any testing either over hugepd or CONT_PMD
> / CONT_PTE on ARM (before I reach there..), or RISCV over 64K Svnapot,
> that'll be very much appreciated.  I'm copying PPC, ARM, RISCV list for
> that.  It can be as simple as "./run_vmtests.sh -t gup_test -a" for now,
> making sure hugetlb pages can be allocated along the way; the non-hugetlb
> gup tests will guaranteed to be covered more or less, I suppose.
> 
> In summary, this is a continuous work for previous series:
> 
> https://lore.kernel.org/all/20230628215310.73782-1-peterx@redhat.com
> 
> And this more or less is my current take to move one more small step
> towards merging hugetlb code into generic mm code, as much as we can.
> 
> That part-1 series dropped follow_hugetlb_page().  The plan of this one is
> to further drops hugetlb_follow_page_mask().  The hugetlb GUP will use the
> same code path for generic mm after whole set applied.
> 
> It means the generic code will need to at least understand hugepd, and
> that's already done like so in fast-gup.  Fortunately it seems that's the
> only major thing I need to teach GUP to share the common path for now
> besides normal huge PxD entries.  Non-gup can be more challenging, but
> that's a question for later.

This is great, I looked through quickly and didn't have any profound remarks

Thanks,
Jason