Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Shinas Rasheed <srasheed@marvell.com>
To:     Suman Ghosh <sumang@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Haseeb Gani <hgani@marvell.com>,
        Vimlesh Kumar <vimleshk@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [EXT] [PATCH net-next v1] octeon_ep: get max rx packet length
 from firmware
Thread-Topic: [EXT] [PATCH net-next v1] octeon_ep: get max rx packet length
 from firmware
Thread-Index: AQHaHK7Cr0Gyl9283UybM2bJsEDCGbCFw0MAgADA4PA=
Date:   Wed, 22 Nov 2023 16:15:37 +0000
Message-ID: <PH0PR18MB473487A5D3872C9DC05D97F0C7BAA@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20231121191224.2489474-1-srasheed@marvell.com>
 <SJ0PR18MB5216EA9C653D155E3F4A5D89DBBAA@SJ0PR18MB5216.namprd18.prod.outlook.com>
In-Reply-To: <SJ0PR18MB5216EA9C653D155E3F4A5D89DBBAA@SJ0PR18MB5216.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CVJ0C8emCNl3SMN92ujZxMzfH7MJ8Ck0WxcsKdLGBiDsT2KL1KTvSvX7GN6+?=
 =?us-ascii?Q?uUXkEnOYk9YmYXbiEMRKgw36jaD70KYYYvCzTkwbZuSlrhMfRGqazhV64EwF?=
 =?us-ascii?Q?eZYLRTeQGDkUgy4gxIH8imoylnnB7SbaWe6xM8PwHJGM78mUD5dUDRnY3AlE?=
 =?us-ascii?Q?Y0bYvczm2Ak4ZnG+r3dhDaRDI0bsdnE8GEsdXkiFME4GKU7av/hvBqzdmb5n?=
 =?us-ascii?Q?MgSnHfJtQCWrQ4bSSfVtMgN9/W/XPO988B1iO8C/n1zqXZnXpY7ZuR2nR5w+?=
 =?us-ascii?Q?7YimpwWkZyqUp6W6ISu18RKHmYm3SSLtS/xbrrGPKZw39ZEfk9nlZP1SzpEa?=
 =?us-ascii?Q?cluSrKq2gWw4EXZQOeL7RrE6m9TRLY53JtQoWtfLcQZYBaXuW/uHeUDBZNJt?=
 =?us-ascii?Q?b0PAGVFKPCjUGzBEcQ9yFzX3HhBqGSO4/DgX5QJeMFL2nRpZR6/FJ6LjOaK6?=
 =?us-ascii?Q?pONJX0JaVxGRIKsOFx0ZwIqctuWah0IjUbHhPLF4fQkBH5DumGMnq80yHPJL?=
 =?us-ascii?Q?P2SypV81m6mnEq+xKhOopVhedlsKzsKjxE0HLKRSgl+5np3RPfT7WuQLaAOp?=
 =?us-ascii?Q?6CaRgYQA6KtClzywxTGDi/oqDR9WnJTUpw+eqKP9EhFdDvw97cCyz7ySIws2?=
 =?us-ascii?Q?XEeIw/ovXBNVhhUnVBRLFSaTIpCD/zwfkFruKysTaq5+KX4btgDYrr6lZ9wS?=
 =?us-ascii?Q?J06fByHoCqH/U+OuynY8oopK2ZJ0T/5LPXOC7E9zho92kyEzxv+BZ63tmdeF?=
 =?us-ascii?Q?p5UIIOLCcEjZPAHAD8dIMfjd43BmfcpE9EiuN7wrAly5w0UtpGLBm8J+e6cp?=
 =?us-ascii?Q?tUsKUFi0zqa6pP+8FZYWIqZI92Pxcf5mpMLS64xsv0wouYc/TUjLqeQvUkXK?=
 =?us-ascii?Q?EWg01i8yPcMn1wxw+aWh3sy1w6cqjhBsKEEO4dHIRqN/7IDUhNlcaw3ZIU46?=
 =?us-ascii?Q?uWo0a0eeqWlxDTLhlj4KOVclL+chj2JO/lnqe05fV3SFhEkxXSy07YmzAo2W?=
 =?us-ascii?Q?VYX3ZgDK2Yt8W3e9ec9OqYQmVABVfsKVD00GJbr82mW8pjtMC9zIZMDTRUDy?=
 =?us-ascii?Q?VI0Jz2IiQshL0/vonAezimEnYZlbXH035FzBAuFvXGab/9bjeIo60+CEph6P?=
 =?us-ascii?Q?NIvEJBb1Kv3cTwATdwKRidyrCDx9wRxRWv3vfIEyl3+c5YEi+IvmnJd0Qoz2?=
 =?us-ascii?Q?vuMGXRlhFN0dvp4N0LB6DqmeUEa6/9DJ7p8d8ZCLrqnwRnDOuYQbrt5GOhgv?=
 =?us-ascii?Q?oJwxghqHeR+jCQEpPZ2KWvO1Hx1LJ+uSgbZ5KT2Y+tdYyatEQASWxy8KTNiu?=
 =?us-ascii?Q?Kyhe4O0u+Mm0FlaEKnKbcFf3zDmWvu78AwjS7I3UNQuinuZjldIrlo22iFm+?=
 =?us-ascii?Q?aYjEgUNRMLMG6YES5MR2NEQ9NA7DY+4EgmSpb9Slx/oqAuCGCpsJPH19pPrY?=
 =?us-ascii?Q?Vz+1fxIngiwkRbOkJ/7uH1aRZ03NEPs5Q0CqAyP/6gD7i0GU7uJzAvIqouZO?=
 =?us-ascii?Q?JEeTKuX127QYiwN7xiI+A5zItH0j2FFJm1dFtSKM72R6x7q+C1tRSh5ivmwm?=
 =?us-ascii?Q?k1Umx1EzFa/7TpQzjNe42F3D8V1TUy8Wj/zc23H+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41e742e5-f981-493a-e39d-08dbeb7643c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 16:15:37.8303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cvmaEwUIPn/IbJCSdEKmSTaZX2N87osF99sW0gYrPR18Z4evns6Zpcf0TzkgK6f15w+c8bkIOOOV2nl+Kmjv1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR18MB5326
X-Proofpoint-ORIG-GUID: ULe1doQqxNoKVg5IIMaJJPzEInEP05dO
X-Proofpoint-GUID: ULe1doQqxNoKVg5IIMaJJPzEInEP05dO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-22_12,2023-11-22_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 08:16:10 -0800 (PST)

Hi Suman

> -----Original Message-----
> From: Suman Ghosh <sumang@marvell.com>
> Sent: Wednesday, November 22, 2023 10:13 AM
> To: Shinas Rasheed <srasheed@marvell.com>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Cc: Haseeb Gani <hgani@marvell.com>; Vimlesh Kumar
> <vimleshk@marvell.com>; egallen@redhat.com; mschmidt@redhat.com;
> pabeni@redhat.com; horms@kernel.org; kuba@kernel.org;
> davem@davemloft.net; wizhao@redhat.com; konguyen@redhat.com;
> Shinas Rasheed <srasheed@marvell.com>; Veerasenareddy Burru
> <vburru@marvell.com>; Sathesh B Edara <sedara@marvell.com>; Eric
> Dumazet <edumazet@google.com>
> Subject: RE: [EXT] [PATCH net-next v1] octeon_ep: get max rx packet lengt=
h
> from firmware
> >@@ -1346,8 +1347,15 @@ static int octep_probe(struct pci_dev *pdev,
> >const struct pci_device_id *ent)
> >
> > 	netdev->hw_features =3D NETIF_F_SG;
> > 	netdev->features |=3D netdev->hw_features;
> >+
> >+	max_rx_pktlen =3D octep_ctrl_net_get_mtu(octep_dev,
> >OCTEP_CTRL_NET_INVALID_VFID);
> >+	if (max_rx_pktlen < 0) {
> >+		dev_err(&octep_dev->pdev->dev,
> >+			"Failed to get max receive packet size; err =3D %d\n",
> >max_rx_pktlen);
> >+		goto register_dev_err;
> >+	}
> [Suman] Do we need to check if max_rx_pktlen <=3D OCTEP_MAX_MTU as
> well? If not, then this macro is not required further after the change?

I suppose we should check this.