Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <8a713266-777f-099c-2eed-7ac13b7b72a6@oracle.com>
Date:   Wed, 22 Nov 2023 16:44:16 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH] bpf: add __printf() to for printf fmt strings
Content-Language: en-GB
To:     Ben Dooks <ben.dooks@codethink.co.uk>, bpf@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20231122133656.290475-1-ben.dooks@codethink.co.uk>
From:   Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <20231122133656.290475-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnZMTEcwR0FQSEdnWThZK0UxMzBvNFMxdS8vV3RLS1NwUzkwc1grWm5tM0o5?=
 =?utf-8?B?MUFXYVdEaG1DcGQ1SnJucVU1cmE5WUpEUkNGbjF2aCtBVGY0WU1pVUFLU2RH?=
 =?utf-8?B?N2JvV1MxWERUdXExNGRDbmtQclJkMTBPalo0SjVwSDhmL2pIaEY5Z2RYWFpQ?=
 =?utf-8?B?OGdFb1lUWnEwS2FGei9nWVQySnlFY3RCdFI1M1hBZFlpbjRvVnpMUzY5Vk5J?=
 =?utf-8?B?aTUrc3hWbGdQQXlNN0s3YU1YK3VFa2dtczZiUFBzc3haMCtCaElHNWRBNW8v?=
 =?utf-8?B?K3I1azlzMkpRR094cHZzKzVBaDNEWXh3K3g1MVNNeVpHNllweVNYeWlzUGQ1?=
 =?utf-8?B?L2NJblltaU9NbGprQTFURUh2SXVzVmU3TmcybTRaMzZsV0k1VnRWdFhYbTE0?=
 =?utf-8?B?bE1mMkVtTXZTc1NWS0VUemFSSndKQzRqaDdYZ25PWFhrUUc4YlRtOFBJczVy?=
 =?utf-8?B?YndZT0V3OHExSDVsWlh5eUhnYW1sZ20rZ0ovc0c4MStjLzBDUlBWbHJnM1Qr?=
 =?utf-8?B?TVVTYkorUm9ZS0ZBUHdaOGFrbGdqM0NkMmdsUitSaStBNmkyV1d1WFovRHFG?=
 =?utf-8?B?azVTcFNzTU1WYzJ6ZmFFMTE2MmIyQTBkeVZ0SGcxbXd6Y0xPN2JGTkZYUHlv?=
 =?utf-8?B?Y0tlS05XOTF5OGNCVlh0T1hyRVdOTE1OM2d5azRoUVQrcDdpaE9nTXhhdjR3?=
 =?utf-8?B?cDE0bG93L1BCZytUYUMyWEZHVU9BM0xzOXlHT0c1V0x5M1NvdExQMzV2MnhJ?=
 =?utf-8?B?dVVSeGNXNzloNU00azBBRWxmMEEwOVNhTUlHenFXVmgxcjdYYzRtVVh6VDFv?=
 =?utf-8?B?WFZ6b2I1N2dINHJmTDV5SWVxMkFyR0E0TStWVGMwaWcwc09aYUVjcFc4R0Vt?=
 =?utf-8?B?dXVUS09kQXhPdS9ueVZZS0pPY0ZQZFBVZGJXVWFzWVBWR1dMU1Z1dlZDdUwr?=
 =?utf-8?B?dWlQcEc0M0t0KzBhdkUybHc3cVo2QjZrQW5wUFc3TmNibWEySVBWZFArcm5i?=
 =?utf-8?B?RlB2a3dpSytWQ3lKUFZmZG9TVSttY291WkVBLy95Y3VjNDJ5bkxRYytwZ3Bm?=
 =?utf-8?B?RGRmSmhCSWYyOEJiNmdTYU9BUlVCQVovS1NObFRuaGh5MG5od0NvcUVNMGY5?=
 =?utf-8?B?Q2tzRDdHbTFmeUxHcVZvOFRzbmVTNHFyZWd2S1ZTbWIwZnYrSTV0eXpnaWpm?=
 =?utf-8?B?NGNxOFZRcTBraG5wT0p1UmI2cGJnRWVoMjdFdjQ5bHI4UXRHUHF4MXN0VXZ3?=
 =?utf-8?B?VHFkZng3NnYyT0xFdW5TRXVwK2NFT0tTM0pGQ01hYzlCaXEvYU9CS0JEaGw0?=
 =?utf-8?B?Zk0rYUtCSnpsSjNRWDNzNVNTYkhvZFQwK0haTXVTbGtiNThaT2pTcCtGeDlY?=
 =?utf-8?B?T1oyN3loVDlzTTF3L3JjaktKM1dNclZPVWx1QkNtN2tIZFZRMEFWK2pHczNv?=
 =?utf-8?B?THNMRHl0WnZsTnU3UWp3ZU5KQThSUnQwY2QrY2NheTR3TlJxWm1tckhDL2hs?=
 =?utf-8?B?Y0haS1JCc1BDUXZhOFdkS1hIRDk1NDFSS0duL1lEVEtKOERKNVhoUElYMEYy?=
 =?utf-8?B?Kys0Wk56WE5kMmFPTU9IeDYzVGhFSzEwWWtGSUVPZTQ1SktldkVxVUt3VDh6?=
 =?utf-8?B?eHJ6QnlvblVteWhyK0NjRzNCREh5M1Qvd0dJemNhK2ZoWkx3d3llWGFKM29L?=
 =?utf-8?B?aXh6MklJSmhVVks3NThkS2JvV3UzbDZZL0FCdXdSNFAvRUdNTUFXSzl4WGZ4?=
 =?utf-8?B?RXZMY3VPTVJDbm9uMmhTWUVVTWNXakx1NG90amtKN1JBangxSEdSNkI1OG5U?=
 =?utf-8?B?Wm9md0xCVHNkYmdRbFRnRXMxUnNTb1AzeHI3SWR5cTJXUkZkU3BOUThxOGpy?=
 =?utf-8?B?Qks3dGhTRDQrK3VXS25wNDhuRE1WcXhRYnM0SkkyL3dJT0Q4YWxGcGZEUlNr?=
 =?utf-8?B?Wkl1djhVOHYwQmIzZW1YcFdZYWlKbTFYTW5FZHc0dzVPNEVKaS9jbVl3UWgx?=
 =?utf-8?B?VVpvYVNVbW42ZVZUSDR5eWY4Nlo2MUVHdWhWQStQTm5YdVVOeUdZanhLRmcz?=
 =?utf-8?B?QXorUVNaL1Y3T3RmQSt0VTBJaWhzV0dmYzBNdWwyeGx6SSswVFBud0NDc1Uw?=
 =?utf-8?B?emhWbTFVSkhtWVVPT3QyRHNLb2pJQW4xK1JjNkdyWDdwZWlDcmRnTy91NWJO?=
 =?utf-8?Q?P56QTGus4g0i7X0t9KnVNBo=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0IFy2qocIUXI/ilWEUzxdArxAR/ovJ5/V4ir1Kr1OzB7VhPAX2QiGKV9lnDReg5fFop59pORPTVdOAsMPLfF4MazX4jBLnGREci/fcjNj2FOnEtQgwSEHPHvfUr7YgNmOUWOzrly5E9U24BlWnhsuBCFBZPh/4FyvsU+dG4S3DIFbiTsxRA9kDNb5xK9kVskFXfljNXjs1OeveF4Dz27CBTlqJQvwOWgzKO++OcuX1xVUErAvN/XF2fYGb4ubJ1iB6J1jmVIKjqkNjF3c+AuwZxK+l9qdnTrMN473foMylF0DMw4J41Y+W/S5qSDOF8MNuXYZHsc8W8/j8jWaj7EgisgIYpPURCIJ6/4/9LGzEPjJ83bmF/P12wG9jRYnPa1z2Y0P3j58Sv6jHeAbcYfuwY3K/ibI8B35XaLK8tTRqSG1+aLGxadiNMBUCiB8dsTa+VrwV4z/F9IyamTy0PoFy2ck4hTA22DEGI+5RIjg9OqUq/5i6bAPJAUfizXm+M/1vc2RYG9YSuLK+18bngBhDau/0CpcnyNwzBu699XeC1BeWV+RDciVqkRAJ4h5CZ2AWh3TYKqa9GDloNTFVNm+stOMLTsRGdIvXEgLaEf0DFxP6aR9YC8SXAMKwQeeVZLp4HJL6QTZa23+COI0mHfWQvsO/QMKos7mYIvgCRQQ7PMC+855at56vAFKRWv+QCvlVlgPennB0zf+vYThV5lBFG3jzbOftaNriCDj26kUd5Gm8XGDVGY5Nk0f6UGt4NHPjHJDl43JmFbRrGEhScin8hABPq2kEHce4//Zn/cMLypRKS+C4Yy0l04OT7sfDv/
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a711ddb-39c0-4332-2136-08dbeb7a4672
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5278.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 16:44:21.3986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nrLe6ehq2W4dzWKYtBnwkuwkmftA5AC7InN8gPSZKWBek2dPRTd3pMg/OhrNTrhtzClu/xKWOkgeDwGMzwfSjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB7072
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-22_12,2023-11-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311220121
X-Proofpoint-ORIG-GUID: lQSPnS8QrRaHEcEuFZ7d6qy4BV9tMLfj
X-Proofpoint-GUID: lQSPnS8QrRaHEcEuFZ7d6qy4BV9tMLfj
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 08:45:17 -0800 (PST)

On 22/11/2023 13:36, Ben Dooks wrote:
> The btf_seq_show() and btf_snprintf_show() take a printk format
> string so add a __printf() to these two functions. This fixes the
> following extended warnings:
> 
> kernel/bpf/btf.c:7094:29: error: function ‘btf_seq_show’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> kernel/bpf/btf.c:7131:9: error: function ‘btf_snprintf_show’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Looks good to me, thanks for fixing! Could also add a

Fixes: eb411377aed9 ("bpf: Add bpf_seq_printf_btf helper")

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>

> ---
>  kernel/bpf/btf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index 15d71d2986d3..46c2e87c383d 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -7088,8 +7088,8 @@ static void btf_type_show(const struct btf *btf, u32 type_id, void *obj,
>  	btf_type_ops(t)->show(btf, t, type_id, obj, 0, show);
>  }
>  
> -static void btf_seq_show(struct btf_show *show, const char *fmt,
> -			 va_list args)
> +static __printf(2,0) void btf_seq_show(struct btf_show *show, const char *fmt,
> +				       va_list args)
>  {
>  	seq_vprintf((struct seq_file *)show->target, fmt, args);
>  }
> @@ -7122,7 +7122,7 @@ struct btf_show_snprintf {
>  	int len;		/* length we would have written */
>  };
>  
> -static void btf_snprintf_show(struct btf_show *show, const char *fmt,
> +static __printf(2,0) void btf_snprintf_show(struct btf_show *show, const char *fmt,
>  			      va_list args)
>  {
>  	struct btf_show_snprintf *ssnprintf = (struct btf_show_snprintf *)show;