Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 22 Nov 2023 18:55:17 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     =?utf-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@tuxon.dev>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org,
        Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time
 stamping layer be selectable
Message-ID: <20231122165517.5cqqfor3zjqgyoow@skbuf>
References: <20231120190023.ymog4yb2hcydhmua@skbuf>
 <20231120115839.74ee5492@kernel.org>
 <20231120211759.j5uvijsrgt2jqtwx@skbuf>
 <20231120133737.70dde657@kernel.org>
 <20231120220549.cvsz2ni3wj7mcukh@skbuf>
 <20231121183114.727fb6d7@kmaincent-XPS-13-7390>
 <20231121094354.635ee8cd@kernel.org>
 <20231122144453.5eb0382f@kmaincent-XPS-13-7390>
 <20231122140850.li2mvf6tpo3f2fhh@skbuf>
 <20231122085000.79f2d14c@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231122085000.79f2d14c@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m2a9pjJXkd7w0PzD98IUjLNi91LCnddJfo3/oKfF0F4IhCeLgkR+r7zIXoNs?=
 =?us-ascii?Q?gWWe+6/PshIkMptkSebLYB+/uJmAjEo451bECyKpBD+EV210h4L7GawZISoB?=
 =?us-ascii?Q?kIgZoMMUO3ErIdX4gTr4yPaQIY3PQZyMLzwM38Rg8SuVTLH8Z5QoPH/MjgaU?=
 =?us-ascii?Q?Rr1WzFmUmaJNnWrS5gK7LDwOnACZ+w+l62vyrPgFIIARgqXVFmQvkdwbF1+Z?=
 =?us-ascii?Q?doVf7Vb+/pBC7Mp8OE2OEY+Vh2gGTVRXlzYWwT2m3CZU42f/nCKywn1sFinI?=
 =?us-ascii?Q?QZy0u1kZDKEgMLyROjUqL2aVMuMOsmyy4BOyobpc61YYEFWYgH6FsWWorysi?=
 =?us-ascii?Q?rH2VoMR8nR8g2nvqYsPV3his0DgYwloIJYEBnwGYrSa3Z6nMG7IA1bjLZOUO?=
 =?us-ascii?Q?Dm4U0h9aAIIWKOFJm9nxyyfHci74oY2XkNr+5Txl9BvkPncuba6NanoBqnjd?=
 =?us-ascii?Q?tX5fnGYm4FE9/UwSKmypghW7P2WkMz+x1fMnMQX0uVzhT0/v5u3rR3jPZJw1?=
 =?us-ascii?Q?fQ8hgqV3m9lrrpdvD4Q5HUNUpaWLUX3hvHBV/xXUYU3KSdW46dysI272WWyW?=
 =?us-ascii?Q?u80RkuDCG/ngAi1vaZbG4Cs5XYvhT5KPGrJBQd3KpXAAm7EnbDkgJY92u/xW?=
 =?us-ascii?Q?FpSVTc4QfvEW3yu5o3gB5osfjGHNaKnirLDmD3LAXx2MX1iWq88uaggU20eD?=
 =?us-ascii?Q?4j/yLXzJ2oiTEm3GQpp4D8qSVpAPkEnby7dPeqye7q7GLLXWpDgWkf752oH7?=
 =?us-ascii?Q?8Kgk/oJfZMYuM9FYzyVSKL1KKLqWApwLMyZ7MxzXoe+T2e9bZRbNoU1dtWhb?=
 =?us-ascii?Q?Pqz9NqaoCzULwwaVu7gcaqDIck9y9NJVGrk7b70CBnS8krIhaM/NWetcckSI?=
 =?us-ascii?Q?zbvp/cvLfyFhk/NrL7jCnUZ0L2vvEF2rUPA7u1/O/5AqpfS/E4YlMb7QKkiG?=
 =?us-ascii?Q?LrSm715ysZ6EjohKzzkXMt8yWpx1QAaQjh2AHVAqZXNbpZPrJPp00oBuIFcA?=
 =?us-ascii?Q?cpkUtCxTxX65AuOnIDc7dDz421sVQMlaXC06iUwU3JUWtnDZlRrLvze7aFAz?=
 =?us-ascii?Q?+s5ghFDRKAjZ1VHQ0AGZc2GH0tLvihGemEJguaRg8k5dduD7CEWs1JCQ/6bN?=
 =?us-ascii?Q?ZXto90244/fZLtfcLl3AqlF8copysWDruvgDqyrZgpEmpfalmbNoZ6AlH97m?=
 =?us-ascii?Q?nKSTXiYy99BHVXi26Uv2FylVn1YN7cVqQOb0DzSXMxp1DVJYZhWV/lJ+eyRI?=
 =?us-ascii?Q?3u8w+E7DN1Tv+6PjKZSEWm3YYWcW1m3kzAlqq6LByJlWgBYn/GsV48Z3LHuh?=
 =?us-ascii?Q?Py+7kuo3AomiNpsculy3bNqrfpZ6d9MvGUtHkxWll4+knKilZonUtcWxhzUJ?=
 =?us-ascii?Q?47ht2fZ+465SC4Qk+o5xPjX2aywU1FaGNXqNkqiJ0JNgfGykGqGlRf2UjZ2W?=
 =?us-ascii?Q?Yu+kKfed4RNyCfLsmDVmTiNTOdFbvoCdUBqfxW2PlZpYEJ6WtdwMMJ6s1t9V?=
 =?us-ascii?Q?xYIRdcYqiVTOAbOt0OOtzkBST6eCwEjwI8PkD4ZAlFepjSA2kuAHve8kUaUY?=
 =?us-ascii?Q?CoUcfNDmr62X5lH0uQiGSs42eZ44EBfL8/vk5r51c1fzw9vPi6SBZf6ThN6U?=
 =?us-ascii?Q?FA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 655750a6-22e2-4e4a-12be-08dbeb7bd0de
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB6459.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 16:55:22.2408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IP1vdJCu7pWdcvSuBO06iqVbMRd5UuE1/W7O/X3H+p2AMqpadhh3QbYp0tDlFldbk5/WCkuViEobpoOrbKsDog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9212
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 08:55:59 -0800 (PST)

On Wed, Nov 22, 2023 at 08:50:00AM -0800, Jakub Kicinski wrote:
> On Wed, 22 Nov 2023 16:08:50 +0200 Vladimir Oltean wrote:
> > My understanding of Jakub's email was that he wants to see the functionality
> > offered by SIOCGHWTSTAMP and SIOCSHWTSTAMP converted to netlink. I don't
> > think that ethtool is the correct netlink family for that, given that
> > these aren't ethtool ioctls to begin with. Maybe the new netdev netlink
> > family. The conversion in its basic form would offer exactly the same
> > functionality.
> 
> Well, ethtool has been the catch all for a lot of random things
> for the longest time. The question is whether we want to extend
> ETHTOOL_GET_TS_INFO or add a third API somewhere else. And if we
> do - do we also duplicate the functionality of ETHTOOL_GET_TS_INFO
> (i.e. getting capabilities)?
> 
> My vote is that keeping it in ethtool is less bad than 3rd API.

With SIOCSHWTSTAMP also implemented by CAN (and presumably also by
wireless in the future), I do wonder whether ethtool is the right place
for the netlink conversion.

I wouldn't suggest duplicating ETHTOOL_GET_TS_INFO towards the netdev
netlink family.

> > The concept of an "active phc_index" would not explicitly exist in the
> > UAPI. Thus I'm not sure what's with this TSINFO_SET being floated around.
> > The only thing would exist is a configurable rx_filter and tx_type per
> > hwtstamp provider (aka "{phc_index, qualifier}"). User space will have
> > to learn to select the hwtstamp provider it wants to configure through
> > netlink, and use for its class of traffic.
> 
> "Active provider" is the one that has TX_ON, rx != FILTER_NONE, right?

In the "implicit" definition of an "active hwtstamp provider", yes.