Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <978e008b-0787-4204-3d5f-16518f35a3c9@axentia.se>
Date:   Wed, 22 Nov 2023 18:13:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] eeprom: at24: use of_match_ptr()
Content-Language: sv-SE
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
References: <20231122155916.38037-1-brgl@bgdev.pl>
 <480fef02-09ed-9a32-d5bb-e7114381220c@axentia.se>
 <CAMRc=Mc_KAX0QWSoL9UEwwjFCD=fHv6ydceSYwaY91C=RkURxA@mail.gmail.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <CAMRc=Mc_KAX0QWSoL9UEwwjFCD=fHv6ydceSYwaY91C=RkURxA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHVOdlVmcldDeVpTSG9TejRXeW1RYzllemp4YUFYVkhZOG1MblBVYmd2Q2tt?=
 =?utf-8?B?V05NaTF1TkErRGFjVS94amp3cUJOSHNLaTRVZGNEeWNNRGlybkkxYzBJalFU?=
 =?utf-8?B?Z2NSTFFFNDQrYmRIN2VjSVB6UWMzNFh1VEx4QVhRMzZpQVVYMENkbVVTdndS?=
 =?utf-8?B?SUJHMnd5dU5QK2xQNGw4U2lpWDF5UzdEVzBiS09yeHRWMVI5NTV1UCtnbzhJ?=
 =?utf-8?B?a3lCdk0vNm5LVWhVcmo0T25BR0dIY2ZuTEN3VHlLalZDOGFYbzhyQmlRY3li?=
 =?utf-8?B?bFdMYzlSWCtyZFM2UTdMNUNkN2JNd2tFQUxCUDdaVGMvMVNBbHFjcUNpb2s4?=
 =?utf-8?B?QVdaWnhUMU9Bd21XdjBWa2lFcnJjeTFBbjZ2b1d1d2FyRHZpZkpEZ3pMbjRP?=
 =?utf-8?B?by9UNkJTT2loU01xRThkUGdCWmJOQnUxRXZtL2c5WHlaYTAxMkFscXg3a3Rt?=
 =?utf-8?B?akJDSCtXNXFxMWc1VlNGUmxDbUJ1VFpnYmhOVU91eDNmRmFBZ05oc0tJZ0Vv?=
 =?utf-8?B?M0cyVEN4ZUZrbzZqMlZaRXVTRXJnd0lKRElIMndjRzl0Sk1wallBOSt5OUNS?=
 =?utf-8?B?SEdiTDRIWldBcU1IN1phL0FKZDRuVXRRMTJrbEQyNlZrbnFoOFhpcHM0bG94?=
 =?utf-8?B?Z0NqUjBuZkNuTmRnbEdwYXU2dGp3SzgrNU1DTkY5Q1FORlN0S1BjNGJPY2FD?=
 =?utf-8?B?OWJjS3VBWituZWNmSTdscTNrbDhoWVhlT0kzamdtdU5XOHk3aXh3SCs0RW1G?=
 =?utf-8?B?NVpjMFdaWXZTK0t1SmdIc2V3ZG90OGZpN0lHVVpKVWpwTGoyUE5FQmgrVkJE?=
 =?utf-8?B?L0ovTmVNcXo5RXVCMFMwcDI4cFhwRXR0bGhBaW1wSTFRSmZhOUtGeWtWY0du?=
 =?utf-8?B?QkdYK21zOHBhcjlyZUVKOHNUalZxL2RBNVBPZUc3Mm9kUnR2eENrY0h4eUNB?=
 =?utf-8?B?SjF3RGZZc0tMdlZLbUNhRjlxdHBFeFI5eUlqWTVTK2NkQ3JPbHlyQ3lTZGx6?=
 =?utf-8?B?ZVVHb3pWY3RVeEdVU05vM3Fmcm1RR3ZyYjQ0cVhVUmtKdys1cnQyL0tYMXc2?=
 =?utf-8?B?bnhCam5HQ0puNmN0VHdCMnVScmd0MWFBT0VNVlZQN1hHOW5hQkxKaWN2cDlm?=
 =?utf-8?B?UlVkeEZaaTFNSFVJeVZKNWlVTm5hSlAxUlBPQVlOczdUSk9FVC9zRW5ZRW5Z?=
 =?utf-8?B?a21zblp5SGhONEk1azhQZVdNM0pab0htVEM1Z051dWRuWUJlMnhSRjAzZWxU?=
 =?utf-8?B?QVlTRHg1RlVrSmFveXlpNHBHcnl0UlFUbGtzS2JCb2xYV0ZhMW5HaXFpZXg5?=
 =?utf-8?B?VGlhdm0vKzc5MlpHaXZNVFlxc2d3SHExazVsRFdubkhzdS9Gb255QmlyMWdy?=
 =?utf-8?B?OElLSDZsREtmLzNRV3FraGFpNHkrRmtQZ3gyMDg5aHhHbTZxb3pvYjZ1Z0xW?=
 =?utf-8?B?ajBDaVBPVE14TjdkTUJBYTkzTG1XZTZBZ0RROFNzTkxwNmlKK1BPbHJrbXJT?=
 =?utf-8?B?UTc4RUtLSVJNamJXQXlDRS9QdllNZDZuamtjMXlrK3lHaEhxQU10M2ZnSUNL?=
 =?utf-8?B?dzJnVkFsY0pkRDNUa1RDaCsyNUdZbG5TUThvSlhGZVg3eHg0dEZ1R3lPOE4x?=
 =?utf-8?B?eTJ3K3lCeG1xV0Jtd25objE0c0RET2s1Nkk1L3lLOUkya1AxbWlBSEJzTE1I?=
 =?utf-8?B?Q3FrVjBFMkFLMUZhTi9JSUVUL2hyTFM2c2N2WXFHQ0Q1RC9hcmk4OFVIbnlS?=
 =?utf-8?B?M3A5RVA5YU4ydmZGLzNFcG5iZDBKQm5Zakc0WkdKVUVYc2FmZ2liR2ZjeHdS?=
 =?utf-8?B?ODdVeThMZmxEbjI0L2hBeEdTNkVlc0ViSTZ5cllWRmNRRUdMVzNHY29WbHU4?=
 =?utf-8?B?MFRUbWF4eERSWFpTQ1FMQlFCeDRSV01VN1AvNVZMVG9XYThjYU1VMEwvWDdT?=
 =?utf-8?B?cDFmZm1tcFJpM2treFZXaHpvK2hnY3o3L3R6TG9Gbk5WUzh1MEtJS1RjZ1hS?=
 =?utf-8?B?YjhRdEVZazBkbkxBYm9mTkhSR0lYWEZpSStLYUJLUjl1VmJjVjhreEJzN1FO?=
 =?utf-8?B?dVhXTzdoZXZ3MHhZOW5iNE1ZVXMwSXN5TnN6cTFwd285V0g5eUNlR05DTnZn?=
 =?utf-8?Q?aXIdewKdWxxHCyf463k8qNOX9?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b1885d8-5f9d-40f7-fdad-08dbeb7e6af1
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 17:13:59.8111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s3OzEN+zLnjaMgtC59yscLb4Se2AYsb0AYh2ms0qgKICD9L/H2xkW0jC/sO4Iu9C
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR02MB9173
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 09:14:18 -0800 (PST)


2023-11-22 at 17:57, Bartosz Golaszewski wrote:
> On Wed, 22 Nov 2023 at 17:41, Peter Rosin <peda@axentia.se> wrote:
>>
>> Hi!
>>
>> 2023-11-22 at 16:59, Bartosz Golaszewski wrote:
>>> -             .of_match_table = at24_of_match,
>>> +             .of_match_table = of_match_ptr(at24_of_match),
>>
>> If you do that, you will need to also add #ifdef CONFIG_OF around the
>> at24_of_match definition, of you'll trigger a warning about an unused
>> const variable (for some configs). I think.
>>
>> Cheers,
>> Peter
> 
> Nope, no warnings even with W=2. This is true for unused functions but
> unused data structures are just silently removed.

Then I wonder what the difference is from the following?

https://lore.kernel.org/all/202311161306.opyfcoCY-lkp@intel.com/T/#m3a33dc4c3221ae167563bcff70757af776cf07b1

It sure looks like the exact same pattern to me.
I.e. a static const struct of_device_id paired with of_match_ptr(). 

CHeers,
Peter