Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231122022805.511839-1-irogers@google.com> <ZV40tp7uiaTk-Qp1@linux.dev>
In-Reply-To: <ZV40tp7uiaTk-Qp1@linux.dev>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 22 Nov 2023 09:24:30 -0800
Message-ID: <CAM9d7ci8J_3+Hv+tHPBLx3SOXiPsGyxpYNHxZU==qR544f9hVw@mail.gmail.com>
Subject: Re: [PATCH v1] perf MANIFEST: Add gen-sysreg for ARM SPE
To:     Oliver Upton <oliver.upton@linux.dev>
Cc:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Marc Zyngier <maz@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Oliver,

On Wed, Nov 22, 2023 at 9:05 AM Oliver Upton <oliver.upton@linux.dev> wrote:
>
> Hi Ian,
>
> On Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers wrote:
> > The necessary files for generating sysreg-defs.h need adding to the
> > perf tool MANIFEST that lists the files for packaging the perf tool
> > source code. Fix for the following:
> >
> > ```
> > $ make perf-tar-src-pkg
> > $ tar xvf perf-6.7.0-rc2.tar
> > $ cd perf-6.7.0-rc2
> > $ make -C tools/perf
> > ...
> >   PERF_VERSION = 6.7.rc2.gc2d5304e6c64
> > make[3]: *** No rule to make target 'perf-6.7.0-rc2/arch/arm64/tools/gen-sysreg.awk', needed by 'perf-6.7.0-rc2/tools/arch/arm64/include/generated/asm/sysreg-defs.h'.  Stop.
> > make[2]: *** [Makefile.perf:456: arm64-sysreg-defs] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> > make[1]: *** [Makefile.perf:242: sub-make] Error 2
> > make: *** [Makefile:70: all] Error 2
> > make: Leaving directory 'perf-6.7.0-rc2/tools/perf'
> > ...
> > ```
> >
> > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path")
> > ---
> > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> I had sent out fixes for both of your comments [*], no preference as to
> which gets applied. So, FWIW:
>
> Reviewed-by: Oliver Upton <oliver.upton@linux.dev>

Thanks, I think I can pick up your patches as they came before.
Namhyung

>
> [*] https://lore.kernel.org/linux-perf-users/20231121192956.919380-1-oliver.upton@linux.dev/