Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <b10de3fb-b6b9-4d8f-a940-93723adbd321@acm.org>
Date:   Wed, 22 Nov 2023 09:43:19 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/3] scsi: ufs: core: Add ufshcd_is_ufs_dev_busy()
Content-Language: en-US
To:     Bean Huo <beanhuo@iokpp.de>, avri.altman@wdc.com,
        alim.akhtar@samsung.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, mani@kernel.org, quic_cang@quicinc.com,
        quic_asutoshd@quicinc.com, beanhuo@micron.com, thomas@t-8ch.de
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        mikebi@micron.com, lporzio@micron.com
References: <20231122172512.103748-1-beanhuo@iokpp.de>
 <20231122172512.103748-2-beanhuo@iokpp.de>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20231122172512.103748-2-beanhuo@iokpp.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/22/23 09:25, Bean Huo wrote:
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -126,7 +126,6 @@ enum uic_link_state {
>   	((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE)
>   #define ufshcd_is_ufs_dev_deepsleep(h) \
>   	((h)->curr_dev_pwr_mode == UFS_DEEPSLEEP_PWR_MODE)
> -
>   /*
>    * UFS Power management levels.
>    * Each level is in increasing order of power savings, except DeepSleep
> @@ -1408,6 +1407,13 @@ static inline int ufshcd_vops_phy_initialization(struct ufs_hba *hba)
>   	return 0;
>   }
>   
> +static inline bool ufshcd_is_ufs_dev_busy(struct ufs_hba *hba)
> +{
> +	return (hba->clk_gating.active_reqs || hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL ||
> +		hba->outstanding_reqs || hba->outstanding_tasks || hba->active_uic_cmd ||
> +		hba->uic_async_done);
> +}

Since the above function is only used in drivers/ufs/core/ufshcd.c,
please move it back to that source file. The public header file
include/ufs/ufshcd.h is for definitions and declarations used by both
the UFS driver core and the UFS driver host files.

Thanks,

Bart.