Received: by 2002:a05:7412:e79e:b0:f3:1519:9f41 with SMTP id o30csp78324rdd; Wed, 22 Nov 2023 09:50:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZ0pr1gkqiyHZt7hgiLwpNty5RFUZERhyEIyQw4WlW/CG5PeXgdOQZmXMRqmkWXG/qacwV X-Received: by 2002:a17:90b:1e09:b0:280:cc16:f756 with SMTP id pg9-20020a17090b1e0900b00280cc16f756mr3251453pjb.20.1700675409215; Wed, 22 Nov 2023 09:50:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700675409; cv=none; d=google.com; s=arc-20160816; b=XVo5aD3PPIbWs/6d0k5zAQH+RG83chVh+V/hnXepKOZDIpqzVYvC6sMvP8zTlDNlAu 9xf1VYUDm5XI+yqq5Dd+Sv0dMaxU8XYg8lK1C9WwjQMW4tEUsJoC1Vs+SDdQIqI37f+F 6OUay0MRzMpDdoG/LOB9oWlKQVxw+g4WAtv1qrBAvFHs1M7a4khXgn5wwYQFFA9dBqQy /xRt9P7Zw70tIxr+GFAsnEYKeuMobz5vspcbxwMxpBPmDnLLLLy787RXbxSl0+fLR179 gYMhjjXfFCwmutxmzkcCtSD0yS1jXyQ5O9Cbsc2w+t6o2TUgRgUuFi/EfOquq/dR8Ht7 1TJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NWYiihJzvnP/f0mKLagYq+EKWtW2rMV4omwMd1/Y5dA=; fh=rbWtxkE8kExZFv2KcrtSC0yF0uarX5O6bFbQPIKO3cE=; b=IKbRKCBgZ8q4lHXCoqMwsTID4eAqszUlLbGaJip1k6RVd0bMNT6daNoDBUOR15raBY jGJN6on41VM7CgywuYmThSr2AFcQzdnFLXyBjzOY+UC4i0JmnsRd2upJnPz7oi5a3auW 7qN4x4PCCU6/kHSpCXFYCaD5x1PZIckIf+npB9hg6VXqDZd7Jn0avGH4Q0z2vFH3ypqy ayk8Upz1lR7dDxa0pZbmElJ1m7VFxp2qFD5D6HKWx8kc1e1vV8VgI41IlItWtLYjZjgW oDsLVh3zQL50c/PbKi/Vpg/H46Uw4IMX/AWJUs71S9MRk/GPl5v5KZWE3AA42Hqw9vpY Kn2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=TZ1c+8Q4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j19-20020a17090aeb1300b0027d113631f0si53097pjz.24.2023.11.22.09.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 09:50:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=TZ1c+8Q4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3356A822CA8C; Wed, 22 Nov 2023 09:50:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231391AbjKVRuG (ORCPT + 99 others); Wed, 22 Nov 2023 12:50:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjKVRuF (ORCPT ); Wed, 22 Nov 2023 12:50:05 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01ADB1A8; Wed, 22 Nov 2023 09:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=NWYiihJzvnP/f0mKLagYq+EKWtW2rMV4omwMd1/Y5dA=; b=TZ1c+8Q4ooWiZfrvvZq628ZJdT nEIvYAmc3SJFqgNDto/YW0FHn+Wq8f7dtJg4pKXWFepLXEdv/jor5Z93kLksgTkRsnkYstsyIrB/E ALIho6XMHIxbO3wUk2Dtl7Y1IxqrI1YEC2h51f/rDNn4K3WpyhoDHfo52Z17NlZ2ogEU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r5rME-000to2-0y; Wed, 22 Nov 2023 18:49:50 +0100 Date: Wed, 22 Nov 2023 18:49:50 +0100 From: Andrew Lunn To: =?iso-8859-1?Q?K=F6ry?= Maincent Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver Message-ID: References: <20231116-feature_poe-v1-0-be48044bf249@bootlin.com> <20231116-feature_poe-v1-9-be48044bf249@bootlin.com> <2ff8bea5-5972-4d1a-a692-34ad27b05446@lunn.ch> <20231122171112.59370d21@kmaincent-XPS-13-7390> <04f59e77-134b-45b2-8759-84b8e22c30d5@lunn.ch> <20231122181647.06d9c3c9@kmaincent-XPS-13-7390> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122181647.06d9c3c9@kmaincent-XPS-13-7390> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 22 Nov 2023 09:50:07 -0800 (PST) > I would say it never supposed to happen. > I never faced the issue playing with the controller. The first communication is > a simple i2c_master_recv of the controller status without entering the > pd692x0_sendrecv_msg function, therefore it won't be an issue. Great. Do a pr_info() or similar and keep holding the lock. KISS. Andrew