Received: by 2002:a05:7412:e79e:b0:f3:1519:9f41 with SMTP id o30csp108373rdd; Wed, 22 Nov 2023 10:35:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFViwJ+GVyz2ZdzxPfb+DDWmyw+NN70pfcRyJP1PjGw4exaFYQbPx+O+jwAnyZXgbINZmlr X-Received: by 2002:a05:6a20:7d89:b0:189:2e8f:d357 with SMTP id v9-20020a056a207d8900b001892e8fd357mr3912414pzj.49.1700678108571; Wed, 22 Nov 2023 10:35:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700678108; cv=none; d=google.com; s=arc-20160816; b=KZF2ZCL/Ik6E4QyRivitPb2JTbflNiADV94ueHeLalNTsrFggZsfQLbHc7VQcnLxSp HNiuuwBlCEHhr6t6EJp/dK2Ti3l20dGAYc0KqyPJx9OpFzNFmP/s8B8z3fzRvxK37boy u/iVPJSq18wNjIcYm8hp613BfE723xwMYXksJWeapCmZ5G9HDgQGu0GKXDkfZUfqguAn ZKk+ksxHpv9+rT4WYfKGVQVbGqZ25ExTfAEbXS/cz+DtnyIr2vCDJGkczVSCukRnUZoV Eo82IdcSGDM4YQ/fDsrPjMqPUsE3BM5UjbDsWN376Oqod/48ycHdz4bnsKhvWgBQeue/ zmCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1qheon00yzflXLJ/tplxp469kfcH9ccNqybfBNSnqO4=; fh=HoDdXEWEUV3vz9NyLiVs7GPcCxmxwVsaiGWmLDkawq0=; b=K0pAlm13l3byyz2VtiBu55OAfspc8rvFSdf6poo257w6qMlBDT28NX8E3agG/QZpf8 8z6KzjsbpmPZAIJC8khwpV3nLu+hEQXQHQSrATEC2z7402ZiBjgxkJJsRlcxdeKfQeYt oB8bb1Vjvgh6ePC94jBPhyLcOPb675rzGnznMYXPDRTmjrkMrZ4Jhc4bCuaSppDFhrLS 36bxB14Q3zbi/gmtm73rPvyXHVuVRct5vFnCsRss//M7sVYtDIv1sEQHsNQbMZlJNFag NqRoYkvjQUBGlEVsLlYRPlRiKCOPmsANKOZa3omDiJveZZdsko30I4SwUZcpAkF6FZCA h5Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VpkuOZ0u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bm19-20020a656e93000000b005c22024966asi51811pgb.0.2023.11.22.10.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 10:35:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VpkuOZ0u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id CD501826AC5B; Wed, 22 Nov 2023 10:34:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344053AbjKVSeU (ORCPT + 99 others); Wed, 22 Nov 2023 13:34:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344163AbjKVSeS (ORCPT ); Wed, 22 Nov 2023 13:34:18 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E61D7D; Wed, 22 Nov 2023 10:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700678055; x=1732214055; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y1RQ+f1Q5efZzIZfRLadFxuw8IiQKXJxuGko9Zmlt9s=; b=VpkuOZ0ul6O19xFzfCE0Rn+dWZAUA7bjbjYbTWxBrT+7MnRZ0ZiM/TBG 5/ks7tfvOUEp4mQaqM3he1/7VOiF6SsOloTsQrgkL/mDjcO/4Y+bn6x5r 59YyRycVX6ghsSKgXkQQwRYbvQB/Ok/gHT9MhSNt1jRmmOx0EUAMB+02V VQL61i+7quuo1b5SjzqK83ljiXrTZUvtv6BMzkO7de7Cu4uxwdMGI88oM S9kEg78mrNT0Oj2KZoPeE835ZlXMV/qgBehL2PVXB+3eFupTddXr4Yxas HxqMG2MX7fU42jvS0HYC3QxQyQwHgo7yMPqJzS2IkTOVFKKxVNojuUcqL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="13672024" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="13672024" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa101.fm.intel.com with ESMTP; 22 Nov 2023 10:33:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="743344455" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="743344455" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 02:51:16 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r5kmC-0000000G49b-3FaF; Wed, 22 Nov 2023 12:48:12 +0200 Date: Wed, 22 Nov 2023 12:48:12 +0200 From: Andy Shevchenko To: Kunwu Chan Cc: gregkh@linuxfoundation.org, joel@jms.id.au, andrew@codeconstruct.com.au, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kunwu.chan@hotmail.com, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: aspeed: Check return value of kasprintf in ast_vhub_alloc_epn Message-ID: References: <20231122014212.304254-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122014212.304254-1-chentao@kylinos.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 10:34:44 -0800 (PST) On Wed, Nov 22, 2023 at 09:42:12AM +0800, Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Ensure the allocation was successful > by checking the pointer validity. OK. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko