Received: by 2002:a05:7412:e79e:b0:f3:1519:9f41 with SMTP id o30csp128371rdd; Wed, 22 Nov 2023 11:07:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJCzdhJpSBhlrYfVbgelMQfDsY8Eu4ESHpQx+FZVv3vaQII+k1R6Hp963zpfi5nm+ioAY9 X-Received: by 2002:a05:6a00:430b:b0:6cb:6992:4640 with SMTP id cb11-20020a056a00430b00b006cb69924640mr4012635pfb.26.1700680065290; Wed, 22 Nov 2023 11:07:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700680065; cv=none; d=google.com; s=arc-20160816; b=lZA1s0kyMaBAJzdxja5iOEion8q269GACiLNiwA9hBF/lNpXbCfcvZuAjg/0RY1zwJ ZunG379U8AjHLKR9tWWwt/pkOL4oEdnjSDHto9CGPFt1oznyxeheCtwX7UJmWbAOFD/s 1ugxTnWemUpqv3FeGMoaTIwgQGYvA+2noC5CvR9REKmpt2Xi6arc6OFR1Rc9T5iRo9Je r2vG6il+CqdvBYiVfM5smJmNox9WXnMmtjD2xDtJXWeU8QzBWwa+S/5PtHEEYHdK0xZ6 6Zfc1PsqzUArgXtX939qaWRdGd+DREc7vjrWsi8qQGaD3EUus+C1GaYyvAGjIx7JpZ7i 8Nvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4anuWbaZ5Qp1dbSfsbLu/thHlIWWQtDFiwXF+OhhmpI=; fh=5X0AOIq5YkeLlj9YboxZGaYvgOdHq3PaCY7SkB2olVI=; b=XWUwGk7PkMJYa7ahmZk9tuMugTVhK2qwQ2L1gp1E+PiWErshWmLUVt7+nwFANJImMo +ljC10VwGR1faPR+VApWAqo7sooTSTbWDPyjVz7G6xboXh2NbYNZvci3lFrJ0YlyF/RR InAVSVnDaaQV4sU8dCgo5L5AZfTSQ8lrABIPET4CYGvBggJAwP0Pb6+ip31HykYDzqob H/s2FQHKNNVQdepwU8qVC09CmrYS2qn31FDHm5jXVE5skT0Y69AjTXJOjGiSXt84szEi twykivW5TOyoiRoDRhkGhEnJGvoB0JOaKbLo2BEF+MBs1tYLgjueBYop1V2kU6+Grkac YQNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qzgTnDuK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id w18-20020a056a0014d200b006cb65cfde7fsi146349pfu.91.2023.11.22.11.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 11:07:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qzgTnDuK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 02B4A807089E; Wed, 22 Nov 2023 11:07:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbjKVTHh (ORCPT + 99 others); Wed, 22 Nov 2023 14:07:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbjKVTHg (ORCPT ); Wed, 22 Nov 2023 14:07:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38E6C1 for ; Wed, 22 Nov 2023 11:07:32 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 517C8C433C7; Wed, 22 Nov 2023 19:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700680052; bh=uVl7nTlOM0+msqDAdm3xWe+pC9hYDXS7ELazxBmwybM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qzgTnDuKDNNI2dRTWMKvM5zYKH+Hpi+NupYJ34h4+8zUd1hf6idxMdSswFWMqeKfU 48rcSLdxqrCZZIL9AP39WVkFTub17R8lcUv2l7mDetSSotS6IooqzdjIkMxuTN9FZ6 olz7dYNj7+jdqCIbOvOhmlo1r3Uhepy1nsPgrLnpdUHME2+WdM5mKP5tVu0oEeZ2t9 uhWw8IXHpVujmXqiytKyBY0V569vdYww4ToNiLHMz6T5Bi+Gnrg9hR8DDqpfUIrdhv 30/uvy/m/YYen77xPm0Ey3ZlsswsI+qLuGwurfs4LvvnBWOaUKgKsajKeECn5WNvMs 1xzHjSWZwIFRg== Date: Wed, 22 Nov 2023 19:07:25 +0000 From: Simon Horman To: Wen Gu Cc: wintera@linux.ibm.com, wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com, jaka@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com, raspl@linux.ibm.com, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/7] net/smc: compatible with 128-bits extend GID of virtual ISM device Message-ID: <20231122190725.GB6731@kernel.org> References: <1700402277-93750-1-git-send-email-guwen@linux.alibaba.com> <1700402277-93750-6-git-send-email-guwen@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1700402277-93750-6-git-send-email-guwen@linux.alibaba.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 11:07:43 -0800 (PST) On Sun, Nov 19, 2023 at 09:57:55PM +0800, Wen Gu wrote: > According to virtual ISM support feature defined by SMCv2.1, GIDs of > virtual ISM device are UUIDs defined by RFC4122, which are 128-bits > long. So some adaptation work is required. And note that the GIDs of > existing platform firmware ISM devices still remain 64-bits long. > > Signed-off-by: Wen Gu ... > diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c ... > @@ -1522,7 +1527,10 @@ void smc_smcd_terminate(struct smcd_dev *dev, u64 peer_gid, unsigned short vlan) > /* run common cleanup function and build free list */ > spin_lock_bh(&dev->lgr_lock); > list_for_each_entry_safe(lgr, l, &dev->lgr_list, list) { > - if ((!peer_gid || lgr->peer_gid == peer_gid) && > + if ((!peer_gid->gid || Hi Wen Gu, Previously this condition assumed that peer could be NULL, and that is still the case in the next condition, a few lines down. But with this patch peer is unconditionally dereferenced here. As flagged by Smatch. > + (lgr->peer_gid.gid == peer_gid->gid && > + !smc_ism_is_virtual(dev) ? 1 : > + lgr->peer_gid.gid_ext == peer_gid->gid_ext)) && > (vlan == VLAN_VID_MASK || lgr->vlan_id == vlan)) { > if (peer_gid) /* peer triggered termination */ > lgr->peer_shutdown = 1; ...