Date: Wed, 28 Nov 2007 17:09:50 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org,
       Alan Stern <stern@rowland.harvard.edu>,
       Jonathan Corbet <corbet@lwn.net>,
       Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [RFC] New kobject/kset/ktype documentation and example code
Message-ID: <20071128170950.29c8c7e7@gondolin.boeblingen.de.ibm.com>
In-Reply-To: <1196265787.3242.65.camel@lov.site>
References: <20071127230252.GB10038@kroah.com>
	<20071128100108.45fcbf15@gondolin.boeblingen.de.ibm.com>
	<1196253354.3242.40.camel@lov.site>
	<20071128165205.30ef426f@gondolin.boeblingen.de.ibm.com>
	<1196265787.3242.65.camel@lov.site>
Organization: IBM Deutschland Entwicklung GmbH Vorsitzender des
 Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?=
 Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?=
 Registergericht: Amtsgericht Stuttgart, HRB 243294
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1556
Lines: 34

On Wed, 28 Nov 2007 17:03:07 +0100,
Kay Sievers <kay.sievers@vrfy.org> wrote:

> On Wed, 2007-11-28 at 16:52 +0100, Cornelia Huck wrote:
> > On Wed, 28 Nov 2007 13:35:54 +0100,
> > Kay Sievers <kay.sievers@vrfy.org> wrote:
> > 
> > > On Wed, 2007-11-28 at 10:01 +0100, Cornelia Huck wrote:
> > > > On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH <greg@kroah.com> wrote:
> > > 
> > > > > Among other things, kobject_init() sets the kobject's reference count to
> > > > > one.  Calling kobject_init() is not sufficient, however. Kobject users
> > > > > must, at a minimum, set the name of the kobject; this is the name that will
> > > > > be used in sysfs entries. 
> > > > 
> > > > Unless they don't register their kobject. (But they should always set a
> > > > name anyway to avoid funny debug messages, so it is probably a good
> > > > idea to call this a "must").
> > > 
> > > Yeah, we should require it. And kobject_cleanup() needs to be called to
> > > free the allocated name, if the object is not already added and needs to
> > > be deleted (common in rewinding on error).
> > 
> > Always using kobject_put() should take care of that.
> 
> Ok, so we can always require a kobject_put() after a kobject_init(), to
> cleanup what happened after _init() and before _add()?

That's a sensible requirement, I think.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/