Received: by 2002:a05:7412:e79e:b0:f3:1519:9f41 with SMTP id o30csp178437rdd; Wed, 22 Nov 2023 12:36:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEg5M8a/OCxBHUMrX29yZpoMfcJhmxv1o/x7Ob5NTlSs1EZKd/RcMHiN1GyUclQG1akr0yg X-Received: by 2002:a17:903:509:b0:1cf:8a98:3ae with SMTP id jn9-20020a170903050900b001cf8a9803aemr24140plb.68.1700685394931; Wed, 22 Nov 2023 12:36:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700685394; cv=none; d=google.com; s=arc-20160816; b=P0KeWdUA3FJo9k6NxRr60A1NBewvbblWq4d5p8CHkx5F3bBhRymhbeN/up/KyQyXzt e1Kf2ICELKQhqELyGwpeOezEgEVdlej4cQRTgWp/228upbkEq04vrZPb8Q2sZ7EGgQrJ D9l9mzi4KWRBFt1daJ70MNo0WrKF/X3DoAixl2P6PzBzqUF1J2Bw+lAoNWYXcQIwsAat l1b+dBYuWSFVwy2VhflaiHO17ykPrKMRGjocmRz7/FSz9SXaU/YVQqyjNVkdltAkzSia TF0eYaXv/BXQp0B7/ncNpUcs7HCmg2UZ0YOKwgNds0O0eoj7a8EofrpwrzliQj4BQvIZ LFbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aT8OFhVl8TBs1abByDkd5WUKDE2+T4rWWdG/lRLax1U=; fh=Mh9xARBJ/4+hjrwirxBxx9hxE8w4byn5mMfYsDhsRP0=; b=Avl/Ks7IM7oFOtr1wwQaVTUbxWjO4yC7V4DwPeTGY3mgFxIz0qD5elx/I997Cx1WSG 3ik0UGBUNFCuupNNxp8CuD+CIbrNS45QxJqUoGZreAtfkNUuvZwM5bXaBMMRZhrmovTN wr0C4sa3ce8UXg+ARUDZ/iHYfYu3fmJU4wguI1wETWDbs2T9GjsFs9QLOtWaFvAqYZZi ZM2UwsPLlwcFy9qR1qtA5HVrmU7WnWypdWyKuNEzwoml9Z2uR8jtNx9X0LhcTqJ+iffI XNV6lQ4qu+vKy/C6APgQT6YTpHLgg7PgNJ+7VS9/8cRK32p+47urKM5EXhImIHXk9k+R Trmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AYmv0Zty; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id ik13-20020a170902ab0d00b001cc3397aa27si183679plb.62.2023.11.22.12.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 12:36:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AYmv0Zty; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 907DF829D9B5; Wed, 22 Nov 2023 12:36:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232010AbjKVUey (ORCPT + 99 others); Wed, 22 Nov 2023 15:34:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbjKVUey (ORCPT ); Wed, 22 Nov 2023 15:34:54 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51BC8199 for ; Wed, 22 Nov 2023 12:34:42 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c8879a1570so2633591fa.1 for ; Wed, 22 Nov 2023 12:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700685280; x=1701290080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aT8OFhVl8TBs1abByDkd5WUKDE2+T4rWWdG/lRLax1U=; b=AYmv0Zty5xBWCa777E4b/8i7r/vkmEci2HfAErqPmyv06Xycw+jKGTIJL/rghzHfp5 8XezGMJNh46Ezp+lZyBaP5r6COKF2qkjrT33HFdGhvai+rxKoWVKrakNi7sk3WmlDVpz xpmAbGSbn1KmL8aq9IzdFnRs6eKO/OWFdsUhULdbNT2WHSbAz91WSGzvYnUZfXy8xtmq VnQMCWiDG8YUpkgtYkBmyURQwPWN6xxRDXl9FJ6rHRF3sKH3dEBE1qdA4as6apcFZgn5 2j4AzLXJHiiHF2MP0rFRVxVX8OSi7EPoBMdg/Edp6FCGnc/wVEOXREVVCIYd13W39IhT faYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700685280; x=1701290080; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aT8OFhVl8TBs1abByDkd5WUKDE2+T4rWWdG/lRLax1U=; b=AkugdrAZFmT8NS4PQfqA3DczwsTdMI/0xSS2+wrTXtLAh16PQtcr/aZkCauJFaknTF 5GNSjW4gFPiYKXGtUnXh14n1FomhDD5ulKwBAzPc7f61F4REuhR5XRUx2/yurgVzw7Sc /QHCfvkqc2SKBGia+82YVDTIHa7udENxj7h1naZCmkgjTMAUlk8PuIedcp0vufDZa2FC 1KfYfKyHDwu/ckE6tIq6SZWIz/lbIo/DK0TuS90z9iTh2RJE2pb/iQP+54tMtoJ+PWDo WQ/gIa8vZ+uoR8ybBlyRb9EfvgoAdotZweXlNnrps10Dw/Sio6ajotRj3uPHXLHm+JWr ImTw== X-Gm-Message-State: AOJu0Yw3ld/aFxujOyNzuqifo8pH4l187eBploW+FI1SlXl6eezuFoyp Zeiy4t1AVaRlx46Jsxn2Weg= X-Received: by 2002:a2e:7214:0:b0:2c6:ef19:465c with SMTP id n20-20020a2e7214000000b002c6ef19465cmr2286494ljc.7.1700685280291; Wed, 22 Nov 2023 12:34:40 -0800 (PST) Received: from localhost.localdomain (cpc69390-oxfd28-2-0-cust941.4-3.cable.virginm.net. [82.17.191.174]) by smtp.gmail.com with ESMTPSA id m3-20020a05600c3b0300b00405959469afsm452556wms.3.2023.11.22.12.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 12:34:39 -0800 (PST) From: Emilio Perez To: minyard@acm.org Cc: Emilio Perez , openipmi-developer@lists.sourceforge.net (moderated list:IPMI SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ipmi: Use regspacings passed as a module parameter Date: Wed, 22 Nov 2023 20:34:28 +0000 Message-ID: <20231122203433.443098-1-emiliopeju@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 12:36:29 -0800 (PST) regspacings parameter is currently ignored and the platform data uses a default value of 0, this has been fixed by setting the appropriate field in the platform data. Fixes: 3cd83bac481d ("ipmi: Consolidate the adding of platform devices") Signed-off-by: Emilio Perez --- drivers/char/ipmi/ipmi_si_hardcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_si_hardcode.c b/drivers/char/ipmi/ipmi_si_hardcode.c index ed5e91b1e040..0c92fa3eee88 100644 --- a/drivers/char/ipmi/ipmi_si_hardcode.c +++ b/drivers/char/ipmi/ipmi_si_hardcode.c @@ -80,10 +80,10 @@ static void __init ipmi_hardcode_init_one(const char *si_type_str, } p.regsize = regsizes[i]; + p.regspacing = regspacings[i]; p.slave_addr = slave_addrs[i]; p.addr_source = SI_HARDCODED; p.regshift = regshifts[i]; - p.regsize = regsizes[i]; p.addr = addr; p.space = addr_space; -- 2.39.3