Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Sender: Corey Minyard <tcminyard@gmail.com>
Date:   Wed, 22 Nov 2023 14:49:01 -0600
From:   Corey Minyard <minyard@acm.org>
To:     Emilio Perez <emiliopeju@gmail.com>
Cc:     "moderated list:IPMI SUBSYSTEM" 
        <openipmi-developer@lists.sourceforge.net>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipmi: Use regspacings passed as a module parameter
Message-ID: <ZV5pPW9RsGsazy4i@mail.minyard.net>
Reply-To: minyard@acm.org
References: <20231122203433.443098-1-emiliopeju@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231122203433.443098-1-emiliopeju@gmail.com>
Precedence: bulk

On Wed, Nov 22, 2023 at 08:34:28PM +0000, Emilio Perez wrote:
> regspacings parameter is currently ignored and the platform data uses a
> default value of 0, this has been fixed by setting the appropriate field
> in the platform data.

Yep, queued for next release.  Thank you.

-corey

> 
> Fixes: 3cd83bac481d ("ipmi: Consolidate the adding of platform devices")
> Signed-off-by: Emilio Perez <emiliopeju@gmail.com>
> ---
>  drivers/char/ipmi/ipmi_si_hardcode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_si_hardcode.c b/drivers/char/ipmi/ipmi_si_hardcode.c
> index ed5e91b1e040..0c92fa3eee88 100644
> --- a/drivers/char/ipmi/ipmi_si_hardcode.c
> +++ b/drivers/char/ipmi/ipmi_si_hardcode.c
> @@ -80,10 +80,10 @@ static void __init ipmi_hardcode_init_one(const char *si_type_str,
>  	}
>  
>  	p.regsize = regsizes[i];
> +	p.regspacing = regspacings[i];
>  	p.slave_addr = slave_addrs[i];
>  	p.addr_source = SI_HARDCODED;
>  	p.regshift = regshifts[i];
> -	p.regsize = regsizes[i];
>  	p.addr = addr;
>  	p.space = addr_space;
>  
> -- 
> 2.39.3
>