Received: by 2002:a05:7412:e79e:b0:f3:1519:9f41 with SMTP id o30csp200047rdd; Wed, 22 Nov 2023 13:16:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzW6XXqJcNmOUpB0XdkxGEpuYJvmwU4EHlhhN1Cu4/IOUYAw13cZb04sj6Lvjqq6su1iMA X-Received: by 2002:a17:90b:380f:b0:27d:66a9:3462 with SMTP id mq15-20020a17090b380f00b0027d66a93462mr3604537pjb.3.1700687788078; Wed, 22 Nov 2023 13:16:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700687788; cv=none; d=google.com; s=arc-20160816; b=mFU+/r87ZbUA/HRiuxeK17My5JYBzML7XPlr27k62GnFK48YxJCu8FPVlxlBPQPAfB mAKxZcIQIrDvGLXdCZ9Pr1pPXwbqGHUDOa04iT0aYt653mz4M6M60MuPm92t7oqbztiV eTvGvDRmYiHv+RLn9apd08sEiVpUxsi4P35GVcv6flRoBtLNVAu4RjxhwXyHWgUoSxr3 b5nNM/019X1+kUDQYdqKoPovhhJCMbXp73h8WLoiVbzSgRDgi0tPpVb8lcrR0wGC+SZC ebF2EnSkoIbjsyBxinvaGBbmFEiNemNzR34cIeRtef6+u9Drtbep3JbYKcGsuKJuuARN K2/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iZUIj80ten5WbMUx5i6IlNdeACrCCijzXzvQj60owfU=; fh=/DW9tk17J1/HKn5o0Raq2YQbil5IR2pTxXXFFUnzcms=; b=GCqy9jmgR8ZwD/cIWuuiMNUc7VCS79IRVzi0d7RZuqAkHtLBMSzKwpmSfemYW+I2Sd 1dD0hJaWdGd+apMx0HTmiE66CqRCd3k2zmJwAtrGfRPCyCIbbPCFIX93AKEGzMo1QPTV h+cPuJBOcui30B+ggtJxEVIEAszKrSxT7t2LDLc5gHXKEKhXs0wHPv/pJjjMN3oOU6ck +amIh4+qKQhW0JtxmTlHnKKNQkCwsOte0Yu475PElDT97ilfayms9KMqF5uvlX5M1WQK UzKJBb5OX48yQMbn8nTOUmrRGHnEY6MucrHwhvZr5QkYGGKHd4LtG67iJLjBlhULWajd OqoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E959KgU9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id ie10-20020a17090b400a00b002769b4b64e7si417151pjb.20.2023.11.22.13.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 13:16:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E959KgU9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 4BECA8250DFE; Wed, 22 Nov 2023 13:15:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232747AbjKVVPO (ORCPT + 99 others); Wed, 22 Nov 2023 16:15:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231594AbjKVVPM (ORCPT ); Wed, 22 Nov 2023 16:15:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3BB0D42 for ; Wed, 22 Nov 2023 13:15:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 748A8C433C7; Wed, 22 Nov 2023 21:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700687708; bh=tX29cwq4HW2ZTQzwFFB4rNa+GB41wrnSmjmIQn6Gg9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E959KgU9SkJXN31p4CoiSoFMbt1/4mixRnb3ii4nBu8A1WjJfgKADIlw/4ob1B2OO C2YiEz9grSlGSdayOaPCOmxT2duYcfB+4pdNVCGKJW3PEmzFt9LF/OPpmBoLkZEIyZ DdSOuor0RqsN0PXu688gw3z8uc0RMaTG/hvbfr4h+jscQUVSNipFZ3C9MZlcpXlh1L utkd7IFab0TsuoYQRgymLQiq4fx4G5OuLAUah8wAUR7PpwxAv0CvvCDPngDFwfS8DL gKgUKN0gBkIcOfj2b+AuL6cYIdEKKmfUyQjOPIcdXSa8vT1rR8KS4H+4Z3zAzFGBxy 9PWmU8fF6JOpw== Date: Wed, 22 Nov 2023 21:14:59 +0000 From: Simon Horman To: Christian Marangi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Heiner Kallweit , Russell King , Florian Fainelli , Broadcom internal kernel review list , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , David Epping , Vladimir Oltean , "Russell King (Oracle)" , Harini Katakam , Robert Marko , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next RFC PATCH 04/14] net: phy: add initial support for PHY package in DT Message-ID: <20231122211459.GA46439@kernel.org> References: <20231120135041.15259-1-ansuelsmth@gmail.com> <20231120135041.15259-5-ansuelsmth@gmail.com> <20231122105243.GB28959@kernel.org> <655e452d.5d0a0220.61c31.01ae@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <655e452d.5d0a0220.61c31.01ae@mx.google.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 13:15:24 -0800 (PST) On Wed, Nov 22, 2023 at 07:15:06PM +0100, Christian Marangi wrote: ... > > Hi Christian, > > > > I was a little hasty in hitting send on my previous message. > > Please find some more minor feedback from my side below. > > > > Thanks a lot for the initial review and sorry for the various warning > you had to write about it. I know this was a new concept and that I had > to discuss a lot about the DT structure so I was a bit relaxed in > releasing OF node. Will handle all of them in v2. Again thanks! No problem. I'm never sure if this kind of feedback is appropriate for and RFC or not. And perhaps in this case it would have been better to wait for at least one more revision. So sorry for the noise at this stage of the patch-set's development. ...