Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Wed, 22 Nov 2023 13:32:17 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Dave Jiang <dave.jiang@intel.com>, <linus.walleij@linaro.org>,
        <rafael@kernel.org>
CC:     "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        <lenb@kernel.org>, <robert.moore@intel.com>,
        <Jonathan.Cameron@huawei.com>, <dan.j.williams@intel.com>,
        <guohanjun@huawei.com>, <arnd@arndb.de>,
        <linux-acpi@vger.kernel.org>, <acpica-devel@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <cfsworks@gmail.com>
Subject: RE: [PATCH v3] acpi: Fix ARM32 platforms compile issue introduced by
 fw_table changes
Message-ID: <655e7361d6ce_b2e8294b9@dwillia2-xfh.jf.intel.com.notmuch>
References: <170066723324.2477261.2506149141979712937.stgit@djiang5-mobl3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <170066723324.2477261.2506149141979712937.stgit@djiang5-mobl3>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?09Gd9wU+uqX0jlocPTw4fY7I3N8JWJT5Y2EMb2AONELibiOFrzA3W3+aWOnb?=
 =?us-ascii?Q?QziMJDak1k6jkOCG2l+HVeaGsAOwSfEPkAPRjYEz+glMRMiHZP19zFV0JGDV?=
 =?us-ascii?Q?gTLLnQkDZlKkcGwZSRhkseLJbUIfYIRDNsBN6CQC2PBOQ/asMfFmrWbwawm/?=
 =?us-ascii?Q?g0wo1GAlHR++ilR4e5S6fVD6EjeFk1Tszqbl8ieFrhK0A5yI4LOgUvu13LNi?=
 =?us-ascii?Q?nF6R8qlkUT8yXgTBrrfV2LXB8Vf/is6Iv/OkA96LtuQYvUaPk4Wb0a+zHXZs?=
 =?us-ascii?Q?LUbg+3ZRAdm9AiFLTMghmU0ODeDSBaiugwoBYskDMo53d5CYmEaTSZWU0zIK?=
 =?us-ascii?Q?VInRw019jbmPskUNQKrIa8lW/MORzLWhp7SuV1W+PRkmhsWHUoGI3LQEMelA?=
 =?us-ascii?Q?rePEXwM21HdSQaYbQP1DZoth0By7wdQtoTIV769x2P93EkQfwv1fNTCApz+v?=
 =?us-ascii?Q?tWueLaIXduEGECfRBGosnBca4QOrEVtGoHLZuUdPKaOMPsx21rSrQ0Ff19tT?=
 =?us-ascii?Q?hqOlUt2U+SOB64VpEtl0f/wvFOkeLu+smUVvP9HhoGvdFwzeW27s1OVH1Xaw?=
 =?us-ascii?Q?07d/ijLV7Y51rbDMbDd9akVwweS3shahGW2kVXOMJzXA/HDx3OwQhSuLnAWc?=
 =?us-ascii?Q?irNZw2FAQefelPgVqDhwqnkHQAcnHgoiquzcMW2ZpgZZiHnyixWEeOHVJgMg?=
 =?us-ascii?Q?8fo88l7fbMv5jhI7NKoeqleP+D4tsYs8ADKfV9dug0spdQMuxro0Y80oMcvB?=
 =?us-ascii?Q?12rR1pU4asyzUqLaOGgSbVRsaxyHobDx8kIMyD7nTWkLTF2pj9TfGEswUyBw?=
 =?us-ascii?Q?rWOlvqXziL66CsV60a7h8La0ZcX23Ur+QHAfVrqLCtDAyja9K2dMXieIRc38?=
 =?us-ascii?Q?erAwZj7Gb04tNStzLDXikXidpRe9O4BPGFl5z+Eaxiif28cP94WjspCQdMXP?=
 =?us-ascii?Q?B2iqn3ha1UuJt65vhuB8Fbel/C4D97Ck9rRbCeD1NlebGnpxGAv+IkhRxfkA?=
 =?us-ascii?Q?9b7qwjnNUCFo75+jYXVKvBPSJGVCgXdzY0lXXnFYvmxkGJq3QT0yde059KiA?=
 =?us-ascii?Q?CgUMYlceh0vTA/pjVSFNPmQMXg9NyVUlXKs9RL+otDY0GJklJDlsTqXXhSek?=
 =?us-ascii?Q?2r15JJnaO8ziHryHg8kqXSaN6RIO10NvATcqTUmxdYcPGKVp9xGRiP7y4tmM?=
 =?us-ascii?Q?D2BEgD0/STkYqmg9UK2xDRoVjqaRMd8uNuoUu0iCCT7BMUPurCmV5Wr8TCRI?=
 =?us-ascii?Q?8GnCYmmKd4aUrJOJb4gH2Bc5POKkxL8GMfNt42YMcMODJNYanKVC34QDBfje?=
 =?us-ascii?Q?T/9zAqW5RZaoPptQPMgFcunn6gi7jSLAd/qOUqp4ggsAWJ89/y684IOIzsBp?=
 =?us-ascii?Q?365xOnjeVCda3iQHs08OO3rywoq49xuGXsH6FCy1pcrzZFMwsRxezoAMjNhY?=
 =?us-ascii?Q?0AFBxv54WQ/ZsYoBeCNIZQ1p1AP21azsOuHAkPRsHBP9EzzROoDUYPpnCODW?=
 =?us-ascii?Q?FOJaiwI7XsaeLcUlJCtFG1s/TprnATkXuYCAaLMCsCw8TyzukelsVb3hGQZC?=
 =?us-ascii?Q?ef7jSCmgDuM7mhjDYFVOa7EAnfYnsz1Z5DyJbJwwXGJNyHxLtu5Kw1tynxX/?=
 =?us-ascii?Q?gw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b1133de-cf29-43df-c2fd-08dbeba28173
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 21:32:19.3904
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4XAb1t8nV9Jt8nA1R5NjkP1tDOlBaDtI9V97UGmtfy9rJaV7i4+t/VTZjEifM6sZNHzAbt//Q2v1xR79uAfiZuLwEN4nJgn5QkRFoDzqMNw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5677
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 13:32:37 -0800 (PST)

Dave Jiang wrote:
> Linus reported that:
> After commit a103f46633fd the kernel stopped compiling for
> several ARM32 platforms that I am building with a bare metal
> compiler. Bare metal compilers (arm-none-eabi-) don't
> define __linux__.
> 
> This is because the header <acpi/platform/acenv.h> is now
> in the include path for <linux/irq.h>:
> 
>   CC      arch/arm/kernel/irq.o
>   CC      kernel/sysctl.o
>   CC      crypto/api.o
> In file included from ../include/acpi/acpi.h:22,
>                  from ../include/linux/fw_table.h:29,
>                  from ../include/linux/acpi.h:18,
>                  from ../include/linux/irqchip.h:14,
>                  from ../arch/arm/kernel/irq.c:25:
> ../include/acpi/platform/acenv.h:218:2: error: #error Unknown target environment
>   218 | #error Unknown target environment
>       |  ^~~~~
> 
> The issue is caused by the introducing of splitting out the ACPI code to
> support the new generic fw_table code.
> 
> Rafael suggested [1] moving the fw_table.h include in linux/acpi.h to below
> the linux/mutex.h. Remove the two includes in fw_table.h. Replace
> linux/fw_table.h include in fw_table.c with linux/acpi.h.
> 
> Link: https://lore.kernel.org/linux-acpi/CAJZ5v0idWdJq3JSqQWLG5q+b+b=zkEdWR55rGYEoxh7R6N8kFQ@mail.gmail.com/
> Fixes: a103f46633fd ("acpi: Move common tables helper functions to common lib")
> Closes: https://lore.kernel.org/linux-acpi/20231114-arm-build-bug-v1-1-458745fe32a4@linaro.org/
> Reported-by: Linus Walleij <linus.walleij@linaro.org>
> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

Acked-by: Dan Williams <dan.j.williams@intel.com>

It concerns me that neither linux-next nor 0day robot exposure reported
this problem.

Does ARM32 require manual compilation coverage these days or was this
just a series of unfortunate events that the build bots missed this?