Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20231122143603.85297-1-sxwjean@me.com>
In-Reply-To: <20231122143603.85297-1-sxwjean@me.com>
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
Date:   Thu, 23 Nov 2023 09:33:12 +0900
Message-ID: <CAB=+i9S3zduJUbzoFxGQqMPKbA3N2bbUw4xkM3JA+rRK0Vr7UA@mail.gmail.com>
Subject: Re: [PATCH v2] Documentation: kernel-parameters: remove
 slab_max_order and noaliencache
To:     sxwjean@me.com
Cc:     vbabka@suse.cz, linux-mm@kvack.org, cl@linux.com,
        penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, roman.gushchin@linux.dev,
        corbet@lwn.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Xiongwei Song <xiongwei.song@windriver.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 22, 2023 at 11:36=E2=80=AFPM <sxwjean@me.com> wrote:
>
> From: Xiongwei Song <xiongwei.song@windriver.com>
>
> Since slab allocator has already been removed. There is no users about
> slab_max_order and noaliencache, so let's remove them.
>
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>
> ---
> v2: Hyeonggon Yoo <42.hyeyoo@gmail.com> suggested that noaliencache shoul=
d be
> removed too. Here adding this change. The patch is based on [1].
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/=
?h=3Dslab-remove-slab-v2r1
>
> v1: https://lore.kernel.org/linux-mm/20231120091214.150502-1-sxwjean@me.c=
om/T/#m55ebb45851bc86d650baf65dfe8296d33c5b1126
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat=
ion/admin-guide/kernel-parameters.txt
> index 65731b060e3f..d56a5beefe24 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3740,10 +3740,6 @@
>         no5lvl          [X86-64,RISCV] Disable 5-level paging mode. Force=
s
>                         kernel to use 4-level paging instead.
>
> -       noaliencache    [MM, NUMA, SLAB] Disables the allocation of alien
> -                       caches in the slab allocator.  Saves per-node mem=
ory,
> -                       but will impact performance.
> -
>         noalign         [KNL,ARM]
>
>         noaltinstr      [S390] Disables alternative instructions patching
> @@ -5887,12 +5883,6 @@
>                         own.
>                         For more information see Documentation/mm/slub.rs=
t.
>
> -       slab_max_order=3D [MM, SLAB]
> -                       Determines the maximum allowed order for slabs.
> -                       A high setting may cause OOMs due to memory
> -                       fragmentation.  Defaults to 1 for systems with
> -                       more than 32MB of RAM, 0 otherwise.
> -
>         slub_debug[=3Doptions[,slabs][;[options[,slabs]]...]      [MM, SL=
UB]
>                         Enabling slub_debug allows one to determine the
>                         culprit if slab objects become corrupted. Enablin=
g

Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>

Thanks!

--
Hyeonggon