Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 23 Nov 2023 09:54:36 +0800
From:   kernel test robot <oliver.sang@intel.com>
To:     Kuen-Han Tsai <khtsai@google.com>
CC:     <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
        <linux-usb@vger.kernel.org>, <mathias.nyman@intel.com>,
        <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
        Kuen-Han Tsai <khtsai@google.com>, <oliver.sang@intel.com>
Subject: Re: [PATCH] xhci: fix null pointer deref for xhci_urb_enqueue
Message-ID: <202311222304.1a72c7d4-oliver.sang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231117072131.2886406-1-khtsai@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ikqhmmgmYhX3lLrORc9ohAHIr+z/GzgMXCQAs6youKFzVLaimBMAhMo33NJP?=
 =?us-ascii?Q?hmKE1GIAeZOIyzjmNwXVdizkKsoCR/zunHy0qcqfEF4vSCVClJM/JEfOxP79?=
 =?us-ascii?Q?ijHCxhTa+vPX4xKGaTAFLiIHNUDZ5bH92KokzH7YUWSqPGubrEjQrRmbhwZb?=
 =?us-ascii?Q?Ro8pRFk6Ewzk0hSSXilL3BHmNqqMo3MC8ZpX+l+DVbDFgGg1jsB33g95ziG+?=
 =?us-ascii?Q?RWwNnYswMOagcl4lNzIMr8Vhrq4LjnTJ4cJfF2A6dYwvXS66UfH5p8GUmCSM?=
 =?us-ascii?Q?tqoA6ar9A/d2DC77CfVXLQwfWlsQimCbLD4C5gS1XpPvBDqE6RJBC3K9HEE1?=
 =?us-ascii?Q?lid/n9TUfT5Z58fBld2uMHLvza7pLR1K3001TmOCjvLSOqkp2/2p7QdEs+Rh?=
 =?us-ascii?Q?L5Y1uZnokNYeqGOuyeTvOit7wPBXnuKF1qQ7Tw3jpezWdtE4k/92VyH9mzFu?=
 =?us-ascii?Q?wy5AXscm8VS2gAo6Lyfw9aIlDuU8tkKHcIPtCsAUpSpl3h7VK9D5siQ/UKnj?=
 =?us-ascii?Q?2hkLJiCB9K9Wj4uCkjBZr1+awUa51mxtEgfzYWbtXp+7Lndz12VYHPU7lypO?=
 =?us-ascii?Q?U1b0NdGZY6G6rbWC4NaD6t/y/n5XKRavEJobXP1wudNzxPtLNqlRSEb26XhY?=
 =?us-ascii?Q?QC8o4UvTc2p1Dm3lY+fXqAG8cxcmdvotz1UApHFcpL59YD+MHBZkl8Dl1j9t?=
 =?us-ascii?Q?tLgHKYZwcctTMbGVrpd9wLPQMshk+dAUOB1acKX1mZgBuR3hLiO36Wsun34P?=
 =?us-ascii?Q?2Zxyzf0IojJMDSqJfwdq67ovWyVjhoW6TW54cgdmee+wkoaaarbdZE8QXp+I?=
 =?us-ascii?Q?qtD8YcD3Hss/eHbpxpTrk5Jp1enJFVgRfcvA6nnzjOQkFDTOupyDbNsoklhf?=
 =?us-ascii?Q?UGS07Hqscf7exviZpr94T2bsiROK7ThxftvpWzSehA/g8MyQ5axnPK3KTRyc?=
 =?us-ascii?Q?M+T3TXMTZqxs5nPGcFDwBR99rIdpY/32Bmle+j5LAaSJ94QdtDafypiFJw99?=
 =?us-ascii?Q?pl0yF9qC4/9ncdVuwYKtM4l6/snTozY8wed2nNcvRvBW2faYGt0xAc6cYIkB?=
 =?us-ascii?Q?TXGPZ5oCoNY2FZYTEi7cwcOMamE787iaX4Ga3kju77GXg3zfSPQS82eMYnL2?=
 =?us-ascii?Q?raLK7Z+MtBRWmw8xMPGaeTt5J9pM9QZbykFT8jnp/sbO6okxKwKUrL/8fbnT?=
 =?us-ascii?Q?XB9SvTUW5i/Cb0y7cIy+ZHJBUo4fPdFp5+ubPNJfNCUGaltvJ3sEKZsT1m1j?=
 =?us-ascii?Q?2Ws1vAfW+HLN/pKynYyyPrtRU+eLErCXiiojDwNDIkA/JyLJ9CvGEKTnFZIr?=
 =?us-ascii?Q?GpTzt/o/k0yGRU19OAzvS6zctuLx+yeKuH4SU/I/GqfPpNFJD5cWzr158uG4?=
 =?us-ascii?Q?34OtjkZA9It2y9DNRq9fqgzCc3xULmlQzmHdJm+6xgm7pSr+UlRHrAgvmHPX?=
 =?us-ascii?Q?ZCMnWjZc4j2befOZ8L22aBQCQfeldlswIncU6ItLfk8TvE1bZ4ARTpudAzGB?=
 =?us-ascii?Q?uYchfh/R1faxKLC0aZzW+AgACWYuM6dEZDQDf1n+cAVsPjh6BI9evaxRJFLU?=
 =?us-ascii?Q?MK0qJ0GTNwFyfQDQSwt5+y6YiFlt9FlKESb8x2m6bV//AZhKSaTmQEOaI4uy?=
 =?us-ascii?Q?VA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e55cef14-1250-44ef-6745-08dbebc72ab6
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 01:54:45.3894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SOTrEqpfxJ9gq7jilJjlVKbWrG0jaivCRM/XaHuy0Gk3cds00PwJW7egrZkLP4p0voW/6lgZ6DxywdvKb1t4Ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5079
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 17:55:16 -0800 (PST)


Hello,

kernel test robot noticed "WARNING:HARDIRQ-safe->HARDIRQ-unsafe_lock_order_detected" on:

commit: 90703e106b4214512828bff96df3df2ecff5c7b7 ("[PATCH] xhci: fix null pointer deref for xhci_urb_enqueue")
url: https://github.com/intel-lab-lkp/linux/commits/Kuen-Han-Tsai/xhci-fix-null-pointer-deref-for-xhci_urb_enqueue/20231117-152346
base: https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/all/20231117072131.2886406-1-khtsai@google.com/
patch subject: [PATCH] xhci: fix null pointer deref for xhci_urb_enqueue

in testcase: kernel-selftests
version: kernel-selftests-x86_64-60acb023-1_20230329
with following parameters:

	group: net
	test: fcnal-test.sh
	atomic_test: ipv4_ping


compiler: gcc-12
test machine: 36 threads 1 sockets Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (Cascade Lake) with 32G memory

(please refer to attached dmesg/kmsg for entire log/backtrace)


If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <oliver.sang@intel.com>
| Closes: https://lore.kernel.org/oe-lkp/202311222304.1a72c7d4-oliver.sang@intel.com


[   18.016498][    T9] WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected
[   18.016498][    T9] 6.7.0-rc1-00001-g90703e106b42 #1 Not tainted
[   18.016498][    T9] -----------------------------------------------------
[   18.016498][    T9] kworker/0:1/9 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire:
[   18.019119][    T1] iTCO_vendor_support: vendor-support=0
[   18.016498][    T9] ffffffff84f96760 (
[   18.019656][    T1] intel_pstate: HWP enabled by BIOS
[   18.016498][    T9] mmu_notifier_invalidate_range_start
[   18.020037][    T1] intel_pstate: Intel P-state driver initializing
[ 18.016498][ T9] ){+.+.}-{0:0}, at: fs_reclaim_acquire (mm/page_alloc.c:3710 mm/page_alloc.c:3701) 
[   18.016498][    T9]
[   18.016498][    T9] and this task is already holding:
[ 18.016498][ T9] ffff8881e0b12428 (&xhci->lock){-.-.}-{2:2}, at: xhci_urb_enqueue (drivers/usb/host/xhci.c:1525) 
[   18.016498][    T9] which would create a new lock dependency:
[   18.016498][    T9]  (&xhci->lock){-.-.}-{2:2} -> (mmu_notifier_invalidate_range_start){+.+.}-{0:0}
[   18.016498][    T9]
[   18.016498][    T9] but this new dependency connects a HARDIRQ-irq-safe lock:
[   18.016498][    T9]  (&xhci->lock){-.-.}-{2:2}
[   18.016498][    T9]
[   18.016498][    T9] ... which became HARDIRQ-irq-safe at:
[ 18.016498][ T9] __lock_acquire (kernel/locking/lockdep.c:5090) 
[ 18.016498][ T9] lock_acquire (kernel/locking/lockdep.c:467 kernel/locking/lockdep.c:5755 kernel/locking/lockdep.c:5718) 
[ 18.016498][ T9] _raw_spin_lock (include/linux/spinlock_api_smp.h:134 kernel/locking/spinlock.c:154) 
[ 18.016498][ T9] xhci_irq (drivers/usb/host/xhci-ring.c:3032) 
[ 18.016498][ T9] __handle_irq_event_percpu (kernel/irq/handle.c:158) 


The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20231122/202311222304.1a72c7d4-oliver.sang@intel.com


-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki