Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 23 Nov 2023 11:05:01 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Edward Cree <ecree.xilinx@gmail.com>
CC:     kernel test robot <lkp@intel.com>, <llvm@lists.linux.dev>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Andy Moreton <andy.moreton@amd.com>,
        "Simon Horman" <simon.horman@corigine.com>
Subject: Re: drivers/net/ethernet/sfc/selftest.c:48:16: warning: field ip
 within 'struct efx_loopback_payload::(anonymous at
 drivers/net/ethernet/sfc/selftest.c:46:2)' is less aligned than 'struct
 iphdr' and is usually due to 'struct efx_loopback_payload::(anonymous a...
Message-ID: <ZV7BXZ/CtxzJzBuh@yujie-X299>
References: <202311220537.geMTr31W-lkp@intel.com>
 <3f42dee6-a6e2-1b35-674f-309aae042ae7@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3f42dee6-a6e2-1b35-674f-309aae042ae7@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n+nKLy06UM+vJCMZubdhEunl4XOsvp6WYvJZ6AoXhr727s3xx3P0vbnAenNX?=
 =?us-ascii?Q?nMhkSi5K5qWuTmDBbOYmEuljSQwB48iYVfdHygN1WTJSQ8HaxXEvfNW7RkAP?=
 =?us-ascii?Q?XRz26GUs9Mri58WSkoYfu13I58EasThiP4cSoDoRRtdEVgM+3CuiDsSmp0m3?=
 =?us-ascii?Q?5GRcfQblgfhrAmEdcN0PcR9ukPYaYWncZSQweV+pWuPQf8BuFyTnG1IJ4REK?=
 =?us-ascii?Q?+uQ2kXuXPvpE9BQDdOFum3Z+O44MtvIGURwky00LH+7HWS/igtPTOf+Qz4Q3?=
 =?us-ascii?Q?8cUTw2xA73dxePqg6nktTn6jSQE3VT9T2gnOMFommGJQmnMzPUqxT9seovlY?=
 =?us-ascii?Q?8gQ3WPwC3DEXNVGEtSpLKZVID27qIBQJB5Oaby+FRzoiLCWZr2x2vtiahC+a?=
 =?us-ascii?Q?hXQTwkyV5WKVD4Of6fYB85dXerPS4RtMQmOYCSgYRQFtwag2ZpfH/2Ufy2x9?=
 =?us-ascii?Q?wRanI+QWL9X/xK/O9nvemWFYsi+ypxeSL9KoCyuTUT/RfhycA6F77ih6dFpw?=
 =?us-ascii?Q?7NK5SUXENOyFQmbT3q7m9k0heLr7pg/DJRciINraPmu2V+OcQMKXBg4Epnsc?=
 =?us-ascii?Q?ecGReDN5O2jBpPs9AC9Y1adT23jlSSymF5aVZ5POZxiMfUpvVWQVFbh1DyhN?=
 =?us-ascii?Q?6dkbLla8wphsDJeE+eo2RSCmaQtiUt+AZPzmCwAjZBDb6FWKtU2YHM8gg17T?=
 =?us-ascii?Q?U3wT5y1NnaqMCPIM/js/8i+tVsJOSd+MJmLoyOGAM5lqPVdeeI87egY3EOwS?=
 =?us-ascii?Q?pW1LHgQCge33NAx+UOaUEHeCUvp5hI8jssJRR9j4jL0whH7Ek+pxHvA9y9ia?=
 =?us-ascii?Q?U+FWmGHd/aZLUSrKFbRGeqv0JYtKDHoRW0h8MKraUiHEAXnE0RNe5tNzSZrV?=
 =?us-ascii?Q?IK6haFW7Ced2XVMQImGsYALzB6HErU8FeNspbMx5q+dTZdNcEf1ULvF1kMvy?=
 =?us-ascii?Q?SieKlGasDSRv1YQdxpDSQaA5N1wPhk0535pdxUZkrceSGrzAyusDA3XDwUzx?=
 =?us-ascii?Q?T51gw6G7VK54nRNL4Ij5HonGIbmVdplvfA4E94IWpWf91dASa05CkhDcZHfl?=
 =?us-ascii?Q?E5zUJbGqBO6AjHjjfK9On9RyPxUNSUSfDgajxjx7YxCp1f8y5eBbtTDKkbDA?=
 =?us-ascii?Q?UJXjzlM9AVWPDD1wIDa6ElkfLGaMJi6x1Uig8LufDKrG6885MH8WYPQo0eDQ?=
 =?us-ascii?Q?ZVeRwP0TcPCJKf6A8AlDqxw6ddm1AjtKWOl8M75/a5vHJAfIYeyV5asyHoQl?=
 =?us-ascii?Q?V+ODQjRCqDJbmCDCgrRu8p2PxJcOUgAb9EZCH+oZc4+BVZukwZcOjrfdlZBB?=
 =?us-ascii?Q?KR/Bl4yAPyY65HY2/yDnDYZa65wHr2dl4sLq7tnmI3OJnfDH66fSNLoFBLk0?=
 =?us-ascii?Q?zJzf36TTaQTFfTP17aRS8fBC9YQ7oQd0xDix9KujOCOYLcHP+OjizOwmafh+?=
 =?us-ascii?Q?ZgeZAOB590GTHVwWPESZxTPNlopROyRe7OZII+9EPU0Die2L5re5tptCpSrD?=
 =?us-ascii?Q?pH5DtpLmpSqC1lzwYjWn8skyMil0Fl8MAykUVXQ6kGdjSBoVi+gmkfiaeXGB?=
 =?us-ascii?Q?r24SjoEaB+W6/pEOXju+ZyDhwXPSJYeF2lbogJaL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 19cbd5d8-3e08-4515-4c60-08dbebd1a232
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 03:09:40.5984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZaWG0EWgR8ISvRHyu4t9TsgB/4+6ofOCi0fYGOZrQvjELu3ljEFK4orGVB0+msC+sff6FH22DHhFgyw8HMHBrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6947
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 22 Nov 2023 19:10:12 -0800 (PST)

On Wed, Nov 22, 2023 at 04:15:49PM +0000, Edward Cree wrote:
> On 21/11/2023 21:25, kernel test robot wrote:
> > Hi Edward,
> > 
> > FYI, the error/warning still remains.
> 
> As I've argued previously, this is a false positive / compiler bug,
>  and there is no way to resolve it without making the code strictly
>  worse.
> 
> This:
> >>> drivers/net/ethernet/sfc/selftest.c:48:16: warning: field ip within 'struct efx_loopback_payload::(anonymous at drivers/net/ethernet/sfc/selftest.c:46:2)' is less aligned than 'struct iphdr' and is usually due to 'struct efx_loopback_payload::(anonymous at drivers/net/ethernet/sfc/selftest.c:46:2)' being packed, which can lead to unaligned accesses [-Wunaligned-access]
>  is complaining about alignment within an anonymous struct, which
>  only ever appears embedded within a larger struct in a way which
>  maintains the correct alignment.
> 
> #ifdef RANT
> 
> Indeed, the only way we even *could* create an unaligned access
>  out of this code would be via a declaration like
>     typeof(*(((struct efx_loopback_payload *)0)->packet)) bad;
>  because *the struct is anonymous*.  And if that happened, the
>  bad declaration would be the place to warn, both because it's
>  incredibly ugly and because it's the place that's actually
>  wrong.  The struct definition itself is entirely *fine*.
> The compiler should be able to detect that, and if it's not smart
>  enough to do so then it shouldn't be trying to warn in the first
>  place.  Quoth Linus[1]:
> 
>  "And if the compiler isn't good enough to do it, then the compiler
>   shouldn't be warning about something that it hasn't got a clue about."
> 
> The anonymous struct has to be there so that we can placate the
>  memcpy hardening, and it has to contain a struct iphdr at a
>  4n+2 offset because that's what shape the on-the-wire packet
>  *is*.  To avoid the warning we would need to lose __packed and
>  memcpy all of the members in and out of the buffer individually
>  to explicitly-calculated offsets, which is worse code.
> 
> #endif
> 
> Either fix the compiler to not warn, or fix your automation to
>  ignore this instance of the warning.

Hi Edward,

Thanks a lot for the detailed explanation. We've configured the robot
to ignore the "unaligned access" warning for this specific case.

Best Regards,
Yujie

> -ed
> 
> [1]: https://yarchive.net/comp/linux/gcc.html#13
>