Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <CAKpemQKo2gigO44amj=eFUXgUnUeSmiOoTbS8GdXMx3O07N1vg@mail.gmail.com>
In-Reply-To: <CAKpemQKo2gigO44amj=eFUXgUnUeSmiOoTbS8GdXMx3O07N1vg@mail.gmail.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Thu, 23 Nov 2023 14:25:01 +0800
Message-ID: <CAGXv+5E4TXrPmhb++r3vMGA4WoPc=covi7_=zgLLcOhGt9UBgg@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] regulator: mt6358: Add output voltage fine tuning
 to variable LDOs
To:     Bret Joseph <bretjoseph@gmail.com>
Cc:     angelogioacchino.delregno@collabora.com, broonie@kernel.org,
        matthias.bgg@gmail.com, linux-kernel@vger.kernel.org,
        zhiyong.tao@mediatek.com, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Bret,

On Thu, Nov 16, 2023 at 12:52=E2=80=AFAM Bret Joseph <bretjoseph@gmail.com>=
 wrote:
>
> In mt6358-regulator.c
>
> static const struct regulator_ops mt6358_volt_table_ops =3D {
>     .list_voltage =3D regulator_list_voltage_pickable_linear_range,
>     .map_voltage =3D regulator_map_voltage_pickable_linear_range,
>     .set_voltage_sel =3D regulator_set_voltage_sel_pickable_regmap,
>     .get_voltage_sel =3D mt6358_get_buck_voltage_sel /*regulator_get_volt=
age_sel_pickable_regmap*/,
>     .set_voltage_time_sel =3D regulator_set_voltage_time_sel,
>     .enable =3D regulator_enable_regmap,
>     .disable =3D regulator_disable_regmap,
>     .is_enabled =3D regulator_is_enabled_regmap,
>     .get_status =3D mt6358_get_status,
> };
>
> the function [regulator_get_voltage_sel_pickable_regmap] causes a -EINVAL=
=E2=80=AC when registering
>
> vsim1 vusb vcamd vefuse vmch vcama1 vemc vmc vldo28 vsim2
>
> using [mt6358_get_buck_voltage_sel] results in a successful probe

Sure it will probe, but any values you read back will be bogus.

Can you provide a dump of /sys/kernel/debug/regulator/regulator_summary
and `grep ^1e..: /sys/kernel/debug/regmap/1000d000.pwrap/registers`,
and also any relevant logs?

ChenYu