Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 23 Nov 2023 08:57:39 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Sanath S <sanaths2@amd.com>, Sanath S <Sanath.S@amd.com>,
        andreas.noever@gmail.com, michael.jamet@intel.com,
        YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [Patch v2] thunderbolt: Add quirk to reset downstream port
Message-ID: <20231123065739.GC1074920@black.fi.intel.com>
References: <20231122050639.19651-1-Sanath.S@amd.com>
 <20231122060316.GT1074920@black.fi.intel.com>
 <95ceae27-f88d-4915-870a-36cf9418f244@amd.com>
 <efb152bc-fd17-a374-4303-20aa9bde698d@amd.com>
 <20231123060516.GB1074920@black.fi.intel.com>
 <1687d5aa-3c79-4bbf-ae4f-891208edab9b@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1687d5aa-3c79-4bbf-ae4f-891208edab9b@amd.com>
Precedence: bulk

On Thu, Nov 23, 2023 at 12:23:36AM -0600, Mario Limonciello wrote:
> > It can be used to re-configure the link but also simple reset.
> > 
> > Actually can we instead of the quirk in quirks.c add this to nhi.c and
> > "host_reset". So that on these AMD controllers trigger host reset in the
> > same way Windows would?
> > 
> > That's DPR and probably host interface reset. In other words tie this to
> > the host reset we are doing for USB4 v2 routers (this one adds it for
> > USB4 v1 routers and enables it by default for AMD).
> 
> Assuming this "works" how would you feel about just "aligning the behavior"
> with Windows for all USB4 routers instead of just these AMD controllers and
> USB4v2?

I was thinking the same pretty much after I wrote the reply ;-) Yeah, I
think it is worth a try.

It may need some additional code from Intel side to get the host fully
reset but I can do that myself on top.