Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <45b0f9e2-f97a-1b60-b40f-d84831027d00@samsung.com>
Date:   Thu, 23 Nov 2023 16:06:00 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
        Thunderbird/102.11.0
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: samsung: use Exynos7
 fallbacks for newer wake-up controllers
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Peter Griffin <peter.griffin@linaro.org>,
        semen.protsenko@linaro.org
From:   Jaewon Kim <jaewon02.kim@samsung.com>
In-Reply-To: <20231122200407.423264-1-krzysztof.kozlowski@linaro.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20231122200609epcas2p1da5f138359da3a0be4af4fbc25f2a8f5@epcas2p1.samsung.com>
        <20231122200407.423264-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk


On 23. 11. 23. 05:04, Krzysztof Kozlowski wrote:
> Older ARM8 SoCs like Exynos5433, Exynos7 and Exynos7885 have the pin
> controller with wake-up interrupts muxed, thus the wake-up interrupt
> controller device node has interrupts property, while its pin banks
> might not (because they are muxed by the wake-up controller).
>
> Newer SoCs like Exynos850 and ExynosAutov9 do not used muxed wake-up
> interrupts:
> 1. Wake-up interrupt controller device node has no interrupts,
> 2. Its pin banks have interrupts (since there is no muxing).
>
> Their programming interface is however still compatible with Exynos7,
> thus change the bindings to express this: retain compatibility with
> Exynos7 and add new compatibility fallback of Exynos850 in newer
> designs.
>
> No driver changes are needed.  This is necessary only to properly
> describe DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Jaewon Kim <jaewon02.kim@samsung.com>


I will also apply it to ExynosAutov920 DT patch.


Thanks

Jaewon Kim


>
> ---
>
> Cc: Peter Griffin <peter.griffin@linaro.org>
> Cc: semen.protsenko@linaro.org
> Cc: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>   .../samsung,pinctrl-wakeup-interrupt.yaml     | 25 +++++++++++--------
>   1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> index 1b75abebb953..2bafa867aea2 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> @@ -36,13 +36,17 @@ properties:
>             - samsung,s5pv210-wakeup-eint
>             - samsung,exynos4210-wakeup-eint
>             - samsung,exynos7-wakeup-eint
> -          - samsung,exynos850-wakeup-eint
> -          - samsung,exynosautov9-wakeup-eint
> -          - samsung,exynosautov920-wakeup-eint
>         - items:
>             - enum:
>                 - samsung,exynos5433-wakeup-eint
>                 - samsung,exynos7885-wakeup-eint
> +              - samsung,exynos850-wakeup-eint
> +          - const: samsung,exynos7-wakeup-eint
> +      - items:
> +          - enum:
> +              - samsung,exynosautov9-wakeup-eint
> +              - samsung,exynosautov920-wakeup-eint
> +          - const: samsung,exynos850-wakeup-eint
>             - const: samsung,exynos7-wakeup-eint
>   
>     interrupts:
> @@ -86,11 +90,14 @@ allOf:
>     - if:
>         properties:
>           compatible:
> -          contains:
> -            enum:
> -              - samsung,s5pv210-wakeup-eint
> -              - samsung,exynos4210-wakeup-eint
> -              - samsung,exynos7-wakeup-eint
> +          # Match without "contains", to skip newer variants which are still
> +          # compatible with samsung,exynos7-wakeup-eint
> +          enum:
> +            - samsung,s5pv210-wakeup-eint
> +            - samsung,exynos4210-wakeup-eint
> +            - samsung,exynos5433-wakeup-eint
> +            - samsung,exynos7-wakeup-eint
> +            - samsung,exynos7885-wakeup-eint
>       then:
>         properties:
>           interrupts:
> @@ -105,8 +112,6 @@ allOf:
>             contains:
>               enum:
>                 - samsung,exynos850-wakeup-eint
> -              - samsung,exynosautov9-wakeup-eint
> -              - samsung,exynosautov920-wakeup-eint
>       then:
>         properties:
>           interrupts: false