Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp159682rdh; Wed, 22 Nov 2023 23:24:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IES3dA2Cyqv5o/8J+UvA+4oBpjlbX7WArx/uBNmiRGgA0JAnlB7/jc2f0wFjtlvzo7CvK9j X-Received: by 2002:a05:6808:158:b0:3ad:ff3e:d25c with SMTP id h24-20020a056808015800b003adff3ed25cmr4962386oie.53.1700724254050; Wed, 22 Nov 2023 23:24:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700724254; cv=none; d=google.com; s=arc-20160816; b=fNiRkg7Wguu7HUEEl0JD3LzBSeBrFTr3U7qAESsIDwAPzL9k/eQ2LNXGoJ1S0sjLAc v8XP0IhFUdeM3GGGEo7y+bU+o/n4b4cPtekolXx9AO+6Am3ZmXNc4TiySNcoYoG0ecBq f1JE5djVkPrABSbJUSOHVTpc9mDsRD3+V5L73Moype5AjhGd5qHXBjAmA6DDQoDmIS8+ eFDqwi7MuzDdN3zt3ZHQg00z2tzwvZSgI/9TezS4ynFgZSFY++tK7w0ew/lBG6TfrEDf /t4fn0INCg6z3alM91h6jLWDVQ/OdyboqXaNQwTJaIvcbzdF9fN0XUuGJgfwDi0nCRy1 d0bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cH5KstrQ6X9Z2/rTKAQoqizmRcDpRe5h9xPsJQTg8Qo=; fh=xlRG/ctwqmTme5HrOpixOFf1E0Ug1ecqWpxpTddbOOw=; b=Z8Dy+8Gjs25HcN1U/rEgpzB4cAug0tSef03qxNwwAMwdH6j8RqK81hmxuSaptaNvCk 5mNiTIZ9sevhccdRwfxejtjoBu+tc/7EorOFVNiVlkHpzHquRZ2niyBI1kHpE0fyj6AR 6Obgehsl+aD38H78DSAxdvO4zKtWcwG8ZfwaKX+2CIyVW9dPFOnk2Z3YXbk7KL99DqVl M5i5vKnrQEKvOqZLddIf7Wcz6twxhKLZb+5kE8zrMQyfDaseFlIEtnZwsDTKcsiBtiEq dN19pE4etaRCczjTHFA5AYPjoy9eumsEixHDJo+85mibTbFpRSirEP+JBrX8yH8lPGdz M5Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2PfPu0Bg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id u1-20020a63d341000000b005be3c62f45fsi771765pgi.638.2023.11.22.23.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 23:24:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2PfPu0Bg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 94D29806B70D; Wed, 22 Nov 2023 23:24:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbjKWHX4 (ORCPT + 99 others); Thu, 23 Nov 2023 02:23:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbjKWHXy (ORCPT ); Thu, 23 Nov 2023 02:23:54 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 268F0CB for ; Wed, 22 Nov 2023 23:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cH5KstrQ6X9Z2/rTKAQoqizmRcDpRe5h9xPsJQTg8Qo=; b=2PfPu0Bg1MlvogYjoOdQsxlJtf uOEfFygoHfw4sHk1rfBCN38h305SgXrphdFMv1eqyFLFRpRwUigUwJmIJ5gnMNn8Cl7H6KVH3GASL r0Q4wannJjnYKow60Eb3LJRm0AnMDgC6uH9Hf53EG/qhz/C0QWIbz5eFeIiWUtoKoUm5n9a3xSz60 cKU9vWmgasDn8YaWiYV283xZeUzdWEpPBsu7t58HCHdLfR7BXAARNzc8fwP7CwrEfBJmSbmLsDe5z A9JPrjVyliBsJ4PfWTMYToml7aMxSYJfgCQHvx2rGQCH+WnR5Z6a4DWKpbFhT/lgOJwg8+ptZRMrg 7bxwjhWA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r6445-0041QU-1j; Thu, 23 Nov 2023 07:23:57 +0000 Date: Wed, 22 Nov 2023 23:23:57 -0800 From: Christoph Hellwig To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 03/12] mm: Export HPAGE_PXD_* macros even if !THP Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-4-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116012908.392077-4-peterx@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 23:24:11 -0800 (PST) No way to export macros :) I'd say define, but other might have better ideas. Otherwise looks good: Reviewed-by: Christoph Hellwig