Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp159846rdh; Wed, 22 Nov 2023 23:24:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWaWfZbf9rIO97qzJP5jekxL0MkzhPWyeIStysa4IjPQZusvHmflboKmWpMmOWDdqE0Wj1 X-Received: by 2002:a17:90b:108d:b0:281:35e:82a1 with SMTP id gj13-20020a17090b108d00b00281035e82a1mr4199572pjb.48.1700724287945; Wed, 22 Nov 2023 23:24:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700724287; cv=none; d=google.com; s=arc-20160816; b=jHed1t4GUddenFowSIxQYlyhSBHYuT0FQSAp2T7f5+KSvslGZkPVbsgh3G72ikxpku KR+DAGr+32OI3dVofhkeGPddqQ5LIwRh0KziPz6O85RC0E+kslbD0LWYsJfEf6jOdNcd yNLlV0tQ0BsU+YMiygK2DKz9zyuzZqMyQzEtiu8CiPD3pH9EjAQ7rv+K1FkOr7M+4oVe mMn7Fk4YkPEvPeBuuImmwZTV+aDyJ5/imQLGVrKmaAP9IR7nwxa6YxuQpApxS72uguJU jZWBN8Fg8fp9BykjmbZfbEpCSia56U1gXPkWV5+JHvbhbw5Jkn66fsk0ruwPLNKZNR9I 0l5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JFbIyAbEwtb6PnVO2Q0IzmMwdTGFYa7ANNbQw/6iZHI=; fh=aiWfLqNB1nW4d+5DAG94r7xEKj3Qw2ufUrVCkpTGo54=; b=c6QknTwklfbE4f2g7lHYM6aUaeuFA7/XshiaxjD8oBqZfvl8aWRu3pOwBmmnjsZPL+ rRZRUKTDJ2fz498GXR1O8v5zOyZP7Nt4or7ius81AWgfWUllHKWsakQmPQZ1hlENX97h SFrl3SaLqz5R/Fe2sYkgD7u9fJmKgFd6yWrSh5hHlX9aFD+8uy9jzVV+13M8jYCO6SKc INr9GC7PNXmJOfXBFJetmdsg/i3FBGdiplYcEJF2NmbsxmjG7xQkh8fF6PqdAlgKcni5 SiW68XZ8tSyF0e1ONOi6CrbZKyiXrCuBFAqkt4rakTR5n+jYe8uH5VIvgzh7QoEvHfGp aRLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=rP4EHuoS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id e8-20020a17090a684800b00278f6d616aasi772533pjm.71.2023.11.22.23.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 23:24:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=rP4EHuoS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 11B8680AE821; Wed, 22 Nov 2023 23:22:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233020AbjKWHWK (ORCPT + 99 others); Thu, 23 Nov 2023 02:22:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235301AbjKWHVt (ORCPT ); Thu, 23 Nov 2023 02:21:49 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF28D69 for ; Wed, 22 Nov 2023 23:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JFbIyAbEwtb6PnVO2Q0IzmMwdTGFYa7ANNbQw/6iZHI=; b=rP4EHuoSSlQQW0V8h103g/kEEr 33ysbISYUlE9yKwiU2wudbmdLm+4RetJuDrvnnlO31uiwOzMeI4Yl7E1qWyDwAvXeXRYf1WWeBLAy 3gSN4AqMoyJz3+jH2JAk2ncsNmVb3wbWqeqyNyN0G+uqjae80EURweD5lg7JhQVPpwYyvvmRHd9E6 m2qvxXGbCZRkBstP1uERXQkrmc2XkK7rpbBuTF51BVt2lzYthHeaFGsN7QkRitJNT2SvwrjdRK+Zy 6HxWugsUozHHJ2DJQ9OuEwLabey62FWT0XVdtMQf4+8fGDIuIrRW6iiNSd6c6i9/SQpmK1W7DivSY 6eJkE2uA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r6422-0040uN-2m; Thu, 23 Nov 2023 07:21:50 +0000 Date: Wed, 22 Nov 2023 23:21:50 -0800 From: Christoph Hellwig To: Peter Xu Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 23:22:25 -0800 (PST) On Wed, Nov 22, 2023 at 10:22:11AM -0500, Peter Xu wrote: > The other reason I feel like hugepd may or may not be further developed for > new features like large folio is that I saw Power9 started to shift to > radix pgtables, and afaics hugepd is only supported in hash tables > (hugepd_ok()). But again, I confess I know nothing about Power at all. That alone sounds like a good reason to not bother. So unless more qualified people have a different opinion I'm fine with this patch as long as you leave a comment in place, and ammend the commit message with some of the very useful information from your mail.