Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp162741rdh; Wed, 22 Nov 2023 23:32:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+nm2WwM2W4OLHCG+wBas8TUOg6DHtNzw+v3BkTXGajbA11NFoxXXsVlLUc9LSboAjAOlF X-Received: by 2002:a17:90b:3a87:b0:285:34a2:3dab with SMTP id om7-20020a17090b3a8700b0028534a23dabmr4915658pjb.11.1700724766893; Wed, 22 Nov 2023 23:32:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700724766; cv=none; d=google.com; s=arc-20160816; b=MlEPmf9RXFj4FtZHvN874m7SRSz+cckrRZrUmuLAUrrvCwYdEaVcwQmRBmu+V4IdkS ZVjvAgwmZLie4lJjFxnwGZ0t5Dy6EdVzljffvvtfwxTTzNCDkSJhXgZdjssgTvLKk4Iw S+RyP1FAuB9k6vXm0CrjkvIPDIvY+wUl5ld40TD6NM3oSgkXPE6wl5V+ciIGK964k82T 8BxH/GCrjqcpXJ8YHmVYETQ+3lhic5Au+pF/+lDSLBYvyKPI4CVgWc5sn1Yyd/RRZFa3 u7/RtY0tTXAbkJnbxXcU7IUygYfg3CVWpIHII3dBBEQGvlWppnJ1qZOM6ovF1++4uBYu XyMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=d7S/FKalzXE2uJiN7XbTBuXkMpogj8oWwgyCfRleg4Y=; fh=gQOYgyhlH9eCP0qOtxNz1REdkBbCEH4j9nqElX3uhdU=; b=LGI/tg6HlJOItTbbpml/eZEHp8boG8BkVuUpPeU4b4whEOfBKJxoHrtPHlPZSgzsr2 0/F3KaEwy82uY/DPZne3fZADKIVgz0V4VO6kASeurqpBSFIH1sP0huX57C6qRTSxhKik ZWmMtE0H019fWsP7R8g7RRVOf4nta85MFmm0uDSXRRG9ymiZwgkhO+WCv1o0u+0HnwXh 9oJ8FnSHnIK6ZAGp5zzaBSGR5ckLhLZOyvo3t+l5yaInWBuYk5iltVaLdvv2tsS1mgA6 r65yNk29AuU8yWzjjmBjBdyEFycD/iju4mwDmdxpeKcs9bWscmy0JoCFJUy7KqdNUK38 EDow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1SKOsh9G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id t8-20020a17090a2f8800b002854780f7c7si769903pjd.172.2023.11.22.23.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 23:32:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1SKOsh9G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7ECDA83154A5; Wed, 22 Nov 2023 23:32:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343654AbjKWHca (ORCPT + 99 others); Thu, 23 Nov 2023 02:32:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjKWHc2 (ORCPT ); Thu, 23 Nov 2023 02:32:28 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED218E7; Wed, 22 Nov 2023 23:32:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d7S/FKalzXE2uJiN7XbTBuXkMpogj8oWwgyCfRleg4Y=; b=1SKOsh9GVU8iqvK6R1fOs0sh2s CZSBcnZ7pXUvGsWz+Fb4qq1jTzZWzObgWnxlffh3BMb6ZxMI2zWRJE660LVnqHzZu7+i9rFd0bTXL 4MCic54La6hsZw+eLdvJuCO9RPKQRPEnpGSMNGqGkYT+oDb/RIgvd96C2OzvhZya1aW4OlSZgfLUM k6+y+gbJgCZru0pSWsHcf/UnhuzCabugOeEJUNAchUOOBcXVaIgsZ9Tu/Jn0Sr16J5FJymlFmRr9s 2ClOaRjsxbEQ18DwIdODqOJmMA1gXC6hrdaA+bNVYdv9YrqW0hCU2uTQt7dGDjDNpYWzdYDU8wLlO wzGESUBw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r64C5-0042og-0b; Thu, 23 Nov 2023 07:32:13 +0000 Date: Wed, 22 Nov 2023 23:32:13 -0800 From: Christoph Hellwig To: Michael Kelley Cc: Christoph Hellwig , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "kirill.shutemov@linux.intel.com" , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "decui@microsoft.com" , "luto@kernel.org" , "peterz@infradead.org" , "akpm@linux-foundation.org" , "urezki@gmail.com" , "lstoakes@gmail.com" , "thomas.lendacky@amd.com" , "ardb@kernel.org" , "jroedel@suse.de" , "seanjc@google.com" , "rick.p.edgecombe@intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v2 3/8] x86/mm: Remove "static" from vmap_pages_range() Message-ID: References: <20231121212016.1154303-1-mhklinux@outlook.com> <20231121212016.1154303-4-mhklinux@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 23:32:44 -0800 (PST) On Thu, Nov 23, 2023 at 12:24:49AM +0000, Michael Kelley wrote: > > I really do not want to expose vmap_pages_range. Please try to come up > > with a good way to encapsulate your map at a certain address primitive > > and implement it in vmalloc.c. > > To clarify, is your concern narrowly about vmap_pages_range() > specifically? The prime concern is that it took a lot of effort to make vmap_pages_range static and remove all the abuses. I absolutely object to undoing that.