Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org>
In-Reply-To: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 23 Nov 2023 16:38:37 +0900
Message-ID: <CAK7LNASVMjVg4dr=KdSDHwGww_47H78H7rMXA=wf+ncugesDSA@mail.gmail.com>
Subject: Re: [PATCH v2 0/4] kbuild: Per arch/platform dtc warning levels
To:     Rob Herring <robh@kernel.org>
Cc:     Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Conor Dooley <conor@kernel.org>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-riscv@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 23, 2023 at 7:12=E2=80=AFAM Rob Herring <robh@kernel.org> wrote=
:
>
> This series adds support to set the dtc extra warning level on a per
> arch or per platform (directory really) basis.
>
> The first version of this was just a simple per directory override for
> Samsung platforms, but Conor asked to be able to do this for all of
> riscv.
>
> For merging, either I can take the whole thing or the riscv and samsung
> patches can go via their normal trees. The added variable will have no
> effect until merged with patch 2.
>
> v1:
>  - https://lore.kernel.org/all/20231116211739.3228239-1-robh@kernel.org/
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---


There were some attempts in the past to enable W=3D1 in particular subsyste=
ms,
so here is a similar comment.

Adding a new warning flag to W=3D1 is always safe without doing any compile=
 test.

With this series, it would not be true any more because a new warning in W=
=3D1
would potentially break riscv/samsung platforms.

Linus requires a clean build (i.e. zero warning) when W=3D option is not gi=
ven.


> Rob Herring (4):
>       kbuild: Move dtc graph_child_address warning to W=3D2
>       kbuild: Allow arch/platform override of dtc warning level
>       riscv: dts: Always enable extra W=3D1 warnings
>       arm/arm64: dts: samsung: Always enable extra W=3D1 warnings
>
>  arch/arm/boot/dts/samsung/Makefile  |  3 +++
>  arch/arm64/boot/dts/exynos/Makefile |  3 +++
>  arch/riscv/boot/dts/Makefile        |  3 +++
>  scripts/Makefile.lib                | 16 +++++++++-------
>  4 files changed, 18 insertions(+), 7 deletions(-)
> ---
> base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
> change-id: 20231122-dtc-warnings-968ff83a86ed
>
> Best regards,
> --
> Rob Herring <robh@kernel.org>
>


--=20
Best Regards
Masahiro Yamada