Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <170066723324.2477261.2506149141979712937.stgit@djiang5-mobl3> <655e7361d6ce_b2e8294b9@dwillia2-xfh.jf.intel.com.notmuch>
In-Reply-To: <655e7361d6ce_b2e8294b9@dwillia2-xfh.jf.intel.com.notmuch>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 23 Nov 2023 09:17:49 +0100
Message-ID: <CACRpkdYjEgsyCznNwkSaStk+DMtjH3_oGeX4f4BJzpo5eXHm2g@mail.gmail.com>
Subject: Re: [PATCH v3] acpi: Fix ARM32 platforms compile issue introduced by
 fw_table changes
To:     Dan Williams <dan.j.williams@intel.com>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     Dave Jiang <dave.jiang@intel.com>, rafael@kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, lenb@kernel.org,
        robert.moore@intel.com, Jonathan.Cameron@huawei.com,
        guohanjun@huawei.com, linux-acpi@vger.kernel.org,
        acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, cfsworks@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 22, 2023 at 10:32=E2=80=AFPM Dan Williams <dan.j.williams@intel=
.com> wrote:

> It concerns me that neither linux-next nor 0day robot exposure reported
> this problem.
>
> Does ARM32 require manual compilation coverage these days or was this
> just a series of unfortunate events that the build bots missed this?

It's not just ARM32, I saw it on ARM64 as well and I'm pretty
sure it appears on any bare metal "none" compiler.

kernel.org host "nolibc" cross compilers (Arnd makes these):
https://mirrors.edge.kernel.org/pub/tools/crosstool/
and those WORK, because they use the kernel minimal
libc which defines __linux__.

So a "nolibc" compiler works but not "none" compilers.

I think the test robots all use Arnds nolibc compilers or the
compilers from distributions so they don't see this.

A typical example of breaking compilers: ARMs supported
"none" compilers:
https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads

Yours,
Linus Walleij