Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp195460rdh; Thu, 23 Nov 2023 00:59:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDN6oNwogMyHxt7dJeh6yJXoH3Mw2TsN8NXIIORhCMHCUPmT37ZEw0c2Su1z63gl3sRIjz X-Received: by 2002:a05:6a00:938c:b0:6c2:e10:42e3 with SMTP id ka12-20020a056a00938c00b006c20e1042e3mr2817046pfb.8.1700729961128; Thu, 23 Nov 2023 00:59:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700729961; cv=none; d=google.com; s=arc-20160816; b=FRvG/AXws62JScC4B4I9wCijxKLKamXmkMMYvzoqqiYt2tZCwhP8Gnb2Iy7eWZJzk/ IIYl4/CgNqFHbFJO5kTcD2cyi5mL025daEmls/C1ifOcF9X6y8clLtFgrnYG4Sc9OY4b U04qGpPuuhFZHJROQf1fgO37ayF1v/F/+SuRfxkyBHgPS+VykrIh5Vaopwe+fVP4+wBW i2/eFc4O1SIbDt1P0I0ERo6a2vsSD1gjN0Rl0CQQCmNctrlUPFKTLkdU3sBizZ4KGaz7 UAoUx1wwYP4ZRZGgytJpFqj+nZmJSLLviFJAIwpkbmn+5DtmcfskJ7N3BAUSm39SL1/2 HHRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=mP3Zh3ghe1QobYCFwkdhcpkOdhL0iT2Q9aPGVoVes/U=; fh=Mo6TxgGzGLrlS+5dVlNWdqd+fZYn09cU+8+JAb6EqZk=; b=kGMhP9K3mxUmXdxTnHvOPPkR+jrTD4IMwOAmZEvAOkCl40G44p/1BiyCbsBtTWbnQv 1mSAm9iE6Ysv4KhOm92Sen4TxRHi5fEpxiQXP3ifDQBDpzUp9Tc56yYkhSyo9extVu3g lIyRmXov+FoWLG+bBsWxM1s3MA7md2rzShDKcIUno1/f/uny1zdqIBlIBjjlnlHGXO9j dICFhHzsEmtLXRBfc0MHh6GeyxpCOuoWAhX4TTqi4lbwixXIka3hB0jA7bCoa1uoZueC RLic5EvEnxl/orb1ZeDAuUBu6+JPwRpEusIzAxYyKTJv5Ez/DVUwuEQRKF0H8Cv5i7ba G0ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=k4tZR+tM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id p188-20020a6342c5000000b0057e21f51ab3si875362pga.665.2023.11.23.00.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 00:59:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=k4tZR+tM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0D8CC802AF18; Thu, 23 Nov 2023 00:56:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbjKWI4F (ORCPT + 99 others); Thu, 23 Nov 2023 03:56:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjKWI4D (ORCPT ); Thu, 23 Nov 2023 03:56:03 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CF56A3; Thu, 23 Nov 2023 00:56:10 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AN6JD3K015853; Thu, 23 Nov 2023 08:47:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=mP3Zh3ghe1QobYCFwkdhcpkOdhL0iT2Q9aPGVoVes/U=; b=k4tZR+tMtlstqkBrgmETuO33SOlNJohMaUUZ0TdHEH8dqkb+6Ymh+sH2sOiGTvqBsf28 H5rBltfC2U+zbthuX6u2BBsvbFXztlvj2AIvcA1QHo8vmvsRnm0rJeQ3zwa12WKxeukQ EZ1DPYoX00yVsKZBPSe4fo8y0eF2xVxx6ZLIv8CIOtXdb+zJXE1qHnhb4qXlEFjcwImI YGFWJ8iIxASFtOSN5LuK9YGf6AQke7v/jjebnjvvYS7EfX7g8npioGkdx+CWzz3x73j/ HTArXLU3KnI8K7wryrBF7Kg0Vm22+xk68swqUUUhDEycNuTN+AdMnn1hEmnc3wtoqvgE Cg== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uhwme8v49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Nov 2023 08:47:03 +0000 Received: from pps.filterd (NASANPPMTA05.qualcomm.com [127.0.0.1]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3AN8VFWN001797; Thu, 23 Nov 2023 08:47:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTP id 3uhcusvt7e-1; Thu, 23 Nov 2023 08:47:03 +0000 Received: from NASANPPMTA05.qualcomm.com (NASANPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AN8UVqs000883; Thu, 23 Nov 2023 08:47:02 GMT Received: from stor-dylan.qualcomm.com (stor-dylan.qualcomm.com [192.168.140.207]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTP id 3AN8l2K3022937; Thu, 23 Nov 2023 08:47:02 +0000 Received: by stor-dylan.qualcomm.com (Postfix, from userid 359480) id CFB9D20A68; Thu, 23 Nov 2023 00:47:01 -0800 (PST) From: Can Guo To: quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param() Date: Thu, 23 Nov 2023 00:46:22 -0800 Message-Id: <1700729190-17268-3-git-send-email-quic_cang@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1700729190-17268-1-git-send-email-quic_cang@quicinc.com> References: <1700729190-17268-1-git-send-email-quic_cang@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ld5psP53TjFfSqKqOc215_i6Ck2Rsu6n X-Proofpoint-ORIG-GUID: ld5psP53TjFfSqKqOc215_i6Ck2Rsu6n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-23_06,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311230062 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 00:56:17 -0800 (PST) In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only used here. Signed-off-by: Can Guo --- drivers/ufs/host/ufs-qcom.c | 1 - drivers/ufs/host/ufs-qcom.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index aee66a3..cc30ad9 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, switch (status) { case PRE_CHANGE: ufshcd_init_host_param(&host_params); - host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE; /* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */ host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba); diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 9950a00..82cd143 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -27,8 +27,6 @@ #define SLOW 1 #define FAST 2 -#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B - /* QCOM UFS host controller vendor specific registers */ enum { REG_UFS_SYS1CLK_1US = 0xC0, -- 2.7.4