Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp199286rdh; Thu, 23 Nov 2023 01:06:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYXRffvr/Mzv7ir7XqbJ/n9aP57wfdJ5r8O0/reYcMKCzMKaS0S7r/XVufit+idDeJbnWg X-Received: by 2002:a05:6830:100b:b0:6d6:4be1:442c with SMTP id a11-20020a056830100b00b006d64be1442cmr5366714otp.4.1700730380115; Thu, 23 Nov 2023 01:06:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700730380; cv=none; d=google.com; s=arc-20160816; b=YB4jJY3Y0XiXK9xalLNYJHxx3YamaAhfGb3h5+0gdokBA8M30jK/Qk6CKkIpgtfarh sS5Q4yqO11eG9p3FpGpWi8jr3ifpikHj23KZGdIIZedRdyDx8NJtI2FAH4PVFi0yVTzL WBzJSDXNw2IM/XyeH9uB4jz5mGZTHUQtZLn/5cb/+tViZ7weXcl7Ry+uhE1UWyvSaWf7 hxKaJrIQwq0vpn8Y4L8aum8eAt2511oQl4SsqOt4XZ2iuqFAauQXcHP6fF1ixYHfFwgh PxbSmgCa9twN0Os/gITIbXQyppd5zQQfv4YTSH1YpT7qnMrdXtnecGlQwUjHK972VbwB IpEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=KVlnO7K/+WSeJF1leHB0nUShyhcvEvKpaDHWizQqimM=; fh=uxLNaPoPRUzmkUc1KOgGwCEU/bTSjK8Yed2Up6ovXLY=; b=iE22JqbB5L8/13kq829MR832cTAYkGpb0YwmHe1Y9rJ8hKcauIeURZ+O8hzABy/JXe 0/07a9ZK1MyK/BFvnPMK1OJyicON2OneijO9kF6bdcLOMlUa4pvt8OFBDpRxjzvOQjH2 47jq5UtlRQ/wcdAqILygJswBaxw2cwC4khlYTGgr6bS9Fu5Zo0GagMInYx9xWccptjiL BlWv+gcc6PdURDoZHTyOVQisx7geef7fQFOoqjt9rDJ7ZW4ZmX/00QV9+t3AAp3XzYnj VG7J3TvbpxaHxaZ4E0oV130u36ZQxAZu9XbW5K+kJHlvtZcXK+pswtoLsHtsDyzvUt5v F0/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ZSp86fty; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id c32-20020a630d20000000b005bd27be66e1si927871pgl.719.2023.11.23.01.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:06:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ZSp86fty; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B066381DE3A2; Thu, 23 Nov 2023 01:06:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232374AbjKWJGD (ORCPT + 99 others); Thu, 23 Nov 2023 04:06:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232067AbjKWJGA (ORCPT ); Thu, 23 Nov 2023 04:06:00 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 056ECD69 for ; Thu, 23 Nov 2023 01:06:04 -0800 (PST) Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id A0129660738E; Thu, 23 Nov 2023 09:06:01 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1700730362; bh=jXx0AZxK0x/3x229o8gedk/6QPlybYeQFVHL/LcCTj8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZSp86ftyTaaRQ1uCyPN0eOAAmXLdLz+oOdzcxBeABdqLPtswej1z5nVQj2WLuVB35 2yuuRJUU8TjK4IAowsJVj2LRWBngf1dLfc2U4SqkoiJPIbp2DlnFz6jGMVG/dZMHaQ z12bNmCYM65GsdnU3hGAsEtkmQCQBr73UD/NOJ+lXOXuUVi60Y5UkVAiidyhKdWXrt TnUMkoloHlHX663vqHVpzOiLGL0AWM7Z4QcDg5xJp15giD05mAlqAPC/dpF4zvnhBo b9TS12tqrFhXs/iHkIPO8jLsAPW6hAslJdiwi9F77GDI3Ws7aCmbvN0XNu0oUmDf16 /5Pey2NHXtIwA== Date: Thu, 23 Nov 2023 10:05:57 +0100 From: Boris Brezillon To: Dmitry Osipenko Cc: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Christian =?UTF-8?B?S8O2bmln?= , Qiang Yu , Steven Price , Emma Anholt , Melissa Wen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages Message-ID: <20231123100557.05a49343@collabora.com> In-Reply-To: <26890ba7-5e19-df0c-fce0-26af58e66266@collabora.com> References: <20231029230205.93277-1-dmitry.osipenko@collabora.com> <20231029230205.93277-16-dmitry.osipenko@collabora.com> <20231110115354.356c87f7@collabora.com> <26890ba7-5e19-df0c-fce0-26af58e66266@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 01:06:17 -0800 (PST) On Thu, 23 Nov 2023 01:04:56 +0300 Dmitry Osipenko wrote: > On 11/10/23 13:53, Boris Brezillon wrote: > > Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we > > add a drm_gem_shmem_get_pages()? What we should do instead is add a > > drm_gem_shmem_get_pages() for each drm_gem_shmem_get_pages_sgt() we > > have in the driver (in panfrost_mmu_map()), and add > > drm_gem_shmem_put_pages() calls where they are missing > > (panfrost_mmu_unmap()). > > > >> + if (err) > >> + goto err_free; > >> + } > >> + > >> return bo; > >> + > >> +err_free: > >> + drm_gem_shmem_free(&bo->base); > >> + > >> + return ERR_PTR(err); > >> } > >> > >> struct drm_gem_object * > >> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > >> index 770dab1942c2..ac145a98377b 100644 > >> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > >> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > >> @@ -504,7 +504,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, > >> if (IS_ERR(pages[i])) { > >> ret = PTR_ERR(pages[i]); > >> pages[i] = NULL; > >> - goto err_pages; > >> + goto err_unlock; > >> } > >> } > >> > >> @@ -512,7 +512,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, > >> ret = sg_alloc_table_from_pages(sgt, pages + page_offset, > >> NUM_FAULT_PAGES, 0, SZ_2M, GFP_KERNEL); > >> if (ret) > >> - goto err_pages; > >> + goto err_unlock; > > Feels like the panfrost_gem_mapping object should hold a ref on the BO > > pages, not the BO itself, because, ultimately, the user of the BO is > > the GPU. This matches what I was saying about moving get/put_pages() to > > panfrost_mmu_map/unmap(): everytime a panfrost_gem_mapping becomes > > active, to want to take a pages ref, every time it becomes inactive, > > you should release the pages ref. > > The panfrost_mmu_unmap() is also used by shrinker when BO is purged. I'm > unhappy with how icky it all becomes if unmap is made to put pages. Why, that's exactly what's supposed to happen. If you mmu_unmap(), that means you no longer need the pages ref you got. > > Previously map() was implicitly allocating pages with get_sgt() and then > pages were implicitly released by drm_gem_shmem_free(). A non-heap BO is > mapped when it's created by Panfrost, hence the actual lifetime of pages > is kept unchanged by this patch. But the whole point of making it explicit is to control when pages are needed or not, isn't it. The fact we mmu_map() the BO at open time, and keep it mapped until it's not longer referenced is an implementation choice, and I don't think having pages_put() in mmu_unmap() changes that. > The implicit allocation is turned into > explicit one, i.e. pages are explicitly allocated before BO is mapped. >