Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <da13e561-0b3b-401b-966f-9a54e2e9c36b@nxp.com>
Date:   Thu, 23 Nov 2023 11:06:27 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: fsl_xcvr: refine the requested phy clock frequency
To:     Shengjiu Wang <shengjiu.wang@nxp.com>, nicoleotsuka@gmail.com,
        Xiubo.Lee@gmail.com, festevam@gmail.com, shengjiu.wang@gmail.com,
        lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <1700702093-8008-1-git-send-email-shengjiu.wang@nxp.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <1700702093-8008-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjQ3QWFEQjlVWGhtczB6ZGFteG5tejJ1bis2UWtCK3FXV05MOW5ON3ZCVEJJ?=
 =?utf-8?B?TlBWQ2ZENGNieTF6ZTJVNVhSRFA1akFzTk9TMzV2RFVpRE1yK0t2clBpcFBo?=
 =?utf-8?B?cWY1YjE3eEZWRWRVa1BsUHFKSzk1cmtiNW9nL3RLZ2RjUlVucXNDVUZnZFJi?=
 =?utf-8?B?VGtGM3ZoanpaM1dSK0QvQW11dlowNlU3R2hkZkxvS3M5bkowYnJqVlpOY2V0?=
 =?utf-8?B?MDVYV2FqQUx5ZzlDS0R5OFh5M3pVcjZ2TkdISS9acTBvdTcwTGR6UTlBSXNR?=
 =?utf-8?B?dU9XQ1VONUE2d2pPSGVRSXBBa0JoMW10bTEyVCtFcVRkQ01WMmU4WGQ2ZlNI?=
 =?utf-8?B?cTMwUUZWQmdpbDBMNW1sRzZ3KzZUZi9TL2tOaDVTeUo3Szl2NlM2WU9OSVdq?=
 =?utf-8?B?RkpBYWZXMFh1c1BCL3lBNkJ4RytweTBYRmtoTW5yN0MxbzNsT1hPN1IzdFFP?=
 =?utf-8?B?a05EbEpUTUhObTlVd0FETGJtTEphbzUrekRPNXJnZGdKV3lsTVlNWHd5YzRQ?=
 =?utf-8?B?SEU2NUJRcVZDRjF5MU5qOFBhUUtqZ1FScHA4WEFVT3BpSnZHQ3JqcWE2T0FF?=
 =?utf-8?B?RG05dHpNVWdOb1N3MUhlS2FYbjd3T1g0d1c4OWF1TExXeUZzeFExeG9pWEY0?=
 =?utf-8?B?SUtqcFpER3JVS0M4Mlk3SnVYTEtieCtIOU1WZTB0cUVUOEIra0ZZaWhXZndI?=
 =?utf-8?B?OGFqd0RXekRlaUNBNXVEZ2NNYU96Q2JtdEJmdS9VUnNhSXpqeUlObjZsUm5T?=
 =?utf-8?B?OTNndXc2Nlh1Q0lvK0VORC95VmVjOHhGWW5nek00SUs4Y0VSUUFSZVFSVEJY?=
 =?utf-8?B?UmtmaWU4VjRrb1ZZcEJnRmhudUQrQjhjWXZBRGVTaWl2VnB3Qzh1MVVwYVly?=
 =?utf-8?B?TTJoSjZ0a1Z3VkFhQ0tRQUZHVVZMSnRub01kVU02d29zQnVMbUNvblB2U0Vv?=
 =?utf-8?B?dFZqOWtwbno0b1J1aWwyRjZVT1ZtMndiK1gyeVlSZkRaaG8weEFqTU9SWklT?=
 =?utf-8?B?VXR4bmFrRk5OT0diV1NkaDJVelBaRDhJWFNneURBMGRFc1BLVml0UmZqSllw?=
 =?utf-8?B?TlExQk1KRE9YenNaRkUrZFpUV2lPM0hCcTVjYTdmUUN4dTBKM3pwTE1JN0dG?=
 =?utf-8?B?Zm9tUDYvaTR5cExZZVRkN2VkYnNhT3hMc3IxVXRGRk9SMUZ3MjE1UXYvK2tY?=
 =?utf-8?B?WVZxNzVvV0NSM09JVHRBTGJJRnpTM1Rma1AwZnhvbjJ0dnFqOWxYcThqTWFX?=
 =?utf-8?B?eTNmTWVNeGJNUkpPUnErY3ZqcWhweW44cmo0ejhYckYxRW5FUWNZMVczdTEy?=
 =?utf-8?B?ZzJHbjN6QWVnaENEbUdCK0FyalBrZksrNTVTeXF0NEs0bFB1eVEyRitnTE1l?=
 =?utf-8?B?YXMzOENYekw0clhzNjZIYmVZMmdPVnJvYzRGZ3RLZlNJVjh6bUV3UjlIMTFa?=
 =?utf-8?B?MWY5eVMyNVdIYmpVblMvMDJrR0VnZW9YZ3NYWHIzS1dxcjdVcFZIdmd5eUJW?=
 =?utf-8?B?ZHg4TTRjZGhDY0JaKy80TERmMmtrRUxZa2VVU3B6STNmK2hFcnFicnNXTVZB?=
 =?utf-8?B?cEdZcnUwYkpYSUdsVmVVQTE1S3h6cGMxQWljZ0VubG45a0ZoVUgvWkgzRm1k?=
 =?utf-8?B?ZjhyMGxROGFSQXRibDhYcS9RYVVCbkdRMHAwRGlocVNkQlBwMm03NDZ4bU0v?=
 =?utf-8?B?YmE4a2J1SVBzRkZzMW5LMHZSUEt4Uyt2VzdSR1RZcjJhaklTUkJSQ0YwV2VQ?=
 =?utf-8?B?R0wwSXZ3K3hmNU4rTm1hM3ZPazd0VHpVOVdzRGxNS29mN09TaXhKcjFmTkgx?=
 =?utf-8?B?NUludjNKeHlhL2FlR2RLK0hSUEFoVitIYk01N0JhdnpVbk9odHVxTmRERnlh?=
 =?utf-8?B?NjJ4VUR4dWFvN01jVXY1Y0p6cFVDNGVVYnI1d1JnLzhqTUxyREZHNm9KbzIy?=
 =?utf-8?B?andYaks4cEhRR3czYmtsVGVlM3JNZDJhemoyWXptZlZDbjVDV3B0eEVIUnhh?=
 =?utf-8?B?bkdpNHpIYklQYkhxMW1hYzVIOTNoUGxHcVp2QzJaNFA4bDFRNWxNR0VmbDN5?=
 =?utf-8?B?U3lOVUtQeGdCSGZMZnplRVlLTFI1blJsWk1LdWgrOFAyc3dTcnRLUk5INWl4?=
 =?utf-8?B?VUxDY3pqM28xUG5USGpuYlphRjl4Z2wvNVZKZWFpSzQ0TURoc2VhQTZXMVFu?=
 =?utf-8?B?RWc9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1565f127-24f8-445c-066f-08dbec037b09
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 09:06:30.1792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JDIgj+gbFqKgBrNbnaCHsDTaYOGDweyKs/5ud0voKYXAUz0ackMSzav4gP9gTcnvsuFiTpbQz59a6ZTL5ss9YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8899
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 23 Nov 2023 01:06:50 -0800 (PST)

On 11/23/2023 3:14 AM, Shengjiu Wang wrote:
> As the input phy clock frequency will divided by 2 by default
> on i.MX8MP with the implementation of clk-imx8mp-audiomix driver,
> So the requested frequency need to be updated.
>
> The relation of phy clock is:
>      sai_pll_ref_sel
>         sai_pll
>            sai_pll_bypass
>               sai_pll_out
>                  sai_pll_out_div2
>                     earc_phy_cg
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia

> ---
>   sound/soc/fsl/fsl_xcvr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c
> index 77f8e2394bf9..f0fb33d719c2 100644
> --- a/sound/soc/fsl/fsl_xcvr.c
> +++ b/sound/soc/fsl/fsl_xcvr.c
> @@ -358,7 +358,7 @@ static int fsl_xcvr_en_aud_pll(struct fsl_xcvr *xcvr, u32 freq)
>   	struct device *dev = &xcvr->pdev->dev;
>   	int ret;
>   
> -	freq = xcvr->soc_data->spdif_only ? freq / 10 : freq;
> +	freq = xcvr->soc_data->spdif_only ? freq / 5 : freq;
>   	clk_disable_unprepare(xcvr->phy_clk);
>   	ret = clk_set_rate(xcvr->phy_clk, freq);
>   	if (ret < 0) {
> @@ -409,7 +409,7 @@ static int fsl_xcvr_prepare(struct snd_pcm_substream *substream,
>   	bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK;
>   	u32 m_ctl = 0, v_ctl = 0;
>   	u32 r = substream->runtime->rate, ch = substream->runtime->channels;
> -	u32 fout = 32 * r * ch * 10 * 2;
> +	u32 fout = 32 * r * ch * 10;
>   	int ret = 0;
>   
>   	switch (xcvr->mode) {