Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Thu, 23 Nov 2023 11:40:45 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Wei Fang <wei.fang@nxp.com>
Cc:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: enetc: add ethtool::get_channels support
Message-ID: <20231123094045.bjgo4aqwdydeirgs@skbuf>
References: <20231122102540.3766699-1-wei.fang@nxp.com>
 <20231122110120.crs4rh2utjweswsc@skbuf>
 <AM5PR04MB3139E96BF99E55E563EF71B888B9A@AM5PR04MB3139.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM5PR04MB3139E96BF99E55E563EF71B888B9A@AM5PR04MB3139.eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6D1e0xo9A84rMQ+yXbQdfbJ+heNOSUUlerEp5/1rll2u1bMURkG/LqXUaoc5?=
 =?us-ascii?Q?LZwZEXRgKCc/XXftVuOj591isd476JWtHpXbHY6JiTCE+cefcW+geRFZeC5B?=
 =?us-ascii?Q?gkPuKsoyH23cUC2pb+w8tn9paM2TZBsSN/ere+IJoH/lQQEmA8N27YpwHJ9g?=
 =?us-ascii?Q?xq5XB7pnVS0D7w0F20OhhKLYu0PXdocq8ZJjPV1V9KjEPmHF7yE+kKRMvMYj?=
 =?us-ascii?Q?AeCIdUaDVaHYBLvCtgKWPP2nsFbx5Gzh4G4hMt9/s0HRRpv0xYgtWcLYCxX3?=
 =?us-ascii?Q?7DZzrKNs7YBQ5dwez1h/0UQm0qNl+aTeCfYgR9LdCPHnlgKI+fTWOWCbtC68?=
 =?us-ascii?Q?aABAcArY6qI0nMsUNd7vwjaiKBrhj0hVVwDrkocmYKsGm9VJZkcAMtTnNMAN?=
 =?us-ascii?Q?UOO3+9Qn/olmPCZvyexL5s9ObGXUica4rZdwi+GaOpkw7qrSj7U0Ou9+G8Kp?=
 =?us-ascii?Q?EUHpjANDlUO98n4bbfUdaLw7KQHNsOQNnx4YlC9/5JcLoB2VMla/wPK8/fxn?=
 =?us-ascii?Q?VjZuZXnqmW4ntGL0zPGzxH7KxGgvQl2mChkQL6pwc8qwt3uV3M+Ig6FCE5+k?=
 =?us-ascii?Q?m0kaB6ZBVP7GqgKAxfMQmiIbA++mxpgdzP/J7Xvc1xZsdbntwsoVf73Eevhj?=
 =?us-ascii?Q?ENJf4Go/CMpfq+Y0aj+XUGgeF+4QpXBXKyuV+7xM8jm5uGxqpHCNOBvfJvZ1?=
 =?us-ascii?Q?SfFQ71/mEbrEl163lLVn1GbtEw07tUOfVkhVOKqWjzX9O9y4tavNQIiTDW1b?=
 =?us-ascii?Q?bryTojPRhUkeUg3eez1Sa/0R8mKXEAx0jfp0kAbY7JW5inZ9NqdXax3hNIm4?=
 =?us-ascii?Q?YIMQplsTBavrWI1wSXsjNcb5zLncnPfpL/2yxrwQvGCgCYe4g2vs5V0cCIiR?=
 =?us-ascii?Q?Ht90N0weX5bUE20wvBrkMzov8b6crLf2+l3zE8uFXSTb03o45Py9l1yY3s08?=
 =?us-ascii?Q?mknr6S//BofW8hC+nXFhjfoJNaECDQUpMpOXaZ4GN2Ywy1xQyooFc83QKgas?=
 =?us-ascii?Q?yo8fKou62Rt2U1yZSgDeMJBuzrVFzMDOwcPTETFtsQqX113m/HBjvOU1qbRv?=
 =?us-ascii?Q?cU+oxb3bKJtSmFu6NPpwckBHKV20GPxIA4hsEYeCJP/VjYLd4ByaYFjnNMXw?=
 =?us-ascii?Q?2u9TQU9UYkJsj1NUz/mwdL8AbDqA2j5dTapi1DpOzqTNnRV1TA6RdVOYnruh?=
 =?us-ascii?Q?HmSY7B9aNz01TwGxnj84ydbXQZA0nNrm2oxCYVGWm1p5HLio4eJCwvIp1rE0?=
 =?us-ascii?Q?D3dpdOD3uqO0bltUu40LUf2vinXpSeuOs1lt6maASNcyw+uNSkS2QiZGpu4U?=
 =?us-ascii?Q?4d4MVxsoktorVO2cQMCw0nujTJ4m5T4CnRXKNX5/OsWS54mx1dU8yki5UL9g?=
 =?us-ascii?Q?cFXcvlKKEow4+raYPxMz3BFWqd5E6I8bbkJY5z3hWks9cvAE0KFXrz/6mTJg?=
 =?us-ascii?Q?ZJB9RViBlBBBTV1k8Ey2Du53lzOJn+BQGkBrlgECEFfOk/OiKVYvp9A/AKQE?=
 =?us-ascii?Q?0aYnT4ur0dliW1oj24Y/FEP2UFO/QuSdoNgFfXtXEDB0rleX0bWsnWkOMne0?=
 =?us-ascii?Q?htnD3OaPtW75SMXOd+lMzeDX+V7H+Zq9yqyzAzzEwVeaIjsjqP5wbXtG7+8v?=
 =?us-ascii?Q?Uw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36c98aaa-528d-4575-0adb-08dbec08467a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 09:40:49.1281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rbeWIfrTDTOoDMEy6N5IaG6dv+/g8BydmemGoNeDY/6A0pMdQAmBgX5zFOhjpQ86rEz8M1ocLwGYEfmvicPY5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9391
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 01:41:57 -0800 (PST)

On Thu, Nov 23, 2023 at 04:09:57AM +0200, Wei Fang wrote:
> > I would suggest finding a way for the user space implementation to not
> > assume that ETHTOOL_MSG_CHANNELS_GET is implemented by the driver.
> 
> [Wei] IMO, the issue you encountered is that libbpf will perform an 
> ETHTOOL_GCHANNELS operation. The issue I encountered is that "ethtool -x"
> will also perform an ETHTOOL_GCHANNELS operation. Besides, There are other
> apps that do the same operation as this, so I think it's best for fsl-enetc driver
> to support querying channels.
> Because your patch is more reasonable than mine, I think you should submit
> this patch to upstream separately first.

The crucial piece you're omitting is that for ethtool -x, the "get channels"
operation didn't use to be required, making this new requirement a
breaking change. The interface between the Linux kernel and applications
doesn't do that, which is why it's preferable to bring it up with the
ethtool maintainers and the patch author instead of fixing one driver
and leaving who knows how many still unfixed (and also the stable
kernels unfixed for enetc as well).

To be clear, I won't submit the "get_channels" enetc patch for the RFH
indirection table to keep working. I might resubmit it for other
reasons, like when I return to the AF_XDP zerocopy work.