Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <92d95955f66098ce725729243251beacc2823a81.camel@redhat.com>
Subject: Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support
 for mirror
From:   Paolo Abeni <pabeni@redhat.com>
To:     Wojciech Drewek <wojciech.drewek@intel.com>,
        Suman Ghosh <sumang@marvell.com>, sgoutham@marvell.com,
        gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lcherian@marvell.com, jerinj@marvell.com, horms@kernel.org
Date:   Thu, 23 Nov 2023 11:21:36 +0100
In-Reply-To: <ee30eaa0-2a1f-4dc6-8e03-c2d993eb159a@intel.com>
References: <20231121094346.3621236-1-sumang@marvell.com>
         <20231121094346.3621236-3-sumang@marvell.com>
         <ee30eaa0-2a1f-4dc6-8e03-c2d993eb159a@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-11-21 at 15:48 +0100, Wojciech Drewek wrote:
>=20
> On 21.11.2023 10:43, Suman Ghosh wrote:
> > This patch extends TC flower offload support for mirroring
> > ingress/egress traffic to a different PF/VF. Below is an example
> > command,
> >=20
> > 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
> > skip_sw action mirred ingress mirror dev eth2'
> >=20
> > Signed-off-by: Suman Ghosh <sumang@marvell.com>
>=20
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

Thank you for your review!

Please, additionally try to trim away the irrelevant part of the patch
when replying (in this case almost everything). That helps a lot
following the discussion, especially on long patches, thanks!

@Suman: please retain Wojciech's tag on next revision of this series.

Cheers,

Paolo