Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <cf62fefa-c746-4d20-8845-38e3475f0ed5@intel.com>
Date:   Thu, 23 Nov 2023 11:34:32 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v1] net: stmmac: xgmac: Disable FPE MMC interrupts
Content-Language: en-US
To:     Furong Xu <0x1207@gmail.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Joao Pinto <jpinto@synopsys.com>,
        Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <xfr@outlook.com>,
        <rock.xu@nio.com>
References: <20231123093538.2216633-1-0x1207@gmail.com>
 <2c2d0641-002c-4ce6-9df4-bc633e602721@intel.com>
 <20231123182405.00006454@gmail.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231123182405.00006454@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y25RRVlMc2ExYXdiK3FKQjVBeHhxVlNhVUJQRGxLdWhlTVNTeHM1cEhUT1Z4?=
 =?utf-8?B?TXlGY05Id0taVnQ4Wk13NWdnSHg3Vk5uTWZOcm9Dck1jdE5pZlRRNFhJRzVD?=
 =?utf-8?B?M1M3alJpWnFsUFpROVRHWXJqQjY5Y3NLaHVKKzBkNzdPdVlLbHBVWnNhd25Q?=
 =?utf-8?B?b3FQditONXM3WlB1ZGZ5UWRiL1dVRHkyeGFVcGZVOUFVbE5zcnc1VWhsWFlT?=
 =?utf-8?B?OWJwbzBvUEtYOWJmZjRRL3V3alJMWmhoRU9IS0Y4cysrTGxSMjdocnJIbGs4?=
 =?utf-8?B?SFl3dEtDNzQ2RGRLdUdjSi9wckNFNGxaU2hhQXNmR3B2eklpR2ZkKzFmTkoy?=
 =?utf-8?B?SWxBT1NTMWZCWXNMZmVwZitDaUJKK00ra0lZaU1oQzZmTlVmNmFXWExvSHh5?=
 =?utf-8?B?RklHWlVydXpVK2t0TEZFb1d5c0VPWGVoUC9BSDY4M0NrelV3SEhaL0tWSUxC?=
 =?utf-8?B?R1pUVVNCc3ZweE1pbzhLSDFuaWtBa2pZS0RKc0RjR3VsQnB3SlJOaGxTaVEy?=
 =?utf-8?B?K0pDbDFLdXNuaFZOYVphRmdqeDZpOGVzZ1BkK2RQQ0pCVW5neWRqNVdsRERN?=
 =?utf-8?B?SHBib1BNeUd5QUdqMWFYVFdpd0Rha0dseEdLU2xnWmxBMzhSazByK1VNc3Zk?=
 =?utf-8?B?OUZwYWk3WG1SWU1MdFcyMkxOT3VGZHp4MHBwZlJma2VOZ3ZxNW5WSTEvU0cy?=
 =?utf-8?B?anF5czZMY0w4c1RpdXhTV3JTaCt3MllWYXlUaUtBTnhiTmI3aGJGL090MzQr?=
 =?utf-8?B?LzA1VHB2MmtqeStDN3NkNjNqVWM4SFNqMDFqNkJRZEVSVE9TTjc3SStKU2F1?=
 =?utf-8?B?b09wSE1RV2VzVFVZWjZuMzJ3dWRkaXFiRjQ5V0ZKa01TMEh4dlFtTUpycm9N?=
 =?utf-8?B?ei80YmhtWW9laTlWdU1LRXhmbjNDOEM4WDRGZVMwQ2tUVFJrdUZoWEpnMklJ?=
 =?utf-8?B?RlVMSWZZeUllQUFFQmtZdExPZW1Yd3VhRmExeHpiUnhIL2hqakY0bzcvTFZT?=
 =?utf-8?B?Q3RmeVFqU3BsSThIc2lRVVczMHpZUnI0c3JWbU1HdlZET010THh3RlJYZktz?=
 =?utf-8?B?cksrT2tQczgrRms2UnFsRjN6Y0FDVlUyd2p5Z0g4ZDQ0dWhBMWZPNHl4SjNm?=
 =?utf-8?B?WXA4TWJrMENsRUh3ZTN3TnFNM3BFQVlwaEd6emQydU5ZczJRbllKWkh2OXFu?=
 =?utf-8?B?MFV6dmVMRnYyaENhaCt4d3hwamowUjNDY2lzOUFPNTQ4UzJJZHJPSHdsMDNQ?=
 =?utf-8?B?MG5VZCt1WU9RZ09QV0lHeTVKRmxxV1JFdVIxMXc1TTR4alVGZnhnM1ByL3ZR?=
 =?utf-8?B?QVdsd2VMSEZVTzJxSVFlV2djVDMrbC9INjRpejdwZm9CNEtpVE1UQTRuMDVS?=
 =?utf-8?B?ZlA1YnF4QlJsV3dLNkorYlNBS2VGUGRRMWxkamF2WU1TbFR0NnJnQ0FXSmQz?=
 =?utf-8?B?MTM4dks3RHRiMmpZKzNUYXFhS0VPQ1BVc3RudThGYWNNalpUby9Xc2RlVDhX?=
 =?utf-8?B?OXRoaFVlVHNpb3BmK1M1MUsxeTE0TVJtUFFrSEtyUVN4bEUzcW1udUdrRlZk?=
 =?utf-8?B?WE9Ob2VucGQxNWl3bW83TmJqaUEwSlVjVlVTeFNibXY3ZEYrRnZhU3EyVk5B?=
 =?utf-8?B?Z3pXT09VMUV4aWRCSFljQnJGRkFtazEyS0k5SnhPdlZhajdwYkJ0S3JyMWxT?=
 =?utf-8?B?NnZxQTY3N21lWUNYempZeFphMFhja1dWNk1udCs5anVNc3krdTFqZDlqZ3dH?=
 =?utf-8?B?d2UzTzBJYmhVWm5YMk8xSmZ1bHRaM1dvdnhrbXZpVFJlNFh4UkgremJIbUVu?=
 =?utf-8?B?WFNHUUZtUSs2TnlCRWd2VjZ4b1RVYnBPK1BBaU5CUXNtdkxhVmxwajdVWmJE?=
 =?utf-8?B?Ukt2Q3drUDNKNTRWcmlEa0dkQStnZGIyeWp0WVoyeXY1T1MrUU41VjdhcS9X?=
 =?utf-8?B?Vjd3eUJnRmtkbWx4cXhmUjFuN3RLZndVN0Y0V1RmZXo1SitiS3J1Ylg5Ynlj?=
 =?utf-8?B?dE5XNVpHM1BjbVdvZzBZQldObkw4ZTBoUWhaRDFnQ3BKeWNFZm1rd081d3FY?=
 =?utf-8?B?cVAwKzVGSjFoL3diUTlweVRWQUJrVDJnMklhb2RuOHF0R2UrK3NpUjJicTZm?=
 =?utf-8?B?SERkNy9RRmVyMXh5N21IejZSRHF0WjFPRFJYRmE2QjJMd3djZUNmWDZIb0wz?=
 =?utf-8?B?QUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b11b7a4-c81d-4559-bf4b-08dbec0fcc23
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 10:34:39.8952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: quwIYAf3iaqf/oW8MRS8UTbHthXY2N4uUBHIJvrFQZr7ePWDa1tuyshJVPBeLQPX4l07OXKy+TNd3Oegqhc0ZjvujtTecsDAcGvU5vM8WQ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7436
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:34:55 -0800 (PST)


On 23.11.2023 11:24, Furong Xu wrote:
> On Thu, 23 Nov 2023 11:17:17 +0100
> Wojciech Drewek <wojciech.drewek@intel.com> wrote:
> 
>> On 23.11.2023 10:35, Furong Xu wrote:
>>> Commit aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts
>>> by default") leaves the FPE(Frame Preemption) MMC interrupts enabled.
>>> Now we disable FPE TX and RX interrupts too.  
>>
>> Hi,
>> Thanks for the patch, one question:
>> Why do we have to disable them?
>>
> 
> The original commit aeb18dd07692 by Jose Abreu says:
> 
>     MMC interrupts were being enabled, which is not what we want because it
>     will lead to a storm of interrupts that are not handled at all. Fix it
>     by disabling all MMC interrupts for XGMAC.

I would add this information the commit message.

> 
>>>
>>> Fixes: aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts by default")
>>> Signed-off-by: Furong Xu <0x1207@gmail.com>
>>> ---
>>>  drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
>>> index ea4910ae0921..cdd7fbde2bfa 100644
>>> --- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
>>> @@ -177,8 +177,10 @@
>>>  #define MMC_XGMAC_RX_DISCARD_OCT_GB	0x1b4
>>>  #define MMC_XGMAC_RX_ALIGN_ERR_PKT	0x1bc
>>>  
>>> +#define MMC_XGMAC_FPE_TX_INTR_MASK	0x204
>>>  #define MMC_XGMAC_TX_FPE_FRAG		0x208
>>>  #define MMC_XGMAC_TX_HOLD_REQ		0x20c
>>> +#define MMC_XGMAC_FPE_RX_INTR_MASK	0x224
>>>  #define MMC_XGMAC_RX_PKT_ASSEMBLY_ERR	0x228
>>>  #define MMC_XGMAC_RX_PKT_SMD_ERR	0x22c
>>>  #define MMC_XGMAC_RX_PKT_ASSEMBLY_OK	0x230
>>> @@ -352,6 +354,8 @@ static void dwxgmac_mmc_intr_all_mask(void __iomem *mmcaddr)
>>>  {
>>>  	writel(0x0, mmcaddr + MMC_RX_INTR_MASK);
>>>  	writel(0x0, mmcaddr + MMC_TX_INTR_MASK);
>>> +	writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_TX_INTR_MASK);
>>> +	writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_RX_INTR_MASK);
>>>  	writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_RX_IPC_INTR_MASK);
>>>  }
>>>    
>