Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <613da551-9983-4f98-b8c7-57bc16d68665@intel.com>
Date:   Thu, 23 Nov 2023 11:35:45 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support
 for mirror
Content-Language: en-US
To:     Paolo Abeni <pabeni@redhat.com>, Suman Ghosh <sumang@marvell.com>,
        <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
        <jerinj@marvell.com>, <horms@kernel.org>
References: <20231121094346.3621236-1-sumang@marvell.com>
 <20231121094346.3621236-3-sumang@marvell.com>
 <ee30eaa0-2a1f-4dc6-8e03-c2d993eb159a@intel.com>
 <92d95955f66098ce725729243251beacc2823a81.camel@redhat.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <92d95955f66098ce725729243251beacc2823a81.camel@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWwyNWlya2ZTWmIzV1YwSFY5SVpLa25XbzI0Q1J1OVNpeFpKWHM1cnJNUXRM?=
 =?utf-8?B?M1RUWndoWU5NWFJjTmk4anhSaU1MRGZWQzVTQTYyYXBuWkM1MFJQRStNTTRH?=
 =?utf-8?B?TTZySlYzTnVYaTZNTk52WE8xZ3NoV3pJSWFCWmRaUDdQblhkYUFnYSsrbU1J?=
 =?utf-8?B?dkRkcnYwbWZlSTRhWXc1K3pqNWt0c01Cak56UTZpdjMvYWgvMjlPWUxGbzMw?=
 =?utf-8?B?QVRTS3pEcUNxRzJISk1YTHBPOXIydDYrNW5OWXFQRUlydCttU0huc3lVUXB2?=
 =?utf-8?B?QzJpRkc0SENQdW0wTTl6cjJUdVp2YkpheTVvNnhFbnBLcWczYWJqVnFKbEMv?=
 =?utf-8?B?L2I3bWdod2JqaUVrN0Y4OEk4WlZtR3lDR0FMZ0NiSWtUMjU4cUFUeUVOUFRL?=
 =?utf-8?B?YnlEeEdaSjk5TUdlby9uaGUzNXMvMk1ORE5QWWUxYloxZlAwVjZ2c2I2anJk?=
 =?utf-8?B?SlNYenEzUGk0NjVyYVRlMHgwOWZoMlJtMVRCTEpmYmhJVjd0WGV5OVYrcGlp?=
 =?utf-8?B?cVNFQmZ6bVByTkhPY0NzRW5WLzlSdUNJQkVSSytkNFMzM2dIZ1F1eEQ5NFhU?=
 =?utf-8?B?NWZOSEpjajJoSi93bU9nbUFrZFJsQUxzN25DcHpoM1BsZzJ5d1hVQlMwWUJi?=
 =?utf-8?B?cWpLTHdNZ3V4dmFpZzlCN3hJZGp0bEJaazVnQlV2WlRFTEw3M0wvUUViUEZG?=
 =?utf-8?B?U3A5V3dXbFdWQnRtK010Ullld3VUSUZOU0d0RVRGeFk3SThTRG9qUGJUMTVs?=
 =?utf-8?B?RzNqUXQ0SzVBeCtZb3dvKzk0N05kd09kWnIvYzdlWUpnak81VmdDV3lSMUgv?=
 =?utf-8?B?bUhac3NzRy9nQ0YrZGwvUUtOUEp0UUI3eHB3M0w5aUlWSFd6eWlNMGxBcVM1?=
 =?utf-8?B?RXhVblNndVoxVEJYU1B3YU1ZcUVYT3BkNGpGZUZRQmNta2M1SEMrRGNmZFU3?=
 =?utf-8?B?dlRjOVRWWWN3di9tV2hPQ3VuRHh1L2Zkc1NXT0V5K1ZZOGhRM05KZmFJVDFT?=
 =?utf-8?B?M0NaTjNiVXFtQ0g4MEpnTWtXZGhKK1BQNXdkQzIyRDZ6NXBKZkpIc1F5elJo?=
 =?utf-8?B?UURoUE15aUlUZ3ZEbTdJUW1RM1hYV1NkeTVTMmwyZFkreUs5T2JvcXhjMVd6?=
 =?utf-8?B?bS92OUpGbmdJRWdURlBzdUNIdjdZVTkyNmQ4bzZ2YXJJQ0xXVDh6UTRmWWJn?=
 =?utf-8?B?UEtzN3oyczlOand5bUpxaENIRGRFVFVEdUU0Nysrc1dqMUFiSnIzeU9JZGk4?=
 =?utf-8?B?UnpwdXE4bnh4cmF6S2JyM3JyVlZLUEYxYkQ5Um1vUElTQ3cvWnppczdQWVda?=
 =?utf-8?B?dGxPOWlVWWJGSUMrNEVVQXhWVmtyc0wvc1NzcE1KWXNKaktaUzR0cXAyOTRs?=
 =?utf-8?B?Q1VLVlpIbSsvT0s4NGU2cEtMY1krTjYxNFM0dkc1OVNQdkVEaWlTSG9TQVhY?=
 =?utf-8?B?bGhqRWlQRFkvYXVheW5MS3FNRXJyY3RzVDhFT0VnR2dmWnNmbHVyU3ZyWW95?=
 =?utf-8?B?Y2cxcC9pd0FlQmRsdmRVS3NFbzZoVEppQVo3V0xXTnlzV09uZExYa2xVaWRK?=
 =?utf-8?B?SFQySGZ2YTFNL3R1ZFQzMVl5T2d2bXFTZ2NjbFl0RHRZSUJnazhSZkoxT2kr?=
 =?utf-8?B?KzVKa0tMNE5vRWFNU2owWjc5eUt2NTBBbVpOWmdxa2ZFTTNMNXhDWVcrVkI4?=
 =?utf-8?B?WkQ0WDJ5bjV2c0V1QXByZ3lvN1NUQmpCUHhDQjlnazZCVy80SGlHMHRqcGNr?=
 =?utf-8?B?cG11QlhyZVVqbThkUTJHSytMTHExaURXNDF5Ukg3RlRuMkFYekVoQjdwS2Ri?=
 =?utf-8?B?MzVWVzRWUHg4SkNrVXllOHhmZk1SY3lPZUp4S2hUYlc5UE9BcmsyTkhIWkFu?=
 =?utf-8?B?c2t0T1RQYUprc0JjMDhiMjlxWTJEelZhQThsWFNZY2puYVpSQWEzSXc4Kytn?=
 =?utf-8?B?Y1JTREJHbmhtYStUZUt1RkJib1ZPVzVid3dJYXNPVEZBenM1TFM4MWRaMFdR?=
 =?utf-8?B?c2RCbEhmRHFpc0tycCtONWF4Q2ZjMlRPamtDZk1BSEFxNVNCelBva3g2eEVK?=
 =?utf-8?B?bXNCeWZQTzNpYlc0dVB3MUhsaXRnWlRSRitqcXNpVllVVUsycjA0Y2k2ZU5P?=
 =?utf-8?B?aDVRdkpNWWRSc1d3U0ZjYWJDdzl5ZGNqWnRSekRNZEl0TXV6OUpJZFZZMnFj?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cecdb98-ed41-48cc-2813-08dbec0ff536
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 10:35:48.8256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wRp84kR2oZGSjndbr3MxTcsYAMQsNIPZ/JOW7ntayrw7tnX8i0QqPklcwA+FN3qiOQrddPNyQJ8kKeJrwI5J5RKk0NQSoXky/k9c57hVtJk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7436
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:36:07 -0800 (PST)


On 23.11.2023 11:21, Paolo Abeni wrote:
> On Tue, 2023-11-21 at 15:48 +0100, Wojciech Drewek wrote:
>>
>> On 21.11.2023 10:43, Suman Ghosh wrote:
>>> This patch extends TC flower offload support for mirroring
>>> ingress/egress traffic to a different PF/VF. Below is an example
>>> command,
>>>
>>> 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
>>> skip_sw action mirred ingress mirror dev eth2'
>>>
>>> Signed-off-by: Suman Ghosh <sumang@marvell.com>
>>
>> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> 
> Thank you for your review!
> 
> Please, additionally try to trim away the irrelevant part of the patch
> when replying (in this case almost everything). That helps a lot
> following the discussion, especially on long patches, thanks!

Sure thing.

> 
> @Suman: please retain Wojciech's tag on next revision of this series.
> 
> Cheers,
> 
> Paolo
>