Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp238575rdh; Thu, 23 Nov 2023 02:39:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IESVDMPB6eXwi4nYVltprManN5S7hkPg9jHTfSP3aY/VYWYhkUtwxT3T7SQFDgRtMqx+11O X-Received: by 2002:a05:6871:728d:b0:1ea:fd94:965 with SMTP id mm13-20020a056871728d00b001eafd940965mr6922769oac.24.1700735963247; Thu, 23 Nov 2023 02:39:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700735963; cv=none; d=google.com; s=arc-20160816; b=Lra48W6NLn5ItwbHqSrvMZaL5Jis2mDdpeb3JzwH5zdueSz/QCEEh0MUzuJW37fo2m d5sIyzcG33+PlY/BRjd1q9KCXoU+W5D+NIqzZ+Qv6dv9LeNoc9JUsiburC8XD9U+h7Ww IG7wQdHdHw/gjaGeudB879H30mFxzrm5Izwi8BOYl+HFMUJ2fp5RgwsiClA/zbxB6OKq iqvUjubw4b5SP1t+Kl1zLufz4A1teNGkqAjII9w8YgIH3YQoKWC24GAaxSjt7+ChqY1/ XBYl21fYxKLnthUyl31LVt1rm6jsAeCD9bqwF8Y3iqWcLKwfs3NeOorzysVxYFrZoDwL HJTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=U6Px+KLcHc3h82TnRgl3RKH5L5GxILRYxqhX4p+qe1o=; fh=zW4ATFOsXVZw320t0ZsA8qi1MgRFTN/5KKIB0IpGz/E=; b=buh5ssv0WqApRXXpTiAhjfHV5VBckKpe7rhaLh0GiRh8iX7j4//3LAyANirZbF0aSM M6R5kYU9wst1REmxAlsqvLiXD0E+gz4MS/BUPXmmSp3to/wm5cJm225aTd5D8TkKFcHu ahsRszfZj0atH043tLMFcDLBcMdrNkkQywk0eN7U7JoLc/EfuL2WVeAyD/uD2ZNicGk9 BQb5+rXVzn2a42DIsw3T9X4HSJpncQ9OLi1GD7gAxshi47sh3lXHWMBmXLDMOD4hpEfB 86P6GL19X+STG3HpC0J33goXSDgd/uny5tjb8IAdzyz4CFdqiLr4PLLFBOLvv9DtKtUM kekw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eqIm9pmM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id y23-20020aa79437000000b006cb90b336dcsi980173pfo.267.2023.11.23.02.39.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 02:39:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eqIm9pmM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id F02D2832541B; Thu, 23 Nov 2023 02:39:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344701AbjKWKjH (ORCPT + 99 others); Thu, 23 Nov 2023 05:39:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbjKWKjE (ORCPT ); Thu, 23 Nov 2023 05:39:04 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38103D4E for ; Thu, 23 Nov 2023 02:39:11 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 729FDC433C8; Thu, 23 Nov 2023 10:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700735950; bh=V8QlEn1tY3YvzwuTK49GT3h8aeTQCvMtxhMSaCgWClk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eqIm9pmM3F/b/jxXxLJElshcaHgClNYbZt3mJ2gBxmGQnlqYalp/F0AIV0SGbwoqS 3xh2DhJnCWYbsf4/bLwj2OmdQq/6rsPhS4XyKAbmcTHSUsWGZ/Do/ygrojCFu6m5f6 mEQB4khLIXD+iTxSU3Na+u+0YmiIKfbVKwYqlakSRDKz8k3S5vKgnvMdJ/IkITLvG3 sWO7jv+kIIQc5vLuks1VZJpk+o+tKNcGh+yxn63IEJEAQgT5ORC6Q481mamyJqeHv9 8FiZIyj7Wyl2gTM+yt3VvPhh/lhiOrmugacrlTbnOc47hy4AOPSvWxGBAdAsEqH/0z qP0pZ98ZZoP8w== Date: Thu, 23 Nov 2023 10:39:06 +0000 From: Lee Jones To: Peter Ujfalusi Cc: tony@atomide.com, robh@kernel.org, wens@csie.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: twl4030-power: Revert to use of_match_device() Message-ID: <20231123103906.GE1184245@google.com> References: <20231029114909.15652-1-peter.ujfalusi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231029114909.15652-1-peter.ujfalusi@gmail.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:39:21 -0800 (PST) On Sun, 29 Oct 2023, Peter Ujfalusi wrote: > The core twl chip is probed via i2c and the dev->driver->of_match_table is > NULL, causing the driver to fail to probe. > > This partially reverts commit 1e0c866887f4. > > Fixes: 1e0c866887f4 ("mfd: Use device_get_match_data() in a bunch of drivers") > Signed-off-by: Peter Ujfalusi > --- > drivers/mfd/twl4030-power.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Rob, does this work for you? -- Lee Jones [李琼斯]