Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <24e4edf1-14e3-460a-bc33-0b2177a49ee6@intel.com>
Date:   Thu, 23 Nov 2023 11:45:23 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [net PATCH 1/5] octeontx2-af: Adjust Tx credits when MCS external
 bypass is disabled
Content-Language: en-US
To:     Geetha sowjanya <gakula@marvell.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <kuba@kernel.org>, <davem@davemloft.net>, <pabeni@redhat.com>,
        <edumazet@google.com>, <sgoutham@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>
References: <20231123055941.19430-1-gakula@marvell.com>
 <20231123055941.19430-2-gakula@marvell.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231123055941.19430-2-gakula@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHZXd28xZk45Z1RaaDJmZGNvU29xbGQ3L0trZytIYlZoYzlVMmxlaTNIS1FI?=
 =?utf-8?B?TFVVTEZpbFVnWXJScVY5Ymsrd21WdG93NHI3d3YrMDJ6c0NNMml0c1p1S3Bi?=
 =?utf-8?B?bTg2aFBvVXhzRU1PMXpyNFRyTnZUMkRkc1VwU1grS2ZlRENSWC9OWlFXaFQw?=
 =?utf-8?B?dWRNdy8wdjB5ZVVjTWpYZ0I3TC92ZTNrL1NVd2xXL0I3Q3ZuUjhIeFQ1b1RD?=
 =?utf-8?B?STZoNm5mYWM0TUxlY0VGMXJ2QXlPVzlUUVc0ZE1TaG00RnB5cUVXZXI3eDV4?=
 =?utf-8?B?dnd5SkVsTzRCRTMrbHhVNXk2OTNrVm5xYWt6enFEZGk5VUtyV0R0ZXQ3R1ky?=
 =?utf-8?B?OEZuQ2NTYWdmLzVnTVUrWFF4K0RyV0p0V3oxTGFKd3JWRXk5OWdvTDBtV0Nn?=
 =?utf-8?B?OHhCbWlSTUR4RDdiWGFZRTJSamZYbC9iRm50Tk5HRXdDb3IraXpVN2g4YzBu?=
 =?utf-8?B?UFJJY041NjJITnJ5VWtKb3RyYUlqNWZ3ZUlzWkREdzVHdTJPOUVteWNuQVF1?=
 =?utf-8?B?UkhDb3pSUDh3d3JNUzN2NW5CRmdlRkJqYU43b0l4OXlYSnRDOG1RWlpLTWxy?=
 =?utf-8?B?QkRORjMxdmFyYXhqQUtBb1BmMHloWXV0MVZxSnhBNXBPQnNjenJuZW5Cblk3?=
 =?utf-8?B?S21ybkU4b0k3R2tacEl1cTA4L0k0K1hmNlhSMFpld040UTJ6ZWhsUlVPUjQv?=
 =?utf-8?B?SUJwMm93TUdZdHE3Rm9VK2pONGlvUENhL0l5K2JpaVV0bDI5dHNJTWlFRk92?=
 =?utf-8?B?TlUrV0RUeGw3RFVwQ1RpZXJTazl2WjZDTUFFVkQ3STFuL1pGZCtqNEpZVUdo?=
 =?utf-8?B?c1hPOGowdVlZWTRvdVBaTG1TVzZ3cUVIT2pmTncvSVhWWnBpUEUrOXBLVjFU?=
 =?utf-8?B?a0kxdUhtUkdFLzk5cjFCQkdmSnVxLzNacmgwbXZBT3RkaTFIQjdMT1Y0Q1k2?=
 =?utf-8?B?MEZuR3pJbXpWMU1ZYTZSQWtGQkpDcEIyc29ocEN0OVZJbTM2cUVSd0NKOTVK?=
 =?utf-8?B?Q29md3JPNnFqUDFvaE02U0J1VHVFMzMybERIcHV2NDh3WW1qWHJYZGNPRVBN?=
 =?utf-8?B?RHZVWWxOMFBpakpxTHI5eklVMHM3U004RU1MZEFaTWNuck0wZk1sVnoyZ1dR?=
 =?utf-8?B?SlduV3JwOFovNnV5aHlaOFE5NEFBT0ZTYlhVdHpBYUtvN05zUnpFeEJObThs?=
 =?utf-8?B?UERFbStHV2tPbStwRmt2aE0yTW4rVVM1eHRpcllmczAwMGdMdkQyZ3paZzNO?=
 =?utf-8?B?NEZwSnB6eW8rUXpYSG5yTVNjOGx4OUpROWtueUFYRmEvUHNTT2I2S0hscHVX?=
 =?utf-8?B?eVpDa1BEdFBSYUZvS3A3VjdtN21rUjJOZ2lJQkkzaG8weGZ6WjBXRGF0eFV1?=
 =?utf-8?B?bTduaEhCcnVHQjF3S2pmTGJZM1hwdWF2cHBNaGRmVmFSOXZDRVF4ZldPaHVT?=
 =?utf-8?B?SmlSekhvNHFQRm00YU8ycTNTTjMzNGtOSDQyOWV4NStNaHZKNEVDdEhYR3Bk?=
 =?utf-8?B?MWF5MjJ4di8yclhzVUdWM1hNRG9wWStieWhKeXg1K3I3MlN4NVFWaHliWE8w?=
 =?utf-8?B?anZDYVhoZVBHR0pmakdkWHpOOFhLSHNScHBvcnAzaHEwc0xGQndQV25zY1NO?=
 =?utf-8?B?Ym15L1BxTERvVStYTEJnamU0VmpzU0k4MTYrakxnRmpwME1Yb0ZaTDFmckZn?=
 =?utf-8?B?Q3FDdUQ0bExSS09Hd0tkYnFLc1dXZkRpTlA2Rmc5SDFnTHE0QkxlOFQyQUlu?=
 =?utf-8?B?bGJVMklEaDcwTmVDK1p1U0t5YlRXWlNJZ3AwWTRBTG5IN1lGdWlYZGl1NStD?=
 =?utf-8?B?L3BveHdodUtTZHRuc0t2MTZ6ZTZ1M2N1dHBOYndWQngrbCt1R0xWTy9VQ01j?=
 =?utf-8?B?bWw2aUFyby9kdElMelZoTWJGZTBLNFVLdnM5NmVJeSt5VHVjTXhaKzA0RmZY?=
 =?utf-8?B?c0I1ZEdlTnNLUXk3T2tqbFc5bFN3QVRiSk1UWSs3UlFUQTYveDloUWltMG9P?=
 =?utf-8?B?YlpqZHFqdzFmVG1FY2krc0FZbC9BVmsrUFJMUUtqV2RVTk9zU0V6YkU1OHQ3?=
 =?utf-8?B?WkkvclFZVTZvRTBUa0I0bnYzRVE2RDNsemRmMFhUenczd243Wi84Q1B6Nzdo?=
 =?utf-8?B?T0FpOEN2elFpTGVFbTBtMzZkNWtjRXlOT2ZKOFZVL2c4bTZxSkUzM3lYL2hi?=
 =?utf-8?B?dkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d322791-e439-4b29-fee8-08dbec114f19
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 10:45:29.5535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MS1xQqVfWVC8DOYThVwjvjGCpBT1a4pLAXSyIx7TJy+vO/lGv6ICrMVIvJuYWLCoxGGvOe9AzScnIUYWSEgRiU5srecCvJPri9v7CPF8mD0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7311
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:45:44 -0800 (PST)


On 23.11.2023 06:59, Geetha sowjanya wrote:
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> 
> When MCS external bypass is disabled, MCS returns additional
> 2 credits(32B) for every packet Tx'ed on LMAC. To account for
> these extra credits, NIX_AF_TX_LINKX_NORM_CREDIT.CC_MCS_CNT
> needs to be configured as otherwise NIX Tx credits would overflow
> and will never be returned to idle state credit count
> causing issues with credit control and MTU change.
> 
> This patch fixes the same by configuring CC_MCS_CNT at probe
> time for MCS enabled SoC's
> 
> Fixes: bd69476e86fc ("octeontx2-af: cn10k: mcs: Install a default TCAM for normal traffic")
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Geetha sowjanya <gakula@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/mcs.c     | 12 ++++++++++++
>  drivers/net/ethernet/marvell/octeontx2/af/mcs.h     |  2 ++
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.h     |  1 +
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c |  8 ++++++++
>  4 files changed, 23 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> index c43f19dfbd74..d6effbe46208 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> @@ -1219,6 +1219,17 @@ struct mcs *mcs_get_pdata(int mcs_id)
>  	return NULL;
>  }
>  
> +bool is_mcs_bypass(int mcs_id)
> +{
> +	struct mcs *mcs_dev;
> +
> +	list_for_each_entry(mcs_dev, &mcs_list, mcs_list) {
> +		if (mcs_dev->mcs_id == mcs_id)
> +			return mcs_dev->bypass;
> +	}
> +	return true;

If there is no mcs dev with the given id it means it is bypassed?

> +}
> +
>  void mcs_set_port_cfg(struct mcs *mcs, struct mcs_port_cfg_set_req *req)
>  {
>  	u64 val = 0;
> @@ -1447,6 +1458,7 @@ static void mcs_set_external_bypass(struct mcs *mcs, u8 bypass)
>  	else
>  		val &= ~BIT_ULL(6);
>  	mcs_reg_write(mcs, MCSX_MIL_GLOBAL, val);
> +	mcs->bypass = bypass;
>  }
>  
>  static void mcs_global_cfg(struct mcs *mcs)


<...>