Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp246038rdh; Thu, 23 Nov 2023 02:58:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHelD1ZZGZhWVJuZWv83Tbe+Y0VBqhS1LlndsduFhYUu9PLrEQJMzcfZ67uAboxsrBfVnsX X-Received: by 2002:a05:6870:498e:b0:1e9:b025:cf88 with SMTP id ho14-20020a056870498e00b001e9b025cf88mr7354134oab.36.1700737121552; Thu, 23 Nov 2023 02:58:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700737121; cv=none; d=google.com; s=arc-20160816; b=GOTjBDLDzU/J5QMljbnocHmOwDST9E7j9VNnKu4aSC5BpthuiMugpteMKjHllfyhFi 2ZQlMV02ZJcqXHDZ4GqzC1U5ssQmBjQytZFiExX71209VJ23xzVhgzrz2/aEL2ppLcc4 XD0+yiF4enxEI4bl1XuZjo1IgCfoHENuzSu39eDJHJE60cycyPW3zPpBTpeIT6i+qa7G abqx2ZdNvPgwGsoAJkqy9IsBUmzvp02kkUuae6Mcm5PEUaAMPp59EjPiOLp6iJ5vTz72 OU8wp1PVKVxJGhIVS6Nieh6ZgzS799kFtpuMi5c2xWxnaIfhGltxnGBhLxHnjlU5USu5 iN+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=+y8GqhplESEfvOMr6yusQxqrSvhQKePmum3wvwP/q1E=; fh=avv5ZWf0OA719V1hIAAWoiP5oH+YSehAUaRew1Vcirw=; b=tG+jqfzdL2hgtRw0jyiQpbAgGmCxquuf0WTl6LkFK7MDUscRmV8zZG0hlnKXNO911E WG6tcQwhKpJNNOocAci8gc+lxd3Gb72crL2SlSLMeHfogdCnhAhD1cpynHZ3aZhlKC/X QsU8CcRHTMVzm82gpO2zjUxyzJbf6W/sOIAq2jXi4PrlH31zQLbkPrKSwSREh81RHKPc mgXbJsLaXZFjOH81JmL2npsNhxPgcK+i7xLV/uQsSMGwf7fqwonn2K0dORc8+p/mowOB y2b5Uxjzy6D4W5ORWVPN9tFjx0ZxfKDleoN0tSANHbS2Dvuk0h4zqTLW9Fbua6sOE5UT aEJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M1f+F4tC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id y21-20020a056a00191500b006b7b42fe43asi1063860pfi.185.2023.11.23.02.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 02:58:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M1f+F4tC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E2FF281972E0; Thu, 23 Nov 2023 02:58:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbjKWK5i (ORCPT + 99 others); Thu, 23 Nov 2023 05:57:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233080AbjKWK5g (ORCPT ); Thu, 23 Nov 2023 05:57:36 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B96091BE for ; Thu, 23 Nov 2023 02:57:42 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-32fdc5be26dso400763f8f.2 for ; Thu, 23 Nov 2023 02:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700737061; x=1701341861; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+y8GqhplESEfvOMr6yusQxqrSvhQKePmum3wvwP/q1E=; b=M1f+F4tC+fWJAryB96uDHg2geNecTmnMExPz8MIrPmuLMFCylEwamwjqunb0yvNRhp Ak93byBgqLYn6TVylsJ87M1IgQ0Ip6xx/GNoZRRodfu+ztpJEG5nSZaJ3MCm96IPVvBE lQauoS0xY3+Lukg2WczKv/9g3QJYjPlUV6SUSJ7LgAgpY6muiXX63ScZXruPffua9iBa IpnbL+yKl4+n64qKrg+6SuMyaaKgocEcCbvJc71EJV1xpbb3Mj/OnsqFDO6Cqilmpi5D QFqbXOiOMrq5FWsRc2ev3Z1WschIrkO54Idb4wFs8CE6a1OSU1Q5oedrt8AVRyezRyay lWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700737061; x=1701341861; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+y8GqhplESEfvOMr6yusQxqrSvhQKePmum3wvwP/q1E=; b=Ftzw1xqIor+AJ4IDBaNoVoZi2w/sqMuZlx6eP7P7c8PbD1apWI+viPHeFLGM5x9G0Y vQP4KNazV5Hp/6wbHJyv/zPAhyVMLXoumGkT8BlPeWNwSHFRxpKGCb4KcqBkQG7i0zT1 Kbhhkn13ziGAjo3wuI9C4C+JYDXVckeiSgH+RKJb2C/VXfPYceCL/HHaSby0deMVzM8K GBi3g/GyM5AQcj5vmuD3KGBeyrQf+NCmrOPGT5Da1EVbyRonsF9oT2r/tgCuzUF65BkA A0KvJzi8NdO64TBVWAKvglO0qE4PzRItzG5jkvygDOleORkeyr7YM9fCFbXLnWpwhLFz x2ZQ== X-Gm-Message-State: AOJu0YyiHEJCkNisPe5Tf+Sesih+pU73o37VdjQwLQ4pM9hzi3HLeeln yXqcbKoQfO+IgAVT9M/nncWJqA== X-Received: by 2002:adf:db02:0:b0:332:cc85:70ce with SMTP id s2-20020adfdb02000000b00332cc8570cemr2239543wri.33.1700737061193; Thu, 23 Nov 2023 02:57:41 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.100]) by smtp.gmail.com with ESMTPSA id c11-20020a5d4f0b000000b00332e67d6564sm185067wru.67.2023.11.23.02.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 02:57:40 -0800 (PST) Message-ID: <2bf64582-b7c6-469a-858a-f83b2d50f12a@linaro.org> Date: Thu, 23 Nov 2023 11:57:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/2] soundwire: bus: introduce controller_id Content-Language: en-US To: Pierre-Louis Bossart , alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org Cc: tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, Bard liao , Jaroslav Kysela , Philippe Ombredanne , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Vijendar Mukunda References: <20231017160933.12624-1-pierre-louis.bossart@linux.intel.com> <20231017160933.12624-2-pierre-louis.bossart@linux.intel.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231017160933.12624-2-pierre-louis.bossart@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:58:03 -0800 (PST) On 17/10/2023 18:09, Pierre-Louis Bossart wrote: > The existing SoundWire support misses a clear Controller/Manager > hiearchical definition to deal with all variants across SOC vendors. > > a) Intel platforms have one controller with 4 or more Managers. > b) AMD platforms have two controllers with one Manager each, but due > to BIOS issues use two different link_id values within the scope of a > single controller. > c) QCOM platforms have one or more controller with one Manager each. > > This patch adds a 'controller_id' which can be set by higher > levels. If assigned to -1, the controller_id will be set to the > system-unique IDA-assigned bus->id. > > The main change is that the bus->id is no longer used for any device > name, which makes the definition completely predictable and not > dependent on any enumeration order. The bus->id is only used to insert > the Managers in the stream rt context. > > Reviewed-by: Bard Liao > Reviewed-by: Vijendar Mukunda > Signed-off-by: Pierre-Louis Bossart Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof