Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Zhao Ke <ke.zhao@shingroup.cn>
Cc:     npiggin@gmail.com, christophe.leroy@csgroup.eu,
        fbarrat@linux.ibm.com, ajd@linux.ibm.com, arnd@arndb.de,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, shenghui.qu@shingroup.cn,
        luming.yu@shingroup.cn, dawei.li@shingroup.cn
Subject: Re: [PATCH v1] powerpc: Add PVN support for HeXin C2000 processor
In-Reply-To: <2023112317-ebook-dreamless-0cfe@gregkh>
References: <20231123093611.98313-1-ke.zhao@shingroup.cn>
 <2023112317-ebook-dreamless-0cfe@gregkh>
Date:   Thu, 23 Nov 2023 22:02:35 +1100
Message-ID: <871qcgspf8.fsf@mail.lhotse>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Greg KH <gregkh@linuxfoundation.org> writes:
> On Thu, Nov 23, 2023 at 05:36:11PM +0800, Zhao Ke wrote:
>> HeXin Tech Co. has applied for a new PVN from the OpenPower Community
>> for its new processor C2000. The OpenPower has assigned a new PVN
>> and this newly assigned PVN is 0x0066, add pvr register related
>> support for this PVN.
>> 
>> Signed-off-by: Zhao Ke <ke.zhao@shingroup.cn>
>> Link: https://discuss.openpower.foundation/t/how-to-get-a-new-pvr-for-processors-follow-power-isa/477/10
>> ---
>> 	v0 -> v1:
>> 	- Fix .cpu_name with the correct description
>> ---
>> ---
>>  arch/powerpc/include/asm/reg.h            |  1 +
>>  arch/powerpc/kernel/cpu_specs_book3s_64.h | 15 +++++++++++++++
>>  arch/powerpc/kvm/book3s_pr.c              |  1 +
>>  arch/powerpc/mm/book3s64/pkeys.c          |  3 ++-
>>  arch/powerpc/platforms/powernv/subcore.c  |  3 ++-
>>  drivers/misc/cxl/cxl.h                    |  3 ++-
>>  6 files changed, 23 insertions(+), 3 deletions(-)
>> 
>> diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h
>> index 4ae4ab9090a2..7fd09f25452d 100644
>> --- a/arch/powerpc/include/asm/reg.h
>> +++ b/arch/powerpc/include/asm/reg.h
>> @@ -1361,6 +1361,7 @@
>>  #define PVR_POWER8E	0x004B
>>  #define PVR_POWER8NVL	0x004C
>>  #define PVR_POWER8	0x004D
>> +#define PVR_HX_C2000	0x0066
>>  #define PVR_POWER9	0x004E
>>  #define PVR_POWER10	0x0080
>>  #define PVR_BE		0x0070
>
> Why is this not in sorted order?

It's semantically sorted :D

ie. HX_C2000 is most similar to POWER8, but is newer than it.

PVR_BE is out of place, I'll fix that.

cheers