Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp257462rdh; Thu, 23 Nov 2023 03:17:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjkxJDmE/E63r0xNF5dPH8QwSDpQlLMZUPwJfd0SslOFMl0eopfc1eavHv2RpDbKKhesRm X-Received: by 2002:a9d:7304:0:b0:6d7:f8bb:e712 with SMTP id e4-20020a9d7304000000b006d7f8bbe712mr1916379otk.30.1700738233852; Thu, 23 Nov 2023 03:17:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700738233; cv=none; d=google.com; s=arc-20160816; b=Gq+LL5bz+fVZ7yws5hQ0+N75MoL9F14lgZ77HooPP3vfM09Is+wGTOrv4huamkjDCd IkwFmzY+RGXCnwJW4nwrCzIfdvyyWosXgWoVfZwVhmdiZYmEx65EaH/lyJdq5Ms0WKHA mX+a0Je7ArCbz9F9AT473gprqg7RZqe5iYt//3uB7cB1sp19B5W/DOVO+tLeFcbRVmn3 iyH9P6duKBqFXA3f45TZPyeiAFd3JF7eZLnWzcTowsG7fFcIhxJR+I+tgrpxXXHQxKGE PCwb7bZJ/B4IB9xd3465QocHWs6M1AvVWe9UkUMThgaJ651gZIaQWAyFwP5Gn1Ikxpn/ fP/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=QISNQAMwiLqKXUEJX/KgzGCN42/XrU7M/PnZ1pExu8Q=; fh=9ElfeizWjlEJ36CPXA10IkpCA8SkWRjxtOi3xrIBLpA=; b=eN7lSt9U5hyKrLLRjAs1YCD3tBzSNzDFUO92jfyvUNGzgBtNgalDXoA7rtPrxEjMLx hf7EhmMdaal755eDE+Dwrhr++v3/VUt8kfEQa5ramVHoCNzjnw6W1LoLDYakZvKVElzO WPGl5HY7kxdh+EEGf23GeTzkC+K1mbfORiscdIUeHHyglB9aiVFyCsY65eRNfCDWk5Tk Q64G6RF+eUca1o+frmr98ToIcvezCRKpIG8FJV5afpDgHW8STbbB3jYCAmFf2KpuL5kn NdeiauG2k1ZNcKPPI8ga6jFaFtN8i1xN5P1sCiMKhDVPgD7nRoxPbYMVFEtX8wB+9Vr9 41GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UDiaiX7C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id t11-20020a65608b000000b00573fc592e9dsi1089097pgu.848.2023.11.23.03.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 03:17:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UDiaiX7C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8B172803DCC6; Thu, 23 Nov 2023 03:17:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344961AbjKWLQ6 (ORCPT + 99 others); Thu, 23 Nov 2023 06:16:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344857AbjKWLQ4 (ORCPT ); Thu, 23 Nov 2023 06:16:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC50B1AE for ; Thu, 23 Nov 2023 03:17:02 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74721C433C8; Thu, 23 Nov 2023 11:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700738222; bh=+BWfhELumSEtfousUaAup9SYNDzK54Uyof1kF/79eoU=; h=From:To:In-Reply-To:References:Subject:Date:From; b=UDiaiX7CjY/TlQUKcn10WKxAT+dmpvmEiNN96cIRA9R7Inlq99FKeX8v/ljRoDr4C u1DP8+4GTMbImP85+X7oK1v94u5r1VIb5nUVcXSK9rp8G3lnNHZ0vE/IisWFbA5mHw TSdBSK2zy+PgkENdQQtLaBAA6UZTcgj8dPGjFyOtJoMvY/ICGfBGuOhLfXrJ/fXaOV GWo+PoUkr2f7flAvRqKxzj73KA4Jlhy6Eh/NktCc0UG6Q6AlbDndXFtU3kMbQsP6OF KYZZTSc0FlSdTihUetn/YQL6Q08KEwRlrX+gdsSssNhSKEjzw8q3fDqehCF7XyM9/q rit5+BKWBwvaQ== From: Lee Jones To: Jarkko Nikula , Chen Ni , linux-kernel@vger.kernel.org, Andy Shevchenko In-Reply-To: <20231106184052.1166579-1-andriy.shevchenko@linux.intel.com> References: <20231106184052.1166579-1-andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v3 0/2] mfd: intel-lpss: refactor PCI probe and common IRQ check Message-Id: <170073822119.1252468.18122321322926530061.b4-ty@kernel.org> Date: Thu, 23 Nov 2023 11:17:01 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 03:17:11 -0800 (PST) On Mon, 06 Nov 2023 20:40:50 +0200, Andy Shevchenko wrote: > The PCI code can be refactored to use respective PCI APIs instead of > direct dereference of struct pci_dev members. > > With that, we may unshadow the error code that is promoted in the irq > field of info structure. PCI core shouldn't propagate 0 as a value > there, and in case it happens it reveals a bug somewhere else. > > [...] Applied, thanks! [1/2] mfd: intel-lpss: Use PCI APIs instead of derefereincing commit: e6951fb7878751aba4c147f1f206a2cbc05d1b9f [2/2] mfd: intel-lpss: Amend IRQ check commit: ec791121b8ace33d2251b6c7a4d11a231ee51c05 -- Lee Jones [李琼斯]