Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 23 Nov 2023 11:17:51 +0000
From:   Lee Jones <lee@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Chen Ni <nichen@iscas.ac.cn>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mfd: intel-lpss: Use PCI APIs instead of
 derefereincing
Message-ID: <20231123111751.GB1243364@google.com>
References: <20231106184052.1166579-1-andriy.shevchenko@linux.intel.com>
 <20231106184052.1166579-2-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231106184052.1166579-2-andriy.shevchenko@linux.intel.com>
Precedence: bulk

On Mon, 06 Nov 2023, Andy Shevchenko wrote:

> We have a few PCI APIs that may be used instead of direct dereferencibg,
> Using them will also provide better error codes.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/intel-lpss-pci.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Please use spell-check on your commit messages.

Let's not get complacent.

> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index ae5759200622..cf56cd3a40ee 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -37,13 +37,17 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
>  	if (ret)
>  		return ret;
>  
> +	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> +	if (ret)
> +		return ret;
> +
>  	info = devm_kmemdup(&pdev->dev, (void *)id->driver_data, sizeof(*info),
>  			    GFP_KERNEL);
>  	if (!info)
>  		return -ENOMEM;
>  
> -	info->mem = &pdev->resource[0];
> -	info->irq = pdev->irq;
> +	info->mem = pci_resource_n(pdev, 0);
> +	info->irq = pci_irq_vector(pdev, 0);
>  
>  	if (pci_match_id(ignore_resource_conflicts_ids, pdev))
>  		info->ignore_resource_conflicts = true;
> -- 
> 2.40.0.1.gaa8946217a0b
> 

-- 
Lee Jones [李琼斯]