Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 23 Nov 2023 11:46:05 +0000
From:   Charles Keepax <ckeepax@opensource.cirrus.com>
To:     Lee Jones <lee@kernel.org>
CC:     <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: cs42l43: Correct SoundWire port list
Message-ID: <20231123114605.GQ32655@ediswmail.ad.cirrus.com>
References: <20231113150220.1472294-1-ckeepax@opensource.cirrus.com>
 <20231123113055.GE1243364@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231123113055.GE1243364@google.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Thu, Nov 23, 2023 at 11:30:55AM +0000, Lee Jones wrote:
> On Mon, 13 Nov 2023, Charles Keepax wrote:
> >  enum cs42l43_sdw_ports {
> > -	CS42L43_DMIC_DEC_ASP_PORT = 1,
> > -	CS42L43_SPK_TX_PORT,
> > -	CS42L43_SPDIF_HP_PORT,
> > -	CS42L43_SPK_RX_PORT,
> > -	CS42L43_ASP_PORT,
> > +	CS42L43_DP1 = 1,
> > +	CS42L43_DP2,
> > +	CS42L43_DP3,
> > +	CS42L43_DP4,
> > +	CS42L43_DP5,
> > +	CS42L43_DP6,
> > +	CS42L43_DP7,
> >  };
> 
> This is starting to look a little redundant now.
> 
> I'm not sure if this is better, but it sure takes up less room:
> 
> #define CS42L43_SDW_PORT(port) port
> 

Sure, I think that is better. Will respin the patch. I mean I
guess I could also just drop the enum/define entirely and just
use the port numbers. But will assume you prefer the define
unless I hear otherwise.

Thanks,
Charles