Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp298578rdh; Thu, 23 Nov 2023 04:30:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4Ia+XYVHL2/C8D7tKal7b3g8M4mUklMZ0fg5IjEKFq00qQCXvp5oDhwTNu3Zuuo5qsQPH X-Received: by 2002:a17:903:2310:b0:1cc:4e9f:d27 with SMTP id d16-20020a170903231000b001cc4e9f0d27mr5599897plh.1.1700742655674; Thu, 23 Nov 2023 04:30:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700742655; cv=none; d=google.com; s=arc-20160816; b=PilYv38wkr0MEdYrXHuNkVYRFCfAuDoDyRZOmtPnFOgMLO0cuMSLtCZqPilQKjpD3w wbnjLcoT+oGzsePMn8eg06RkumSbIYGMyf54k7WUIQGpz6kWkWlkPWPPjQAtxpV8I6f1 d2cDxUyPlxMSQDmfkE3pnAPbekYf2gtL0HcvT678gAa/0aMv8Vt796+3MWYM4l+nY+2x yWL7q5qiMq7nhkkXpwMNP10Hb2xsHgOuMc0GPPQeotF9QRg41QLHUzhNWR26dStBTzr8 eloA9Mh98734y4KEuxml6jeoIG1akHExYtyEIGsP4lqhUKFNAhWDzikNspR3oDJ0UK0N jt0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=PaLyQKRyisx7xEIR1MhiUnEwsqH9lOlX1GcoNnRavdo=; fh=F59kH2ibA1iKyOsSsDQImk9HL2yTa3Z5dQrd+wmzkSE=; b=hWkecgNCKSxMiceDsSTgG5usQJHCgHw6Tgh6YKGx0q0ZUm1t67t+5H+J5WwMowc7WP z3L2pg8XZMFFhUGY1Sp4YkTxTPGSd/mMzdpi8a3t2w5a9qcO5qcjYL/CyoW0GBRenkUT H2OOln6VEzrz+MEEjuK8oXDEcfW/JonXcxopPJgOWiCRZClD5PScklz1x6bu3QROy0B9 KbUtCSRsmO+4Zp1dfJkxRrpGHqKyBivk1Jh/hV4wlprZrnX3N4YJBt2yzQq8WeitDKAJ qlYkrprZrA3sfYwynOpt8FyDMGX5ehhqt7Rg5ZVFicAgLvK/owW4nF5XMx7L+jMOyLDA fJCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id k17-20020a170902c41100b001cf5c99f2adsi1060226plk.261.2023.11.23.04.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 04:30:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A93298076C9C; Thu, 23 Nov 2023 04:30:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345292AbjKWMaI (ORCPT + 99 others); Thu, 23 Nov 2023 07:30:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345259AbjKWMaG (ORCPT ); Thu, 23 Nov 2023 07:30:06 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A9ECD120; Thu, 23 Nov 2023 04:30:11 -0800 (PST) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1r68qC-0000v8-00; Thu, 23 Nov 2023 13:29:56 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id D8DBEC0136; Thu, 23 Nov 2023 13:29:31 +0100 (CET) Date: Thu, 23 Nov 2023 13:29:31 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: Serge Semin , Arnd Bergmann , Andrew Morton , Mike Rapoport , Matthew Wilcox , Tiezhu Yang , Huacai Chen , Yinglu Yang , Alexey Malahov , Aleksandar Rikalo , Aleksandar Rikalo , Dragan Mladjenovic , Chao-ying Fu , Marc Zyngier , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Message-ID: References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-2-fancer.lancer@gmail.com> <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:30:23 -0800 (PST) On Thu, Nov 23, 2023 at 12:13:11PM +0000, Jiaxun Yang wrote: > > Ok. Thanks for the heads up. I'll fix the patch to be using ioremap() > > in v2. ioremap_uc() is just an macro-alias of ioremap() on MIPS. > > Perhaps we need to fix ioremap_cache so it can give a KSEG1 address? KSEG0 ? > AFAIK for Loongson DMI is located at cached memory so using ioremap_uc > blindly will cause inconsistency. why ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]