Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <84f9f3b7-54ef-42f6-a9d6-af4d763ed3bc@intel.com>
Date:   Thu, 23 Nov 2023 13:47:33 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [EXT] Re: [net PATCH 1/5] octeontx2-af: Adjust Tx credits when
 MCS external bypass is disabled
Content-Language: en-US
To:     Geethasowjanya Akula <gakula@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
References: <20231123055941.19430-1-gakula@marvell.com>
 <20231123055941.19430-2-gakula@marvell.com>
 <24e4edf1-14e3-460a-bc33-0b2177a49ee6@intel.com>
 <DM6PR18MB26021B0EDA9DCDAEC80A4A6CCDB9A@DM6PR18MB2602.namprd18.prod.outlook.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <DM6PR18MB26021B0EDA9DCDAEC80A4A6CCDB9A@DM6PR18MB2602.namprd18.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTV0TmkrTm0xV1JFVTlIc1V6Z3E4Tk83K0hCa25naWNKT2oyMTV1d2tkcm9t?=
 =?utf-8?B?MUZyWW9aZjRNbmJFNDVZcEFQaGtCdGxIV2RHOTBhY24vN1dnOXlHejBKNmY3?=
 =?utf-8?B?alBZVk1ianVGaDBWK2NFQzRsVUdmU0ppQmxlWENqUURFa295U1I1U01td2xk?=
 =?utf-8?B?SGgrWGwvelpUYmh1STlxaUtZOW80c3B4aXYrM3ZGWE1zRFg5M2FReTJZby84?=
 =?utf-8?B?VEY1ZzhyNm9ZdWlaNVZlSkgzeWZDVEk1MlR2WVRZU3R2NDFFL1dQM2xNbFpZ?=
 =?utf-8?B?TTk2NTRqc0pZZ3I5bnYvVjdJWVpzTlEzaFBoMmZNTUFYZmVJdmdFRVo0WkVh?=
 =?utf-8?B?MHlFV0YySi84YXFDYWdKOEdadTVZNnVmQ2xSZEJyZ0g1cXlMTkNWang5TzVw?=
 =?utf-8?B?TGlhVDQ3MGJXdGtMUk5vRlZHaXArWTZJZ0xrdUhHS1RMUHlnVERWVStOWUx3?=
 =?utf-8?B?cG1xUG9RNDgwZmNyQktUamU3dWZuSlR5TDBBMkJkK2VSNG0yaWtXSkdDSkF6?=
 =?utf-8?B?cnNLZ2pZTmIwVUpaZGhvWFlJUzhYWi8vTVpWbGlLZ0NPaWRYL0lSOUl5N0Ns?=
 =?utf-8?B?MklTcGdBU3dpanlGQ2RPQ1B1cVRkM3lmMGJySVdSdGZCcEFZVVBuRWhzUWRF?=
 =?utf-8?B?eXJPUGo5Vy9LYUQ0aFVHYlBmdVF0T21OWXZiUHprbE1PQi9SQldyVjZDNG54?=
 =?utf-8?B?TWVMM1NCd2FuMUxzZUF5NjAyRWlzSlVDZ0tTQlVNTElSd2dwQ0JqcWdNYmJn?=
 =?utf-8?B?dWswdVBDYVBKY1BPUU5pM3BPbHpyN3dvQ2FaUnF0aGF2ck9mbGZCZFMvQytJ?=
 =?utf-8?B?TzlYb0liaS9WZjFORDdmbHhqa00xQ3J5aXJFWHIzOVFTQkF1dkVRTWc4TE9q?=
 =?utf-8?B?TzdueDg3bFo1azE3SEFzYkZZS2J5aFZvRVc2Qmd5WHFIdEEvVnMzTmV6aXpy?=
 =?utf-8?B?NUM0bXdkUU1paDNzVzV0ek1pVnFMQjJyOVlidkNsLzExRENEYVc3Zy9Qcmwz?=
 =?utf-8?B?OXBmN1NCUnEvYmRaRnBvdE1QNUltNHhJMTBkMTVKT0o1WjI4NXdhKzJRYWVF?=
 =?utf-8?B?YkhaaWg2S2NXblVITzBkOXJjbjJyRkpUeTZ1bWlMbXJVUElzS2dxakVQaWF3?=
 =?utf-8?B?SG5MOEdNTmF2TjdlR1NDN3ZPRmZsbUQrNG8rNTJyUlNOOTVyYUhWOW5hOVFi?=
 =?utf-8?B?cE9TZzBDamxOY2h1aXk4My9TWmVDejlmazd6QTlnZkY2Q1hJY2lFNzdoSDJM?=
 =?utf-8?B?d2N0czNraWJhVS9JOTRwWVdmWmg2bEpCc2VBMlRQYTVFZm1ZUHVjV2tzUVZt?=
 =?utf-8?B?cDc5dklmbityYjVxcUp5MmdESFgrY1ZObG1EcSt6dHh0ZCtkbWtpb092THlr?=
 =?utf-8?B?cVc2aG9ib0lqTkNnR3dxUFpVNFZRbGswd2dSV3R6ZkVNbnErMEZLeVZ6L2FI?=
 =?utf-8?B?STUrOVJHajA2WW9ISWVSTzVTL2tiZW1TRm5HMmhPR012alJBZjJFd21kZDMw?=
 =?utf-8?B?SFZORVpFR2JtYUxwb3lVS2xzSkthMHZ0bTBpOGVKSUZqRGNzOGRCcnRLWHdo?=
 =?utf-8?B?TW03dk9iUDFDNVladkJtU1BmYTl3NlZYSkhxREhmN2NNQy9NMEs4TjFNWG9u?=
 =?utf-8?B?a3VEOFlHYURKWnYrNWxhck5FcXZublZERHFkbjFuTi9uY2NSVVBGZmVJdnhX?=
 =?utf-8?B?SHJkejQ0ejd4QkoyUHU2RE11V0cxT3c2aUZ2Yng3WVAwaWl1ZElaZGxKdVlG?=
 =?utf-8?B?b0F3Y1FSZUlLc2NBNnhkaEdKYnNCRmZWNXcyWittVDdzYUFPbkRSM2tGR1pw?=
 =?utf-8?B?aEpFdXAwT1RiKzdjdS9VUlZLb2NPbUZRYStHMzVFVng0MEhINmNwYktkWE1N?=
 =?utf-8?B?ZG16VStkUFlVa2RhUURnYzdjK1FYdjFHZk9Hd2FDRDE3cEIxbjdwNXkzUzQx?=
 =?utf-8?B?LzN3Q3F4Mkhtek9pS2VVL1AySzRXeVhKc0ZsZmF3anJmZVprcG1PV1phdFRL?=
 =?utf-8?B?elR0VFpHUkk4anAvSzdReWRTVlNVTmU2TmxTTXZ1eVNuUG9QZnY3M1gxaWZh?=
 =?utf-8?B?aUxCdS9CbDNXbGY1S01Rc1p6M2djOVV5U0pES0dPRWo5amJCdzVtNytrMk9R?=
 =?utf-8?B?bXk3K09mMStISk5rTHdKOTFUTnRwNlZ2SVM3TmV4SVF2VStMdGxJOW02ZlhN?=
 =?utf-8?B?YVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 27aacc7d-f020-45b2-e7b9-08dbec225f92
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 12:47:38.1919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Vp+JrgkCp5jOLVmunYyHM7PNVokx90VRjv6g1oQcSEAUjTNckdowsTnEyQFZGlf1dXO1rGrKAnTrfdG7rvQDd0AtFcQLEblvKEBtph+YNY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7315
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:47:58 -0800 (PST)


On 23.11.2023 13:34, Geethasowjanya Akula wrote:
> 
> 
>> -----Original Message-----
>> From: Wojciech Drewek <wojciech.drewek@intel.com>
>> Sent: Thursday, November 23, 2023 4:15 PM
>> To: Geethasowjanya Akula <gakula@marvell.com>; netdev@vger.kernel.org;
>> linux-kernel@vger.kernel.org
>> Cc: kuba@kernel.org; davem@davemloft.net; pabeni@redhat.com;
>> edumazet@google.com; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
>> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Hariprasad Kelam
>> <hkelam@marvell.com>
>> Subject: [EXT] Re: [net PATCH 1/5] octeontx2-af: Adjust Tx credits when MCS
>> external bypass is disabled
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>>
>>
>> On 23.11.2023 06:59, Geetha sowjanya wrote:
>>> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
>>>
>>> When MCS external bypass is disabled, MCS returns additional
>>> 2 credits(32B) for every packet Tx'ed on LMAC. To account for these
>>> extra credits, NIX_AF_TX_LINKX_NORM_CREDIT.CC_MCS_CNT
>>> needs to be configured as otherwise NIX Tx credits would overflow and
>>> will never be returned to idle state credit count causing issues with
>>> credit control and MTU change.
>>>
>>> This patch fixes the same by configuring CC_MCS_CNT at probe time for
>>> MCS enabled SoC's
>>>
>>> Fixes: bd69476e86fc ("octeontx2-af: cn10k: mcs: Install a default TCAM
>>> for normal traffic")
>>> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
>>> Signed-off-by: Geetha sowjanya <gakula@marvell.com>
>>> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
>>> ---
>>>  drivers/net/ethernet/marvell/octeontx2/af/mcs.c     | 12 ++++++++++++
>>>  drivers/net/ethernet/marvell/octeontx2/af/mcs.h     |  2 ++
>>>  drivers/net/ethernet/marvell/octeontx2/af/rvu.h     |  1 +
>>>  drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c |  8 ++++++++
>>>  4 files changed, 23 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
>>> b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
>>> index c43f19dfbd74..d6effbe46208 100644
>>> --- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
>>> +++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
>>> @@ -1219,6 +1219,17 @@ struct mcs *mcs_get_pdata(int mcs_id)
>>>  	return NULL;
>>>  }
>>>
>>> +bool is_mcs_bypass(int mcs_id)
>>> +{
>>> +	struct mcs *mcs_dev;
>>> +
>>> +	list_for_each_entry(mcs_dev, &mcs_list, mcs_list) {
>>> +		if (mcs_dev->mcs_id == mcs_id)
>>> +			return mcs_dev->bypass;
>>> +	}
>>> +	return true;
>>
>> If there is no mcs dev with the given id it means it is bypassed?
> Yes.

Makes sense
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>>
>>> +}
>>> +
>>>  void mcs_set_port_cfg(struct mcs *mcs, struct mcs_port_cfg_set_req
>>> *req)  {
>>>  	u64 val = 0;
>>> @@ -1447,6 +1458,7 @@ static void mcs_set_external_bypass(struct mcs
>> *mcs, u8 bypass)
>>>  	else
>>>  		val &= ~BIT_ULL(6);
>>>  	mcs_reg_write(mcs, MCSX_MIL_GLOBAL, val);
>>> +	mcs->bypass = bypass;
>>>  }
>>>
>>>  static void mcs_global_cfg(struct mcs *mcs)
>>
>>
>> <...>