Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 23 Nov 2023 13:51:47 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Ben Dooks <ben.dooks@codethink.co.uk>
CC:     <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>
Subject: Re: [PATCH] riscv: declare overflow_stack as exported from traps.c
Message-ID: <20231123-blooper-very-cefbf92c0f05@wendy>
References: <20231123134214.81481-1-ben.dooks@codethink.co.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="AAkSMNNL38JK6UIZ"
Content-Disposition: inline
In-Reply-To: <20231123134214.81481-1-ben.dooks@codethink.co.uk>
Precedence: bulk

--AAkSMNNL38JK6UIZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 23, 2023 at 01:42:14PM +0000, Ben Dooks wrote:
> The percpu area overflow_stacks is exported from arch/riscv/kernel/traps.c
> for use in the entry code, but is not declared anywhere. Add the relevant
> declaration to arch/riscv/include/asm/stacktrace.h to silence the followi=
ng
> sparse warning:
>=20
> arch/riscv/kernel/traps.c:395:1: warning: symbol '__pcpu_scope_overflow_s=
tack' was not declared. Should it be static?
>=20
> We don't add the stackinfo_get_overflow() call as for some of the other
> architectures as this doesn't seem to be used yet, so just silence the
> warning.
>=20
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
I suppose this should also be
Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")

Cheers,
Conor.

> ---
>  arch/riscv/include/asm/stacktrace.h | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/arch/riscv/include/asm/stacktrace.h b/arch/riscv/include/asm=
/stacktrace.h
> index f7e8ef2418b9..b1495a7e06ce 100644
> --- a/arch/riscv/include/asm/stacktrace.h
> +++ b/arch/riscv/include/asm/stacktrace.h
> @@ -21,4 +21,9 @@ static inline bool on_thread_stack(void)
>  	return !(((unsigned long)(current->stack) ^ current_stack_pointer) & ~(=
THREAD_SIZE - 1));
>  }
> =20
> +
> +#ifdef CONFIG_VMAP_STACK
> +DECLARE_PER_CPU(unsigned long [OVERFLOW_STACK_SIZE/sizeof(long)], overfl=
ow_stack);
> +#endif /* CONFIG_VMAP_STACK */
> +
>  #endif /* _ASM_RISCV_STACKTRACE_H */
> --=20
> 2.37.2.352.g3c44437643
>=20

--AAkSMNNL38JK6UIZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZV9Y8wAKCRB4tDGHoIJi
0h0SAQDcTTkoh0A97aUVYnh6fGQAyoM9vAAQlKvpypv3AJuD+gEAoEsaf1PuO36l
tNylF+mvaA8289yMcGPGOgABUq/p1As=
=qrsB
-----END PGP SIGNATURE-----

--AAkSMNNL38JK6UIZ--