Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp389459rdh; Thu, 23 Nov 2023 06:44:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeLjR1BscsX25ZDqpR9JiXXTvPNan9aKhKpJgyZYnSeD9MD8CfWKoJmzff/zDVwCzvuWPo X-Received: by 2002:a17:90b:4f48:b0:27d:8ad:69f9 with SMTP id pj8-20020a17090b4f4800b0027d08ad69f9mr5613226pjb.2.1700750667115; Thu, 23 Nov 2023 06:44:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700750667; cv=none; d=google.com; s=arc-20160816; b=uqCajzO024CdZqn9vqkdAKXjodvUMg0ovX4wBzK3ztsZOmOC2yNAlXRV8dj1dUWjc6 raqxU5bCfwFpN/I+hQU1PvzewwK+5p3fOdrKuXJJNEOrYekvNPhXlsYJWykKU6Ghxpxh YiI2LcL749mNWwYWItVLjBgIoPq+RVHG7fNcacTXOEp6p9wUfkLN2zmLCXsas/Ju8rRK XgHiG5Cjv6ZZx58eTbJxrvSzl0K4mjC5KjGi97GcqEAdmYREWyzIaddJQrJi2aKutC9T jf9HEI8vXAlwJhs/YKbIZdOUknyo6/DBYAzOV1iKfqVFIRBnb55jFUK/JliyeH6tXknB 1m9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=1+7AvHJjIM3thaE/1epeB6XcVD1TVhLtKMuA2cV98x0=; fh=N6kOWzzoyFx46KhufQEFsHexRnrKpkm1lLeFNNXuCFg=; b=XjMGhZ65+8q0BQKCzc9dJ7Hc5g1zH4CPK/fDNM0OurHe8IwD2w2ejpbrchAOouqvg4 QbpPyQH4Il6nlRwGvlLnK7GcmnNQNVP+ThmytwPr1cECRrQoUZLtfkvMXPppFc7ooyuw p1ORCHv4Wqb9fW56ACUdPzVsKLLbBeOC30+k/CugtrYnRhiRBHs6kUItgPYxl3vDkeGD nQRUYHyrp1SXigZh8MAnGDdPVHbczGmmAQtsUmG+w9eV0uiFwqNwQQPsHBi+KSAMQEMs Axu61VPj7P9rLG2mWO/T4DqUe8RNUB3ZUzBLTBGytPQaPClijVNlUEVPcj3Kmk2cnzsa ZTyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fastmail.org header.s=fm1 header.b=AkQxzzfe; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Pi4sCD+s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fastmail.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b1-20020a17090a10c100b002839dee7fc2si1404958pje.184.2023.11.23.06.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 06:44:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@fastmail.org header.s=fm1 header.b=AkQxzzfe; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Pi4sCD+s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fastmail.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D3BC180486B8; Thu, 23 Nov 2023 06:44:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345904AbjKWOnz (ORCPT + 99 others); Thu, 23 Nov 2023 09:43:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345864AbjKWOnu (ORCPT ); Thu, 23 Nov 2023 09:43:50 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1677BA4 for ; Thu, 23 Nov 2023 06:43:56 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 360913200A3F; Thu, 23 Nov 2023 09:43:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 23 Nov 2023 09:43:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750634; x= 1700837034; bh=1+7AvHJjIM3thaE/1epeB6XcVD1TVhLtKMuA2cV98x0=; b=A kQxzzfeh3TLofcDvbbsV0jqn2P2BA+jpGHZOXofQZ0MVwFhyrC3ZU+UgWzd1J0Nh eXroOMbWQZWVZSaNZGMX102rqaKDXYy1AL9/yvfgJJmsRpI1ix8C9cnavlf8CCpL OqyruE+X+SqDZkpamthfTHJ094BKUdxKUcYdBauD9AxjUo2YKurP426pf6AgsKQ5 MUGeg0zKvDlKj8bt5Utb/xyVVslWokch0hOPvE6gkcFAfOcD9I+xcKBYEV+s3V8z HrudkiJ9s5cjXVr8XnXP5WARyWIvVJ83XyAwVi2jiUsWzqdXzS72geRqPeYU+aZ6 1wxYQuKIb0G9AiY4FoR1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750634; x= 1700837034; bh=1+7AvHJjIM3thaE/1epeB6XcVD1TVhLtKMuA2cV98x0=; b=P i4sCD+sqVoHBS+4/EaGpFALOcIg8Xa6Z7ts/yCTyDB8LTEZkkS8K+rKjl7zyDbRV TS5Sx6vlJ4UR9NDT66KVBs8S6UzxFCBwyYml0Ub5kzo3F5aTAPVBko+6SUJlyZn8 +63JuqcjHHtCXPcLdEPsglmI3JwQSluRLzXr6Q+5vUZF27jozM/tMjjY4bkdvAxW Dk3NrTvIWzM/B9PK6EOxR1J84Uia/8++IFdXxCXg4ugknX7ioBeHrIU/b3qheNPu sOgCq2U3rC71xlIIl5Rt9skJtcGCkUaFmvfRHexAvwZ0mKkXtEwCyqSIAWV8g5KZ 6hQ+KhLw5uhDxT6rW4WnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:43:54 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 2/5] staging: rtl8192e: renamed variable TXCountToDataRate Date: Thu, 23 Nov 2023 09:43:34 -0500 Message-ID: <20231123144337.13112-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 06:44:07 -0800 (PST) Renamed from Pascal/CamelCase to Snake case the variable TXCountToDataRate. TXCountToDataRate -> tx_count_to_data_rate Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard --- v3: Corrected versioning from v1 -> v3, includes change history. v2: v2 was skipped over..v3 corrects this. v1 Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 280e335cbb6d..fb8294f31a60 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -114,7 +114,7 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 nMcsRate) return MCS_DATA_RATE[is40MHz][isShortGI][(nMcsRate & 0x7f)]; } -u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate) +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate) { u16 CCKOFDMRate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c}; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index d2cf3cfaaaba..0226a69f40c3 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1783,7 +1783,7 @@ extern u16 MCS_DATA_RATE[2][2][77]; u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); bool IsHTHalfNmodeAPs(struct rtllib_device *ieee); -u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate); +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c index f32584291704..28aba1d610f7 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -208,7 +208,7 @@ int rtllib_wx_get_rate(struct rtllib_device *ieee, { u32 tmp_rate; - tmp_rate = TxCountToDataRate(ieee, + tmp_rate = tx_count_to_data_rate(ieee, ieee->softmac_stats.CurrentShowTxate); wrqu->bitrate.value = tmp_rate * 500000; -- 2.41.0