Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp389528rdh; Thu, 23 Nov 2023 06:44:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTWz8iiM1+UvAQMzPaQCAd0mh+TDtsAeco3Nm6v3elzzgl8ciOB7sINH6UJnaHViIzf8iB X-Received: by 2002:a05:6a20:431b:b0:181:ed8b:4823 with SMTP id h27-20020a056a20431b00b00181ed8b4823mr6651469pzk.43.1700750673221; Thu, 23 Nov 2023 06:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700750673; cv=none; d=google.com; s=arc-20160816; b=SxjZJyHcFJbErY3ddV7C55i/alFYXJNkC3pA/AVteTbo30Lo0i5+nbfCK5CmUZ1TbT 6sGeyvG9K6WScBCdOFSe7BZrYAfjozm1NG1i/bSKAnQ8NzkKg7xcEqlrUsWlmDO1RNj7 maQWh9xJJGag/AHjjTusElxFbAlZmyawUF8L/S/m79+JmcUhX5VRuFpyvQqMsPv6qw7A 6xAnaNXbI5cbyHMIeggTUDsd+Ty+XT7TIs5u8KEnSAc6NhSBVQhIVVCa1uqOhx+KtD7u Lif+YFRReMzMogDXzC5NekLz7g1+SvdoGOzXhUkkePqRefsOGmn+2PIyUHow+5Gb1f3f J+jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=2+oCaAJMz2K+v99Rw3IHlg2+n9lVGfZLcZHc+W8P+GY=; fh=N6kOWzzoyFx46KhufQEFsHexRnrKpkm1lLeFNNXuCFg=; b=0wBHKzssa1wK0cz166gWCel9T14lz/RJrQ4il2kXO7uuA6bAnNtyFiswGp32QURztQ iJOu9VeCyu5yPm+amHPczEpXqWim9OqfYB+A0tpCyTgRlx/mY8cTV4ttly3BHARzyjXU c2+fBuDMz58eJPH3CecsTHuKMlj8VQQRV1m9YO/R7SOvnjLxsrCAEGYpuj05LVer1pkd LrJZQRQxdbTbtVRK7fvxO+EapTabnwugaVMw73KkEbVZ9Z7V+HDagDytn62j3cNfxPnR apKcb/A2yWVcYEnaDnbUqj1sWYvtJ0gFXU3VlZn9yu/mDbkaf/1S7YOnLoCJNrq1XYcZ amew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fastmail.org header.s=fm1 header.b="AcIxC/V0"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=YSlzWTSP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fastmail.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id s1-20020a63e801000000b005bd2b2ffcefsi1454119pgh.523.2023.11.23.06.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 06:44:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@fastmail.org header.s=fm1 header.b="AcIxC/V0"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=YSlzWTSP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fastmail.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 39C108288C9A; Thu, 23 Nov 2023 06:44:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345908AbjKWOoG (ORCPT + 99 others); Thu, 23 Nov 2023 09:44:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345905AbjKWOoA (ORCPT ); Thu, 23 Nov 2023 09:44:00 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 972A4D6E for ; Thu, 23 Nov 2023 06:44:04 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AC2AE3200A2D; Thu, 23 Nov 2023 09:44:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 23 Nov 2023 09:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750643; x= 1700837043; bh=2+oCaAJMz2K+v99Rw3IHlg2+n9lVGfZLcZHc+W8P+GY=; b=A cIxC/V0Md1kHOullpFMoe3xHyCziytcRjiSFuvolVNfOZPijJvBiWcMgrXnblNuH nIbCcH21BnaNSTXpDzpKZiZpo5AZjOPN9gWDLBYKV4MJ+Vlmr50F6RxKTH2DI6ZV CXqpMQ9G16RM/guAz2LlSjEUTo35A5fCiabCujC1l0Rpn0CoSokSqvbBAvbQ4hd7 OZz/FJyGlhukVFQo3I80WOIxg67EzOAOAhzqfCE8f4Wayhy4RMhs0dA3jgSt0ikz Yq2D/AgOxJgBw0WQOgkYHl2TOxbd+rb4gsR1bf8JmV86VM92d3s8rzi0bbqT+AE+ 8v5KcFj4rDUSN6+sU573A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750643; x= 1700837043; bh=2+oCaAJMz2K+v99Rw3IHlg2+n9lVGfZLcZHc+W8P+GY=; b=Y SlzWTSPOTp7izPAW4yi7TOtPUejcyem4+j00+fyRcTObuR1LJeq35foNCCkXHVVR hHKzPc4XDJ1YUcsmP4jsf8SPuq2GS0mdss+10rvYEfMLwAVJvjFFAxizfdAWUu0q 06ZaexNYieG/p/NxX7yviB89bnRyBc06VbGrxJTk5R0OFn0nzNfusOudjpVxykbu +0h9oqFfw25y2DPL9VFusX41kLSHO6DFeWjvfzxIRZKgFtDjuPC9Xu9fEp9nt9hE fXmW2MyVVrosexnwD9N3oQ4BgKXH3ePM7W67jjydG5bQwL91KTuaeRhl3yG4qNF+ R6sFsZjSdlHzLixmlaSwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:44:02 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 3/5] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Date: Thu, 23 Nov 2023 09:43:35 -0500 Message-ID: <20231123144337.13112-4-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 06:44:20 -0800 (PST) Renamed from Pascal/CamelCase to Snake case the variable IsHTHalfNmodeAPs. ISHTHalfNmodeAPs -> is_ht_half_nmode_aps Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard --- v3: Corrected versioning from v1 -> v3, includes change history. v2: v2 was skipped over..v3 corrects this. v1: Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index fb8294f31a60..0993263c13d3 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -139,7 +139,7 @@ u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate) return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf]; } -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee) +bool is_ht_half_nmode_aps(struct rtllib_device *ieee) { bool retValue = false; struct rtllib_network *net = &ieee->current_network; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 0226a69f40c3..6b549629087b 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1782,7 +1782,7 @@ extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee); +bool is_ht_half_nmode_aps(struct rtllib_device *ieee); u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 42d652fe8601..89bc38774fa7 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1872,7 +1872,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb) ieee->softmac_stats.rx_auth_rs_ok++; if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) { if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) { - if (IsHTHalfNmodeAPs(ieee)) { + if (is_ht_half_nmode_aps(ieee)) { bSupportNmode = true; bHalfSupportNmode = true; } else { -- 2.41.0