Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 23 Nov 2023 14:47:35 +0000
From:   Lee Jones <lee@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v1 2/4] leds: trigger: gpio: Convert to use kstrtox()
Message-ID: <20231123144735.GB1354538@google.com>
References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com>
 <20231103195310.948327-2-andriy.shevchenko@linux.intel.com>
 <20231123110538.GA1243364@google.com>
 <ZV9dd6khfmWmj6D_@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZV9dd6khfmWmj6D_@smile.fi.intel.com>
Precedence: bulk

On Thu, 23 Nov 2023, Andy Shevchenko wrote:

> On Thu, Nov 23, 2023 at 11:05:38AM +0000, Lee Jones wrote:
> > On Fri, 03 Nov 2023, Andy Shevchenko wrote:
> 
> ...
> 
> > > -	ret = sscanf(buf, "%u", &desired_brightness);
> 
> "%u" (see man sscanf() for the details)
> 
> ...
> 
> > > +	ret = kstrtou8(buf, 10, &desired_brightness);
> > 
> > Where does 10 come from?
> 
> See above.

Hmmm ...

I see that this is generally accepted.  Although is looks like a recipe
for bugs to me.  It's a shame we don't have something that can take a
variable, derives its type, then calculates the maximum length if
converted to a string.

Anyway, I'm probably babbling now ...

-- 
Lee Jones [李琼斯]