Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp392147rdh; Thu, 23 Nov 2023 06:48:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUQ5ewICwXe+TvgA0bt74obLbjaECYb8sPKC/E1o8JNHQGJEUbij3j8PkYfXoexHUFn9mv X-Received: by 2002:a05:6a20:e30b:b0:187:6d0a:c315 with SMTP id nb11-20020a056a20e30b00b001876d0ac315mr6770430pzb.23.1700750931564; Thu, 23 Nov 2023 06:48:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700750931; cv=none; d=google.com; s=arc-20160816; b=vcktsoxCEfXyBfZrtdPQwhBe2nAFsGtiEwtxdPYApJBETHzbFEH6/5+trzfe8McvRs i+mjdFuZXwu9v1QOZcScPa/US48q8MLqWwFeLhX0ief+KohLalWCch4ftr7qu+fAchqk fN8n4+upShxTexFYlKqheQGkq5eEiQ8rGkPBReUcf3PVYoYE6ZcwPYQUUViAEENekFzC j3b9d4KlxoGUZ08FEQaOR3eYTQQwtRa8uuTiGTem5QPWMOUipsFBujc2LvnZMUxTxDfE +3pR0tFPc0raWIrO+8efl6qlhaCLS6ea1CTr8WmCaSHrOpJ5kYNE+HEm+vZt5OULkLsB L1ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=T4MfKwfdSqwRgiiAailrOZIvGQhed9YrBJd2l3PrHBE=; fh=KT1clsGk4uKWEHsKNzQLnWjIglGaRiZK4xbXhkbDf4M=; b=dtbCQcCuZvstOnuf3NpvIoHWPXqsYdJbkqaIv5XVFlb1cNTuxe7FDhGb5BCvteuxez Sjfy6Brnv2KQNEBqDPHFyjHNRA68Qopf30bVmoqfRSfj/05zbtE74xXcf/ad89BFcT9p ZaINIypT4Uo+DslsmxhEWxZidKDWlC9k8kzgNC4b8ZlNvtuo3gUlK6fdL2BoO8UroSeu lmyKks27mPsvsLilRPF6R+1grNZzH/gVkfbFi/2E+mu+lWkNOfWwIclh4Xb+RmImC9It gz7geSdcSq7Azu7gu5vH+NwtrsCw6PrlP5TsDYW0aSi00DIyu1vtSbp5Fcbq3BmxqlvV mNFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KioWlU0z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id f11-20020a056a00238b00b0068a85532963si1400151pfc.160.2023.11.23.06.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 06:48:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KioWlU0z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 395C2829FDF8; Thu, 23 Nov 2023 06:48:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345895AbjKWOse (ORCPT + 99 others); Thu, 23 Nov 2023 09:48:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345872AbjKWOsd (ORCPT ); Thu, 23 Nov 2023 09:48:33 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90904D5E for ; Thu, 23 Nov 2023 06:48:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B336C433C8; Thu, 23 Nov 2023 14:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700750920; bh=u1dfPAl8WU4nH1bqr+U/uJcJjIRSFeshXRZIIy7HgTw=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=KioWlU0zmU30FWER87A8d5h5uul9ohvHD+i0X704NCKIYMg8CIhu8OYWNR5uH6hT9 8j/QU+ung6WIr/9ZNBmh+jvAYMUYATV2jaXsIL14e+VFrX7hIPPd4Y3C6KsnEgHZPt iz5pd3LzK2QpHtRFFpkZQEntsc47alcz746BqT+ZXscNP56Pn6c7j/Y/aVIm/ixask TXFjGn1/C03I72hRt9T6/hnVDW8sm1zKooGwdNYJwPjPE2rMNqazOnaVofLg03H1oc OmQpJ2vj+rLmvRGadRlf4fTLA8fvgSFXUeKpjc79nJozWWrBg83Fb8HlLStfYepPlu YENPJUi1+9zHQ== From: Lee Jones To: Andy Shevchenko , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Cc: Pavel Machek In-Reply-To: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v1 1/4] leds: trigger: gpio: Replace custom code for gpiod_get_optional() Message-Id: <170075091897.1365956.17632014819922518514.b4-ty@kernel.org> Date: Thu, 23 Nov 2023 14:48:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 06:48:48 -0800 (PST) On Fri, 03 Nov 2023 21:53:07 +0200, Andy Shevchenko wrote: > gpiod_get_optional() and currently used fwnode_gpiod_get_index() > are both wrappers against the same engine internally. Since we > have a pointer to struct device there is no reason to use fwnode > type of GPIO call. So, replace the current fwnode call by respective > gpiod ones. > > > [...] Applied, thanks! [1/4] leds: trigger: gpio: Replace custom code for gpiod_get_optional() commit: cafe2f8ed515e586b020a60df44e9f251f4d6248 [2/4] leds: trigger: gpio: Convert to use kstrtox() commit: 001813a6f0c7b05c139cde5d5177a4a9bfe39b09 [3/4] leds: trigger: gpio: Use sysfs_emit() to instead of s*printf() commit: bd4f0709c66394bb746c985872c4153ac93877b7 [4/4] leds: trigger: gpio: Convert to DEVICE_ATTR_RW() commit: 0603a253b18421a336c3be14bdcd1c5d75b6503b -- Lee Jones [李琼斯]