Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp395286rdh; Thu, 23 Nov 2023 06:54:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCgNgEDSilTC36Z0s2pqIboEmeovryhEjIDW3mzhBbYFDb94HDYW7GVylBSgoaGPeVxNkd X-Received: by 2002:a05:6a20:da8b:b0:187:a455:2758 with SMTP id iy11-20020a056a20da8b00b00187a4552758mr3996863pzb.30.1700751268572; Thu, 23 Nov 2023 06:54:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700751268; cv=none; d=google.com; s=arc-20160816; b=qKlWJ3nJ5t0npiNlVAJx8QpVuy1HziAIOF2FJFfCAqpjLZ3PPhxFSXNRD61d3zLEeP c3f+gxDXOYrvMEfMgc30NGYh2UgyVCOxj6wlLXnGlnR8h/CywHG5jIFrz9YNLxS9G1y7 btw4AY3UCdykZ9t0KRIY/DhB06FwlJR0FyZd8gu91i67hqCbNz/I1L9MlXpDE22b0y6A pOP16CfuBRbixlggAZ4Dw0HZmbO/ujJH9O6w7C3b2YYh5uKxth07h5Ua18/a7mXrdHzq sCy39+ybo4fg8LU6yUg5OmfSIrtZFBrgbMQYQvMRlJN3UYW1UhSZx9VX+KMqONj1HBfe 7Jmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=NQCVfDsgWY/zTEVOFXIzheR2Sa3G525xrhmxUR9vYaY=; fh=Xo7VbB4fcgRmRfcIp/tR2E1dN2SeXsBRsgTEzxBJQmM=; b=TfPehcs6ya5YXzwHhsYIEkFZRYutkzlZbczEQQxQun20RvUxEjQOv321ae5B7iJwr7 RwsX9eqH5lsLQrSxwonv1JZszCslUhScTvCh0XwlRhZBVLDJeyLk52+Og5xZ0SnE/vhL ZSwmuNqtWu4TuhOi+mISaYK9BF90QBAxMhxJVhZGERad8l1jXAFRcHQeONspJBTPBzmI g6P2iSYSx2H4P1oSosPrRWspxqJftmn9sYSgO74+ny+QmQJWXaaOwhm+8ZDucH2Xfeod nNtQjERZ1BDYjxJe3GBUO6E2aaXC3cJV2UZiXvNWfznAwJMsNTk+yYAlsp/uXyd0R6qQ ThgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xTY/PLMp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id p16-20020a056a000b5000b006c0e3332534si1429381pfo.42.2023.11.23.06.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 06:54:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xTY/PLMp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7FD20822D1FE; Thu, 23 Nov 2023 06:54:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345943AbjKWOyO (ORCPT + 99 others); Thu, 23 Nov 2023 09:54:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345818AbjKWOyK (ORCPT ); Thu, 23 Nov 2023 09:54:10 -0500 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F4BCD54 for ; Thu, 23 Nov 2023 06:54:17 -0800 (PST) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5ccf64439bdso9014087b3.0 for ; Thu, 23 Nov 2023 06:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700751256; x=1701356056; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NQCVfDsgWY/zTEVOFXIzheR2Sa3G525xrhmxUR9vYaY=; b=xTY/PLMpFbaFomzwHNSLOdlofBOgPClhPWKODikwkx3YFfRsqgS+hI9UCEW93DJ7KX h+8y1RKlHZpt5yFkzM+BbuXjzOQpFZjqlpwn5+XH14+N7o4iWLF9PdS15kUTE9n+Unmy 8rqxy31EHiZCU3XyG8fF5G98qJEDPJg+wYq2LClQKmNd/MC9zbrEdtPRx5JrATlAfxNa X7cunmGJp3VNOramYg2XGSSsQmpOgff+KeGnbTJXSLWr/YtajIxNDcab080kwfd9PLoZ VGgVg+xLwIdHJK/DcNT+mwCGqx4yT2PhAdq+2hhbJHz7bInb346istmKe+DreM5/mpaO Xrjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700751256; x=1701356056; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NQCVfDsgWY/zTEVOFXIzheR2Sa3G525xrhmxUR9vYaY=; b=Xuccd3j18hWst1ivC0GXqp8LPA7SDnW+obRXbq9J6ZrRCOLkDWoE1n9XZSmDDuhutM owgqYECLkUNoG3/umvCrISEInbIihP3wo1lG8H+/42Y8NiVEDw1J/w7zhJTEkLnWlVkg iVcBo1sYa9lX1mSjJHwwU5GH6inMpbO8aTM5BD4r5iWK/QpBPotAk1Sy+ASk1jqgfTPG GpBLNHnx+DhK745X5U9axoapT/XHjGnYNgvSxPRgO7eCMXQns8S4uctwfl4WijLyu+ql q3fYPvhDyLEJfnQtKDIQcEr5WtvaCmdv2X+shj6WgeI2/nQuRprMp49/FCNSKnRCf5ck Oe3w== X-Gm-Message-State: AOJu0YxOWDHymEojZ7iJPlohr6xjSJqTIe1C+UQKlsL2i2Q0t2VqWurM 8yX1hJWKS0l3HRVq6CLZX8OyquT7DQ/A+N2C5vDv8TcuqWO4ctFRxZg= X-Received: by 2002:a81:4fcd:0:b0:5cc:dfdf:7f40 with SMTP id d196-20020a814fcd000000b005ccdfdf7f40mr2326675ywb.2.1700751256151; Thu, 23 Nov 2023 06:54:16 -0800 (PST) MIME-Version: 1.0 References: <20231122175039.2289945-1-andriy.shevchenko@linux.intel.com> <20231122175039.2289945-3-andriy.shevchenko@linux.intel.com> In-Reply-To: <20231122175039.2289945-3-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Thu, 23 Nov 2023 15:54:04 +0100 Message-ID: Subject: Re: [PATCH v1 3/4] pinctrl: baytrail: Move default strength assignment to a switch-case To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 06:54:26 -0800 (PST) On Wed, Nov 22, 2023 at 6:50=E2=80=AFPM Andy Shevchenko wrote: > iWhen ->pin_config_set() is called from the GPIO library (assumed > GpioIo() ACPI resource), the argument can be 1, when, for example, > PullDefault is provided. In such case we supply sane default in > the driver. Move that default assingment to a switch-case, so > it will be consolidated in one place. > > Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij