Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp458520rdh; Thu, 23 Nov 2023 08:25:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhU5xJJP6YN00Bz4rkU6KMYYgG2wIktCd8qB8haTn8ZQvhNcVR4vobOixCUWNF9JYXbgnw X-Received: by 2002:aca:d12:0:b0:3a3:95f9:c99b with SMTP id 18-20020aca0d12000000b003a395f9c99bmr5795084oin.35.1700756743189; Thu, 23 Nov 2023 08:25:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700756743; cv=none; d=google.com; s=arc-20160816; b=azJo8db0PSZVpFoz03SHjDuDqvWYMo5AF5fKjjAVJ1hmvUuyABoD4RZu6qkHg+2rA3 D0tihT/3r7kfSuqduQ9LOu2nereNN7pDX91V0x88L31hiwmESwpvYFF4Px3zOvKAhfEt QwJO4ibzVKWPlJIf16/hgGUy05aYwF4nSzAHHvRlZpQhebZpgtnZqCuANLIWaAFyDCBc qfq+p65GOEOM5EtORV7o4apTfPVKCdj4xFmlw7EDJn4xklY/gU3GuaKZfFWCNN+xVGTH zW+zSWFtghq4SHzFIQdUA8KTmXe7hs3JODQDHLpm2WOufmdPDbBHuXRD+4RsHFPfi4GB acXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nlqMYQNgwBJ9qGJsSyHtmERdqPVaeF6uEGHYUBHXqWg=; fh=GlYS7EKTxGzg/INLWry9ygpsjW23ihvEYvqJYZO6af8=; b=Gnzyrvmjc/CGC7Oeq2yH40OVUTbkqzmPWIqqhfiZbkz9bLQci4TJVhYghPh6dGWYBn j12OThTEjzu45kDRcbpsrvigDudZTQOsnDiaUerK2kYteSICx48DSYehCQQQsNjcxPsR QHFP6DwNDl/n0kq81b1tN9LKJc5e82pZUg5aJa45ioBkU1M41xpwry9hX5icdM0LA4XZ ZIhGqFJmo/PF7EMqEI8x4qwxcTjLrlT1oWUdU33g0VKIZiD+xLy1yYnwrTiWZ85pqZgd 6lNmXWB4oMilqbav5PExm8diQwNd+CAFsDmyJDRIPjxyfKhV3zMFzQA2LwYtIPAwehuH gv+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dmnZyFi9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id q11-20020a631f4b000000b005c21d7d1126si1545567pgm.843.2023.11.23.08.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:25:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dmnZyFi9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 940D68077FA5; Thu, 23 Nov 2023 08:25:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345028AbjKWQYy (ORCPT + 99 others); Thu, 23 Nov 2023 11:24:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjKWQYw (ORCPT ); Thu, 23 Nov 2023 11:24:52 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AAC61A8 for ; Thu, 23 Nov 2023 08:24:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7570C433C9; Thu, 23 Nov 2023 16:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700756698; bh=8qbTRbdLFdnXb3Xe8uP0IN8YCP7nL2AK2pZi0k8jVmI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmnZyFi9UMYT31BH9Q3rAbNfIaVQ0bRDx2OxJp8JC3rGb5UBAa/ZbMLbt/oJhrtgy XQfk4Ja/ihC5b4N7oj+pbXArjp1ErDUiUsHfGVpN1prX6E4NqkVCAdTa7YKTx3RMzO CCzgc6Nc08iu4BX33NSVnfADwm12OkUR6BbVR+6uZ8my99h87K6pqcNq+QStsFkVkN iCdESVJWG2oGoQYr39+vyW7w17U6oydSDnJB0BBp/X2jXoJuRUEHiLoq2YXBgfo4D4 6JfNQmixj3sbRZEA4YVVRpfW+tL8FsdMvhdHGegCCfGhFpUx79OXEwzB9cAw0XEGkW VQwoEDItqb3tQ== Date: Thu, 23 Nov 2023 17:24:48 +0100 From: Christian Brauner To: Mark Brown Cc: Szabolcs Nagy , "Rick P. Edgecombe" , Deepak Gupta , "H.J. Lu" , Florian Weimer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Shuah Khan , linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Kees Cook , jannh@google.com, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , nd@arm.com Subject: Re: [PATCH RFT v3 0/5] fork: Support shadow stacks in clone3() Message-ID: <20231123-edelherzig-feiern-b53339f5a639@brauner> References: <20231120-clone3-shadow-stack-v3-0-a7b8ed3e2acc@kernel.org> <20231121-urlaub-motivieren-c9d7ee1a6058@brauner> <20231123-geflattert-mausklick-63d8ebcacffb@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:25:14 -0800 (PST) On Thu, Nov 23, 2023 at 11:37:54AM +0000, Mark Brown wrote: > On Thu, Nov 23, 2023 at 11:10:24AM +0100, Christian Brauner wrote: > > On Tue, Nov 21, 2023 at 04:09:40PM +0000, Mark Brown wrote: > > > On Tue, Nov 21, 2023 at 12:21:37PM +0000, Szabolcs Nagy wrote: > > > > The 11/21/2023 11:17, Christian Brauner wrote: > > > I'm still not enthusiastic that we only have one implementation for this > > in the kernel. What's the harm in waiting until the arm patches are > > merged? This shouldn't result in chicken and egg: if the implementations > > are sufficiently similar then we can do an appropriate clone3() > > extension. > > The main thing would be that it would mean that people doing userspace > enablement based on the merged x86 support can't use the stack size > control. It's not the end of the world if that has to wait a bit, it's > a bit of a detail thing, but it would make life easier, I guess the > userspace people can let us know if it's starting to be a real hassle > and we can reevaulate if that happens. > > It's also currently a dependency for the arm64 code so it'd be good to > at least get ageement that assuming nothing comes up in testing the > patches can go in along with the arm64 series, removing the dependency Oh yeah, I'm not fuzzed whose tree this goes through. By all means, take it with the arm64 series. > and then adding it as an incremental thing would be a hassle. It's > likely that the arm64 series will be held out of tree for a while to as > more complete userspace support is built up and validated so things > might be sitting for a while - we don't have hardware right now so we > can be cautious with the testing. Ok, that sounds good to me.