Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <c1f1f869346f4d6fc90eac6d131454b85fa676be.camel@redhat.com>
Subject: Re: [PATCH] mptcp: fix uninit-value in mptcp_incoming_options
From:   Paolo Abeni <pabeni@redhat.com>
To:     Edward Adam Davis <eadavis@qq.com>,
        syzbot+b834a6b2decad004cfa1@syzkaller.appspotmail.com
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, martineau@kernel.org,
        matthieu.baerts@tessares.net, matttbe@kernel.org,
        mptcp@lists.linux.dev, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Date:   Thu, 23 Nov 2023 17:41:31 +0100
In-Reply-To: <tencent_B0E02F1D6C009450E8D6EC06CC6C7B5E6C0A@qq.com>
References: <000000000000545a26060abf943b@google.com>
         <tencent_B0E02F1D6C009450E8D6EC06CC6C7B5E6C0A@qq.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-11-23 at 09:23 +0800, Edward Adam Davis wrote:
> Added initialization use_ack to mptcp_parse_option().
>=20
> Reported-by: syzbot+b834a6b2decad004cfa1@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> ---
>  net/mptcp/options.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index cd15ec73073e..c53914012d01 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -108,6 +108,7 @@ static void mptcp_parse_option(const struct sk_buff *=
skb,
>  			mp_opt->suboptions |=3D OPTION_MPTCP_DSS;
>  			mp_opt->use_map =3D 1;
>  			mp_opt->mpc_map =3D 1;
> +			mp_opt->use_ack =3D 0;
>  			mp_opt->data_len =3D get_unaligned_be16(ptr);
>  			ptr +=3D 2;
>  		}

LGTM, and syzbot tested it.

Acked-by: Paolo Abeni <pabeni@redhat.com>

@Edward: for future similar patches, please add also the=C2=A0tested tag
from syzbot, will make tracking easier.

Thanks!

Paolo